URL: https://github.com/SSSD/sssd/pull/977
Title: #977: sss_ptr_hash: internal refactoring
pbrezina commented:
"""
* `master`
* 88b23bf50dd1c12413f3314639de2c3909bd9098 - TESTS: added sss_ptr_hash unit
test
* 0bb1289252eec972ea26721a92adc7db47383f76 - sss_ptr_hash: internal
URL: https://github.com/SSSD/sssd/pull/977
Title: #977: sss_ptr_hash: internal refactoring
pbrezina commented:
"""
Failure is not related.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/977#issuecomment-586922172
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/977
Title: #977: sss_ptr_hash: internal refactoring
pbrezina commented:
"""
Ack. Thank you.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/977#issuecomment-586264129
___
sssd-devel mailing list
URL: https://github.com/SSSD/sssd/pull/977
Title: #977: sss_ptr_hash: internal refactoring
pbrezina commented:
"""
Ok, so looking at [hash_delete
definition](https://pagure.io/SSSD/ding-libs/blob/master/f/dhash/dhash.c#_1064)
it is safe to assume that the entry is either deleted or not found.
URL: https://github.com/SSSD/sssd/pull/977
Title: #977: sss_ptr_hash: internal refactoring
alexey-tikhonov commented:
"""
> I have few nitpicks, but otherwise I am ready to accept these changes.
I fixed two nitpicks and commented another.
Please let me know if you still (after reading my
URL: https://github.com/SSSD/sssd/pull/977
Title: #977: sss_ptr_hash: internal refactoring
pbrezina commented:
"""
Thank you. I have few nitpicks, but otherwise I am ready to accept these
changes.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/977#issuecomment-586216541
URL: https://github.com/SSSD/sssd/pull/977
Title: #977: sss_ptr_hash: internal refactoring
alexey-tikhonov commented:
"""
Downstream tests passed.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/977#issuecomment-585774357
___
URL: https://github.com/SSSD/sssd/pull/977
Title: #977: sss_ptr_hash: internal refactoring
alexey-tikhonov commented:
"""
> Do I understand correctly that idea is to assure that the only possible
> execution chain to get into `sss_ptr_hash_delete_cb()` is:
>
URL: https://github.com/SSSD/sssd/pull/977
Title: #977: sss_ptr_hash: internal refactoring
pbrezina commented:
"""
Yes.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/977#issuecomment-581346807
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/977
Title: #977: sss_ptr_hash: internal refactoring
alexey-tikhonov commented:
"""
> Thank you. It looks good to me. I have just some suggestions about deleting
> items that might simplify the code more...
Thank you for the feedback.
> The basic idea is
URL: https://github.com/SSSD/sssd/pull/977
Title: #977: sss_ptr_hash: internal refactoring
pbrezina commented:
"""
Thank you. It looks good to me. I have just some suggestions about deleting
items that might simplify the code more...
The basic idea is to move `hash_delete` into
URL: https://github.com/SSSD/sssd/pull/977
Title: #977: sss_ptr_hash: internal refactoring
alexey-tikhonov commented:
"""
> Remark: scratch build was verified with both
> https://bugzilla.redhat.com/show_bug.cgi?id=1783190 and
> https://bugzilla.redhat.com/show_bug.cgi?id=1792331
Also
URL: https://github.com/SSSD/sssd/pull/977
Title: #977: sss_ptr_hash: internal refactoring
alexey-tikhonov commented:
"""
Remark: scratch build was verified with both
https://bugzilla.redhat.com/show_bug.cgi?id=1783190 and
https://bugzilla.redhat.com/show_bug.cgi?id=1792331
"""
See the full
13 matches
Mail list logo
