[PATCH v2 2/2] regulator: core: Replace direct ops-disable usage

2014-02-20 Thread Markus Pargmann
There are many places where ops-disable is called directly. Instead we should use _regulator_do_disable() which also handles gpio regulators. Cc: stable@vger.kernel.org # 3.10+ Signed-off-by: Markus Pargmann m...@pengutronix.de --- drivers/regulator/core.c | 32 +---

Re: [PATCH v2 2/2] regulator: core: Replace direct ops-disable usage

2014-02-20 Thread Markus Pargmann
On Thu, Feb 20, 2014 at 12:07:52PM +0100, Markus Pargmann wrote: There are many places where ops-disable is called directly. Instead we should use _regulator_do_disable() which also handles gpio regulators. Cc: stable@vger.kernel.org # 3.10+ Signed-off-by: Markus Pargmann m...@pengutronix.de

Re: [PATCH v2 2/2] regulator: core: Replace direct ops-disable usage

2014-02-20 Thread Mark Brown
On Thu, Feb 20, 2014 at 12:07:52PM +0100, Markus Pargmann wrote: --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -1908,8 +1908,6 @@ static int _regulator_do_disable(struct regulator_dev *rdev) trace_regulator_disable_complete(rdev_get_name(rdev)); -

Re: [PATCH v2 2/2] regulator: core: Replace direct ops-disable usage

2014-02-20 Thread Markus Pargmann
On Thu, Feb 20, 2014 at 09:51:30PM +0900, Mark Brown wrote: On Thu, Feb 20, 2014 at 12:07:52PM +0100, Markus Pargmann wrote: --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -1908,8 +1908,6 @@ static int _regulator_do_disable(struct regulator_dev *rdev)

Re: [PATCH v2 2/2] regulator: core: Replace direct ops-disable usage

2014-02-20 Thread Mark Brown
On Thu, Feb 20, 2014 at 02:01:08PM +0100, Markus Pargmann wrote: I am using this function from _regulator_force_disable(), which calls _notifier_call_chain() with one additional flag REGULATOR_EVENT_FORCE_DISABLE. To prevent calling _notifier_call_chain() twice for the force_disable case, I