RE: [PATCH 1/2] block: Move general unplug callback function from md/raid to blk-core

2012-06-07 Thread Tao.Guo
; linux-ker...@vger.kernel.org; ne...@suse.de; ax...@kernel.dk; stable@vger.kernel.org; a...@linux-foundation.org Subject: Re: [PATCH 1/2] block: Move general unplug callback function from md/raid to blk-core 2012/6/5 tao@emc.com: If you ever tried to implement unplug function in umem, you

Re: [PATCH 1/2] block: Move general unplug callback function from md/raid to blk-core

2012-06-05 Thread Shaohua Li
2012/6/5 tao@emc.com: If you ever tried to implement unplug function in umem, you would find the code was almost identical as in dm/raid driver. For other components which also need such unplug mechanism, it will much more convenient to have such facilities. It's just several lines of

Re: [PATCH 1/2] block: Move general unplug callback function from md/raid to blk-core

2012-06-04 Thread Shaohua Li
On Mon, Jun 04, 2012 at 10:41:50AM -0400, Tao Guo wrote: Other components may also require an unplug callback, so move this function from md/raid to block generic layer. I saw no point this should be generic code, for example, why blk_plug_cb only handles only one request_queue? If umem needs

RE: [PATCH 1/2] block: Move general unplug callback function from md/raid to blk-core

2012-06-04 Thread Tao.Guo
Subject: Re: [PATCH 1/2] block: Move general unplug callback function from md/raid to blk-core On Mon, Jun 04, 2012 at 10:41:50AM -0400, Tao Guo wrote: Other components may also require an unplug callback, so move this function from md/raid to block generic layer. I saw no point this should