[set1 PATCH 2/4] scsi: fix eh wakeup (scsi_schedule_eh vs scsi_restart_operations)

2012-06-22 Thread Dan Williams
@vger.kernel.org Reported-by: Tom Jackson thomas.p.jack...@intel.com Tested-by: Tom Jackson thomas.p.jack...@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/scsi_error.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/scsi/scsi_error.c b

[set3 PATCH 2/6] libsas: continue revalidation

2012-06-22 Thread Dan Williams
-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/libsas/sas_expander.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c index af659cc..63c5742 100644 --- a/drivers/scsi/libsas

[set3 PATCH 3/6] libsas: fix sas_discover_devices return code handling

2012-06-22 Thread Dan Williams
: Tom Peng tom_p...@usish.com Cc: Jack Wang jack_w...@usish.com Cc: Lindar Liu lindar_...@usish.com Cc: Kevin Ao aoqing...@usish.com Cc: stable@vger.kernel.org Tested-by: Dan Melnic dan.mel...@amd.com Reported-by: Dan Melnic dan.mel...@amd.com Signed-off-by: Dan Williams dan.j.willi...@intel.com

[set5 PATCH 6/6] scsi: fix hot unplug vs async scan race

2012-06-22 Thread Dan Williams
...@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/scsi_scan.c |3 +++ drivers/scsi/scsi_sysfs.c | 41 ++--- 2 files changed, 29 insertions(+), 15 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c

[PATCH] libsas: fix taskfile corruption in sas_ata_qc_fill_rtf

2012-06-22 Thread Dan Williams
Murali pmur...@logicube.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/aic94xx/aic94xx_task.c |2 +- drivers/scsi/libsas/sas_ata.c | 12 ++-- include/scsi/libsas.h |6 -- 3 files changed, 11 insertions(+), 9 deletions(-) diff

[libsas PATCH v10 8/9] libsas: fix sas_find_bcast_phy() in the presence of 'vacant' phys

2012-03-10 Thread Dan Williams
@vger.kernel.org Signed-off-by: Thomas Jackson thomas.p.jack...@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/libsas/sas_expander.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers

[isci PATCH v2 09/18] isci: fix 'link-up' events occur after 'start-complete'

2012-03-10 Thread Dan Williams
-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/isci/host.c| 67 +-- drivers/scsi/isci/host.h|3 ++ drivers/scsi/isci/port_config.c | 18 ++ 3 files changed, 50 insertions(+), 38 deletions(-) diff --git a/drivers/scsi/isci

[PATCH] option: add Olivetti Olicard 200

2013-07-10 Thread Dan Williams
Speaks AT on interfaces 5 (command PPP) and 3 (secondary), other interface protocols are unknown. Cc: stable@vger.kernel.org Signed-off-by: Dan Williams d...@redhat.com --- diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 5dd857d..feda580 100644 --- a/drivers/usb

[PATCH] usb: add device IDs for Dell 5804 (Novatel E371) WWAN card

2013-05-01 Thread Dan Williams
A rebranded Novatel E371 for ATT's LTE bands. Cc: stable@vger.kernel.org Signed-off-by: Dan Williams d...@redhat.com --- See https://bugzilla.redhat.com/show_bug.cgi?id=955426 diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index 57136dc..299c53b 100644 --- a/drivers/net

Re: [PATCH] usb: add device IDs for Dell 5804 (Novatel E371) WWAN card

2013-05-01 Thread Dan Williams
On Wed, 2013-05-01 at 20:33 +0200, Bjørn Mork wrote: Dan Williams d...@redhat.com writes: A rebranded Novatel E371 for ATT's LTE bands. I don't think we're handling the Novatel branded E371 yet? I tried googling for ID of that, but were unable to find it. I guess you don't know either

Re: [PATCH] usb: add device IDs for Dell 5804 (Novatel E371) WWAN card

2013-05-01 Thread Dan Williams
On Wed, 2013-05-01 at 14:42 -0400, David Miller wrote: From: Bjørn Mork bj...@mork.no Date: Wed, 01 May 2013 20:33:10 +0200 Dan Williams d...@redhat.com writes: A rebranded Novatel E371 for ATT's LTE bands. I don't think we're handling the Novatel branded E371 yet? I tried

Re: [PATCH] usb: add device IDs for Dell 5804 (Novatel E371) WWAN card

2013-05-01 Thread Dan Williams
On Wed, 2013-05-01 at 13:01 -0500, Dan Williams wrote: A rebranded Novatel E371 for ATT's LTE bands. Cc: stable@vger.kernel.org Signed-off-by: Dan Williams d...@redhat.com Skip this patch as I'll split it up, and it's also whitespace damaged to to an Evolution issue I'm sorting out

Re: [PATCH] usb: add device IDs for Dell 5804 (Novatel E371) WWAN card

2013-05-01 Thread Dan Williams
On Wed, 2013-05-01 at 15:20 -0500, dag dg wrote: Vendor ID is 413c Product ID is 819b Bjorn meant the actual Novatel E371 device IDs... Dan On Wed, May 1, 2013 at 3:19 PM, Bjørn Mork bj...@mork.no wrote: Dan Williams d...@redhat.com writes: On Wed, 2013-05-01 at 20:33 +0200, Bjørn

Re: [PATCH] usb: add device IDs for Dell 5804 (Novatel E371) WWAN card

2013-05-01 Thread Dan Williams
don't need to go looking for it if you don't want to. Dan On Wed, May 1, 2013 at 3:24 PM, Dan Williams d...@redhat.com wrote: On Wed, 2013-05-01 at 15:20 -0500, dag dg wrote: Vendor ID is 413c Product ID is 819b Bjorn meant the actual Novatel E371 device IDs... Dan On Wed, May 1

qmi_wwan/cdc_ether: add device IDs for Dell 5804 (Novatel E371) WWAN card

2013-05-06 Thread Dan Williams
A rebranded Novatel E371 for ATT's LTE bands. qmi_wwan should drive this device, while cdc_ether should ignore it. Even though the USB descriptors are plain CDC-ETHER that USB interface is a QMI interface. Cc: stable@vger.kernel.org Signed-off-by: Dan Williams d...@redhat.com --- drivers/net

[PATCH] option: add device IDs for Dell 5804 (Novatel E371) WWAN card

2013-05-06 Thread Dan Williams
A rebranded Novatel E371 for ATT's LTE bands. Cc: stable@vger.kernel.org Signed-off-by: Dan Williams d...@redhat.com --- drivers/usb/serial/option.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 7343728..58cbb94 100644

[PATCH] qmi_wwan/cdc_ether: add device IDs for Dell 5804 (Novatel E371) WWAN card

2013-05-06 Thread Dan Williams
A rebranded Novatel E371 for ATT's LTE bands. qmi_wwan should drive this device, while cdc_ether should ignore it. Even though the USB descriptors are plain CDC-ETHER that USB interface is a QMI interface. Cc: stable@vger.kernel.org Signed-off-by: Dan Williams d...@redhat.com --- drivers/net

Re: [PATCH] qmi_wwan/cdc_ether: add device IDs for Dell 5804 (Novatel E371) WWAN card

2013-05-08 Thread Dan Williams
On Wed, 2013-05-08 at 12:19 -0700, David Miller wrote: From: dag dg dagofthed...@gmail.com Date: Wed, 8 May 2013 14:11:48 -0500 Just a side note on this. By default for this device, modprobe won't load and assign the option driver. However, if cdc_ether is blacklisted and you try to load

Re: [PATCH] USB: option: add ZTE K5006-Z

2012-08-15 Thread Dan Williams
On Wed, 2012-08-15 at 15:43 +0200, Bjørn Mork wrote: The ZTE (Vodafone) K5006-Z use the following interface layout: 00 DIAG 01 secondary 02 modem 03 networkcard 04 storage Ignoring interface #3 which is handled by the qmi_wwan driver. At some point you should just start adding them

[resend PATCH] scsi_remove_target: fix softlockup regression on hot remove

2012-08-28 Thread Dan Williams
...@gmail.com Tested-by: John Drescher dresche...@gmail.com Signed-off-by: Dan Williams d...@fb.com --- Jack, thanks for the reminder to cc stable! drivers/scsi/scsi_sysfs.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/scsi_sysfs.c b

Re: [resend PATCH] scsi_remove_target: fix softlockup regression on hot remove

2012-08-29 Thread Dan Williams
On Wed, 2012-08-29 at 06:50 +, Bart Van Assche wrote: On 08/29/12 05:12, Dan Williams wrote: John reports: BUG: soft lockup - CPU#2 stuck for 23s! [kworker/u:8:2202] [..] Call Trace: [8141782a] scsi_remove_target+0xda/0x1f0 [81421de5] sas_rphy_remove+0x55

Re: [resend PATCH] scsi_remove_target: fix softlockup regression on hot remove

2012-09-04 Thread Dan Williams
On Tue, Sep 4, 2012 at 7:02 AM, John Drescher dresche...@gmail.com wrote: On Wed, Aug 29, 2012 at 10:59 AM, Dan Williams d...@fb.com wrote: On Wed, 2012-08-29 at 06:50 +, Bart Van Assche wrote: On 08/29/12 05:12, Dan Williams wrote: John reports: BUG: soft lockup - CPU#2 stuck for 23s

[PATCH 1/6] Revert serial/8250_pci: init-quirk msi support for kt serial controller

2012-04-06 Thread Dan Williams
at suspend/resume seems like a bug in its own right. [stable: 3.3.x] Cc: stable@vger.kernel.org Cc: Alan Cox a...@linux.intel.com Cc: Sudhakar Mamillapalli sudha...@fb.com Reported-by: Nhan H Mai nhan.h@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/tty/serial/8250

[PATCH 2/6] Revert serial/8250_pci: setup-quirk workaround for the kt serial controller

2012-04-06 Thread Dan Williams
...@fb.com Reported-by: Nhan H Mai nhan.h@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/tty/serial/8250/8250.c |4 +--- drivers/tty/serial/8250/8250_pci.c | 17 + include/linux/serial_core.h|1 - 3 files changed, 2 insertions(+), 20

[PATCH 04/12] libsas: fix sas_find_bcast_phy() in the presence of 'vacant' phys

2012-04-13 Thread Dan Williams
@vger.kernel.org Signed-off-by: Thomas Jackson thomas.p.jack...@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/libsas/sas_expander.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers

[PATCH for 3.4] isci: fix oem parameter validation on single controller skus

2012-04-13 Thread Dan Williams
Jiang dave.ji...@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- James, Since this is a one liner and no other isci regression fixes pending I'm just sending the patch and not creating a signed tag for it. -- Dan drivers/scsi/isci/init.c |2 +- 1 file changed, 1

Re: ALERT: md/raid6 data corruption risk.

2014-08-18 Thread Dan Williams
kernel since then. In an older kernel with separate handle_stripe5() and handle_stripe6() functions that patch must change handle_stripe6(). Cc: stable@vger.kernel.org (2.6.32+) Fixes: 6c0069c0ae9659e3a91b68eaed06a5c6c37f45c8 Cc: Yuri Tikhonov y...@emcraft.com Cc: Dan Williams dan.j.willi

[PATCH] libsas: fix usage of ata_tf_to_fis

2013-10-22 Thread Dan Williams
...@marvell.com Cc: stable@vger.kernel.org Reported-by: Praveen Murali pmur...@logicube.com Tested-by: Praveen Murali pmur...@logicube.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/libsas/sas_ata.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers

[PATCH 1/4] ioatdma: fix sed pool selection

2013-11-13 Thread Dan Williams
count is 8 we can just calculate the sed pool by (src_cnt - 2) 3. Cc: Dave Jiang dave.ji...@intel.com Cc: stable@vger.kernel.org Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/dma/ioat/dma_v3.c | 16 +--- 1 files changed, 1 insertions(+), 15 deletions(-) diff

[PATCH 2/4] ioatdma: fix selection of 16 vs 8 source path

2013-11-13 Thread Dan Williams
(). Besides not accounting for implied sources the check is redundant given we already made the path selection. Cc: stable@vger.kernel.org Cc: Dave Jiang dave.ji...@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/dma/ioat/dma_v3.c | 30 +++--- 1

[PATCH] ioat: fix tasklet tear down

2014-02-19 Thread Dan Williams
-by: Stanislav Fomichev stfomic...@yandex-team.ru Signed-off-by: Dan Williams dan.j.willi...@intel.com --- Passes my testing, but would appreciate a tested-by. drivers/dma/ioat/dma.c| 52 +++-- drivers/dma/ioat/dma.h|1 + drivers/dma/ioat

Re: [PATCH] ioat: fix tasklet tear down

2014-02-20 Thread Dan Williams
On Thu, Feb 20, 2014 at 2:30 AM, Thomas Gleixner t...@linutronix.de wrote: B1;3202;0cOn Wed, 19 Feb 2014, Dan Williams wrote: Since commit 77873803363c net_dma: mark broken we no longer pin dma engines active for the network-receive-offload use case. As a result the -free_chan_resources

Re: [PATCH RESEND] SCSI: sd: don't fail if the device doesn't recognize SYNCHRONIZE CACHE

2014-03-05 Thread Dan Williams
to suspend :) Could anyone from the SCSI people have a quick look maybe? Acked-by: Dan Williams dan.j.willi...@intel.com But I agree with Tejun [1], that this likely does not go far enough. We should also be looking to fail future writes to the device or disabling the cache. Tejun's comment: Ooh

[PATCH] isci: fix reset timeout handling

2013-12-09 Thread Dan Williams
...@intel.com Tested-by: Xun Ni xun...@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/isci/port_config.c |5 - drivers/scsi/isci/task.c|2 +- 2 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/isci/port_config.c b/drivers/scsi

[PATCH 1/3] net_dma: mark broken

2013-12-17 Thread Dan Williams
...@intel.com Reported-by: David Whipple whip...@securedatainnovations.ch Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/dma/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 132a4fd375b2..c823daaf9043

Re: [PATCH 1/3] net_dma: mark broken

2013-12-18 Thread Dan Williams
[ adding davem directly to cc ] Dave, looking for an ack to take this through the dmaengine tree, and wondering if you want me to take patch 2 through dmaengine as well: http://marc.info/?l=linux-netdevm=138732577614066w=2 On Tue, Dec 17, 2013 at 4:15 PM, Dan Williams dan.j.willi...@intel.com

[PATCH v2] isci: fix reset timeout handling

2014-01-03 Thread Dan Williams
xun...@intel.com Tested-by: Xun Ni xun...@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- v2: Dave reported the build warning regression the last patch caused, and I clarified the changelog a bit. drivers/scsi/isci/port_config.c |7 --- drivers/scsi/isci/task.c

Re: Include da87ca4d4ca101f177fffd84f1f0a5e4c0343557 (ioat: fix tasklet tear down) for 3.2, 3.5, 3.8

2014-03-31 Thread Dan Williams
On Sun, Mar 30, 2014 at 2:29 PM, Ben Hutchings b...@decadent.org.uk wrote: On Sat, 2014-03-15 at 15:05 -0600, Tim Gardner wrote: Dan - attached are 2 patches for stable inclusion in kernel versions 3.2, 3.5, and 3.8. The first patch 8a52b9ff1154a68b6a2a8da9a31a87e52f5f6418 (ioatdma: channel

[PATCH] libata/ahci: accommodate tag ordered controllers

2014-03-31 Thread Dan Williams
it this way now. So, drives in the field are already experienced with this tag ordering scheme. Cc: stable@vger.kernel.org Cc: Dave Jiang dave.ji...@intel.com Cc: Ed Ciechanowski ed.ciechanow...@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/ata/libata-core.c | 21

[PATCH v2] libata/ahci: accommodate tag ordered controllers

2014-04-17 Thread Dan Williams
it this way now. So, drives in the field are already experienced with this tag ordering scheme. Cc: stable@vger.kernel.org Cc: Dave Jiang dave.ji...@intel.com Cc: Ed Ciechanowski ed.ciechanow...@intel.com Reviewed-by: Matthew Wilcox matthew.r.wil...@intel.com Signed-off-by: Dan Williams

Re: [patch NOT added to the 3.12 stable tree] dmaengine: fix dmaengine_unmap failure

2014-06-06 Thread Dan Williams
On Fri, Jun 6, 2014 at 6:05 AM, Jiri Slaby jsl...@suse.cz wrote: From: Xuelin Shi xuelin@freescale.com This patch does NOT apply to the 3.12 stable tree. If you still want it applied, please provide a backport. Thanks for the heads up. No backport needed, this unmap facility was

[boot regression PATCH] libata: allow xgene-ahci to opt-out of tag ordered submission

2014-06-06 Thread Dan Williams
matthew.r.wil...@intel.com Tested-by: Ming Lei ming@canonical.com Reported-by: Ming Lei ming@canonical.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/ata/ahci_xgene.c |2 ++ drivers/ata/libata-core.c | 42 +++--- drivers/ata/libata.h

Re: [boot regression PATCH] libata: allow xgene-ahci to opt-out of tag ordered submission

2014-06-06 Thread Dan Williams
On Fri, Jun 6, 2014 at 8:52 AM, Dan Williams dan.j.willi...@intel.com wrote: Ming Lei reports: Looks the commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers) causes below sata failure on APM AHCI controller. And the error does disappear after reverting the commit

[PATCH 1/4] isci: fix reset timeout handling

2014-02-06 Thread Dan Williams
xun...@intel.com Tested-by: Xun Ni xun...@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/isci/port_config.c |7 --- drivers/scsi/isci/task.c|2 +- 2 files changed, 1 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/isci/port_config.c b

[PATCH 4/4] isci: correct erroneous for_each_isci_host macro

2014-02-06 Thread Dan Williams
Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/isci/host.h |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/isci/host.h b/drivers/scsi/isci/host.h index 4911310a38f5..22a9bb1abae1 100644 --- a/drivers/scsi/isci/host.h +++ b/drivers/scsi

[PATCH 3/4] isci: fix needless ata reset escalations

2014-02-06 Thread Dan Williams
-sata_dev.fis[2] = ATA_ERR; The end effect is that isci is needlessly triggering hard resets when they are not necessary. Cc: stable@vger.kernel.org Reported-by: Xun Ni xun...@intel.com Tested-by: Nelson Cheng nelson.ch...@intel.com Acked-by: Lukasz Dorau lukasz.do...@intel.com Signed-off-by: Dan

Re: [PATCH] USB: option: add Yota / Megafon M100-1 4g modem

2013-02-12 Thread Dan Williams
On Tue, 2013-02-12 at 13:42 +0100, Bjørn Mork wrote: Interface layout: 00 CD-ROM 01 debug COM port 02 AP control port 03 modem 04 usb-ethernet Any idea what AT command set the thing uses? If it's got an ethernet port, then it's going to have some proprietary commands to start/stop

Re: [PATCH] USB: option: add Yota / Megafon M100-1 4g modem

2013-02-13 Thread Dan Williams
On Wed, 2013-02-13 at 08:53 +0100, Bjørn Mork wrote: Dan Williams d...@redhat.com writes: On Tue, 2013-02-12 at 13:42 +0100, Bjørn Mork wrote: Interface layout: 00 CD-ROM 01 debug COM port 02 AP control port 03 modem 04 usb-ethernet Any idea what AT command set

Re: 答复: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-06 Thread Dan Williams
On Wed, 2013-03-06 at 09:44 +0800, Greg KH wrote: On Wed, Mar 06, 2013 at 01:34:44AM +, Linlei (Lei Lin) wrote: Hello Mork, -- Because in the embedded linux system, Android, or Chrome OS, etc. They don't integrate userspace usb_modeswitch utility for switching. Why

Re: WTF: patch [PATCH] net_dma: simple removal was seriously submitted to be applied to the 3.17-stable tree?

2014-10-23 Thread Dan Williams
Yes, seriously submitted. On Thu, Oct 23, 2014 at 12:42 AM, gre...@linuxfoundation.org wrote: The patch below was submitted to be applied to the 3.17-stable tree. I fail to see how this patch meets the stable kernel rules as found at Documentation/stable_kernel_rules.txt. I could be

Re: WTF: patch [PATCH] net_dma: simple removal was seriously submitted to be applied to the 3.17-stable tree?

2014-10-23 Thread Dan Williams
On Thu, Oct 23, 2014 at 6:52 AM, Roman Gushchin kl...@yandex-team.ru wrote: That find by Roman discovered that even though NET_DMA was marked broken we were still attempting to pin pages for dma offload. Not really. Actually I had NET_DMA in my config by mistake. Well, that is material to

Re: WTF: patch [PATCH] net_dma: simple removal was seriously submitted to be applied to the 3.17-stable tree?

2014-10-27 Thread Dan Williams
On Thu, Oct 23, 2014 at 8:57 AM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Oct 23, 2014 at 07:14:20AM -0700, Dan Williams wrote: On Thu, Oct 23, 2014 at 6:52 AM, Roman Gushchin kl...@yandex-team.ru wrote: That find by Roman discovered that even though NET_DMA was marked broken we

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-27 Thread Dan Williams
On Mon, 2014-10-27 at 20:40 +0100, Oliver Neukum wrote: On Mon, 2014-10-27 at 19:07 +0100, Johan Hovold wrote: I guess we could use that quirk, but I'm actually leaning towards just removing that quirk and reducing the log level of the message to info. Oliver, what do you say? Now

Re: [PATCH] USB: cdc-acm: add device id for GW Instek AFG-2225

2014-10-28 Thread Dan Williams
On Tue, 2014-10-28 at 10:26 +0100, Oliver Neukum wrote: On Tue, 2014-10-28 at 10:05 +0100, Bjørn Mork wrote: Johan Hovold jo...@kernel.org writes: Today, only one device has the NOT_A_MODEM flag (*only* to prevent one message during probe), and most devices are simply matched on the

[bz87101 PATCH] libata: allow sata_sil24 to opt-out of tag ordered submission

2014-10-29 Thread Dan Williams
...@online.de Signed-off-by: Dan Williams dan.j.willi...@intel.com --- There's an open question if the tag ordering is just exposing a separate bug in sata_sil24, similar to how xgene identified a separate fix when it tripped over commit 8a4aeec8d libata/ahci: accommodate tag ordered controllers: http

[PATCH 1/2] libata: allow sata_sil24 to opt-out of tag ordered submission

2015-01-16 Thread Dan Williams
...@online.de Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/ata/libata-core.c |5 - drivers/ata/sata_sil24.c |2 +- include/linux/libata.h|1 + 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c

[PATCH 0/2] fix sil24 regression and muddy the ata tag allocation waters

2015-01-16 Thread Dan Williams
with replacing it with something better from the block layer, but that implementation had better address the quirk that patch1 does. [1]: https://bugzilla.kernel.org/show_bug.cgi?id=87101 [2]: http://marc.info/?l=linux-idem=141511124009903w=2 --- Dan Williams (2): libata: allow sata_sil24 to opt

[PATCH v2] libsas: fix sysfs group not found warnings at port teardown time

2015-05-20 Thread Dan Williams
below sas_port, but recent sysfs changes now exposes this problem. Libsas should delete all the devices from rphy down before deleting the parent port. Cc: stable@vger.kernel.org Reported-by: Praveen Murali pmur...@logicube.com Tested-by: Praveen Murali pmur...@logicube.com Signed-off-by: Dan

[PATCH] libsas: fix sysfs group not found warnings at port teardown time

2015-05-20 Thread Dan Williams
-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/libsas/sas_discover.c |6 +++--- drivers/scsi/libsas/sas_port.c |1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/libsas/sas_discover.c b/drivers/scsi/libsas/sas_discover.c index 60de66252fa2

Re: [PATCH -stable] block: fix ext_dev_lock lockdep report

2015-06-11 Thread Dan Williams
On Thu, Jun 11, 2015 at 12:51 AM, Jiri Slaby jsl...@suse.cz wrote: On 06/11/2015, 05:47 AM, Dan Williams wrote: = [ INFO: inconsistent lock state ] 4.1.0-rc7+ #217 Tainted: G O - inconsistent {SOFTIRQ-ON-W

[for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-06-17 Thread Dan Williams
now exposes this problem. Libsas should delete all the devices from rphy down before deleting the parent port. Cc: stable@vger.kernel.org Reported-by: Praveen Murali pmur...@logicube.com Tested-by: Praveen Murali pmur...@logicube.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers

[PATCH -stable] block: fix ext_dev_lock lockdep report

2015-06-10 Thread Dan Williams
allocation lifetime) Cc: stable@vger.kernel.org Cc: Keith Busch keith.bu...@intel.com Reported-by: NeilBrown ne...@suse.de Signed-off-by: Dan Williams dan.j.willi...@intel.com --- Note that 2da78092dda1 had Cc: sta...@kernel.org instead of @vger.kernel.org. block/genhd.c | 12 ++-- 1 file

Re: [PATCH] usb-storage: ignore ZTE MF 823 in mode 0x1225

2015-07-02 Thread Dan Williams
On Thu, 2015-07-02 at 15:43 +0200, Oliver Neukum wrote: On Thu, 2015-07-02 at 20:33 +0700, Lars Melin wrote: On 2015-07-02 20:01, Oliver Neukum wrote: On Thu, 2015-07-02 at 14:43 +0200, Oliver Neukum wrote: On Wed, 2015-07-01 at 22:50 +0700, Lars Melin wrote: Then I would like to

Re: [for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-07-27 Thread Dan Williams
On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed, 2015-07-22 at 14:08 -0700, Dan Williams wrote: On Wed, Jul 22, 2015 at 11:28 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: } void sas_device_set_phy(struct

Re: [for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-07-27 Thread Dan Williams
On Mon, Jul 27, 2015 at 10:11 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Mon, 2015-07-27 at 08:48 -0700, Dan Williams wrote: On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed, 2015-07-22 at 14:08 -0700, Dan Williams

Re: [for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-07-27 Thread Dan Williams
On Mon, Jul 27, 2015 at 11:07 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Mon, 2015-07-27 at 08:48 -0700, Dan Williams wrote: On Mon, Jul 27, 2015 at 8:17 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed, 2015-07-22 at 14:08 -0700, Dan Williams

Re: [for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-07-27 Thread Dan Williams
On Mon, Jul 27, 2015 at 11:38 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: No, that seems to be the intent of the prior code. The reason port visibility goes immediately (along with all associated phys), is that the port is ready for reuse as soon as sas_deform_port()

Re: [for 4.1 PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-07-22 Thread Dan Williams
On Wed, Jul 22, 2015 at 11:28 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed, 2015-06-17 at 23:22 -0400, Dan Williams wrote: Praveen reports: After some debugging this is what I have found sas_phye_loss_of_signal gets triggered on phy_event from mvsas

[PATCH resend] libsas: fix sysfs group not found warnings at port teardown time

2015-07-20 Thread Dan Williams
now exposes this problem. Libsas should delete all the devices from rphy down before deleting the parent port. Cc: stable@vger.kernel.org Reported-by: Praveen Murali pmur...@logicube.com Tested-by: Praveen Murali pmur...@logicube.com Reviewed-by: Hannes Reinecke h...@suse.de Signed-off-by: Dan

[PATCH v4 06/14] libnvdimm, pmem: fix size trim in pmem_direct_access()

2015-11-08 Thread Dan Williams
This masking prevents access to the end of the device via dax_do_io(), and is unnecessary as arch_add_memory() would have rejected an unaligned allocation. Cc: <stable@vger.kernel.org> Cc: Ross Zwisler <ross.zwis...@linux.intel.com> Signed-off-by: Dan Williams <dan.j.wil

[PATCH v4 00/14] block, dax updates for 4.4

2015-11-08 Thread Dan Williams
us hotplug and coredump support) for this cycle. Please holler if you see any problems, or if you would like more time (i.e. wait for 4.5) to review. --- Dan Williams (14): pmem, dax: clean up clear_pmem() dax: increase granularity of dax_clear_blocks() operations dax: use HPAGE_SI

[PATCH] dax: fix __dax_pmd_fault crash

2015-11-12 Thread Dan Williams
gt; Cc: Andrew Morton <a...@linux-foundation.org> Reported-by: Ross Zwisler <ross.zwis...@linux.intel.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- fs/dax.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/fs/dax.c b/fs/dax.c index 131fd35ae39d..bff2

Re: [PATCH v2] libnvdimm, e820: fix numa node for e820-type-12 pmem ranges

2015-11-13 Thread Dan Williams
On Fri, Nov 13, 2015 at 8:48 AM, Toshi Kani <toshi.k...@hpe.com> wrote: > On Thu, 2015-11-12 at 09:53 -0800, Dan Williams wrote: >> Rather than punt on the numa node for these e820 ranges try to find a >> better answer with memory_add_physaddr_to_nid() when it is availab

Re: [PATCH] mm, dax: fix DAX deadlocks (COW fault)

2015-11-16 Thread Dan Williams
ss Zwisler <ross.zwis...@linux.intel.com> > Cc: Alexander Viro <v...@zeniv.linux.org.uk> > Cc: Dan Williams <dan.j.willi...@intel.com> > Cc: Dave Chinner <dchin...@redhat.com> > Cc: Jan Kara <j...@suse.com> > Cc: "Kirill A. Shutemov" <kirill.sh

[PATCH v2] libnvdimm, e820: fix numa node for e820-type-12 pmem ranges

2015-11-12 Thread Dan Williams
Rather than punt on the numa node for these e820 ranges try to find a better answer with memory_add_physaddr_to_nid() when it is available. Cc: <stable@vger.kernel.org> Reported-by: Boaz Harrosh <b...@plexistor.com> Tested-by: Boaz Harrosh <b...@plexistor.com> Signed-of

Re: [PATCH] nvdimm: proper NID in e820_pmem_probe

2015-11-12 Thread Dan Williams
On Thu, Nov 12, 2015 at 5:58 AM, Boaz Harrosh <b...@plexistor.com> wrote: > On 11/12/2015 03:10 PM, Boaz Harrosh wrote: >> From: Dan Williams <dan.j.willi...@intel.com> >> >> [Boaz] >> What I see is that in the call to arch_add_memory() nid==0 regardless of

[PATCH v3 00/15] block, dax updates for 4.4

2015-11-01 Thread Dan Williams
Jens' tree. All but the last three have been out for review previously, and I am looking to submit them towards the back half of the merge window. --- Dan Williams (15): pmem, dax: clean up clear_pmem() dax: increase granularity of dax_clear_blocks() operations block, dax: fix

[PATCH v3 05/15] libnvdimm, pmem: fix size trim in pmem_direct_access()

2015-11-01 Thread Dan Williams
This masking prevents access to the end of the device via dax_do_io(), and is unnecessary as arch_add_memory() would have rejected an unaligned allocation. Cc: <stable@vger.kernel.org> Cc: Ross Zwisler <ross.zwis...@linux.intel.com> Signed-off-by: Dan Williams <dan.j.wil

Re: [PATCH v3 05/15] libnvdimm, pmem: fix size trim in pmem_direct_access()

2015-11-03 Thread Dan Williams
On Tue, Nov 3, 2015 at 11:32 AM, Ross Zwisler <ross.zwis...@linux.intel.com> wrote: > On Sun, Nov 01, 2015 at 11:30:10PM -0500, Dan Williams wrote: >> This masking prevents access to the end of the device via dax_do_io(), >> and is unnecessary as arch_add_memory() would have

[PATCH 0/8] dax fixes / cleanups: pmd vs thp, lifetime, and locking

2015-11-17 Thread Dan Williams
Changes since last posting [1]: 1/ Further cleanups to dax_clear_blocks(): Dropped increments of 'addr' since we call bdev_direct_access() before the next use, and dropped the BUG_ON for sector unaligned return values from bdev_direct_access(). 2/ In [PATCH 8/8] introduce blk_dax_ctl to

[PATCH 4/8] mm, dax: truncate dax mappings at bdev or fs shutdown

2015-11-17 Thread Dan Williams
Matthew Wilcox <wi...@linux.intel.com> Cc: Ross Zwisler <ross.zwis...@linux.intel.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- fs/inode.c| 27 +++ mm/truncate.c | 13 +++-- 2 files changed, 38 insertions(+), 2 deletions(-)

[PATCH 2/8] dax: disable pmd mappings

2015-11-17 Thread Dan Williams
: Kirill A. Shutemov <kirill.shute...@linux.intel.com> Reported-by: Ross Zwisler <ross.zwis...@linux.intel.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- fs/Kconfig |6 ++ fs/dax.c |4 2 files changed, 10 insertions(+) diff --git a/fs/Kconfig b/fs/Kconfig inde

[PATCH 3/8] mm, dax: fix DAX deadlocks (COW fault)

2015-11-17 Thread Dan Williams
c: Matthew Wilcox <matthew.r.wil...@intel.com> Acked-by: Ross Zwisler <ross.zwis...@linux.intel.com> Signed-off-by: Yigal Korman <yi...@plexistor.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- mm/memory.c |8 1 file changed, 4 insertions(+

[PATCH 1/8] ext2, ext4: warn when mounting with dax enabled

2015-11-17 Thread Dan Williams
hinner <da...@fromorbit.com> Acked-by: Jan Kara <j...@suse.com> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- fs/ext2/super.c |2 ++ fs/ext4/super.c |6 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/fs/ext2/super.c b/fs/ext2/super.c index 3a7

Re: FAILED: patch "[PATCH] block: protect rw_page against device teardown" failed to apply to 4.3-stable tree

2015-12-11 Thread Dan Williams
On Fri, Dec 11, 2015 at 9:10 AM, wrote: > > The patch below does not apply to the 4.3-stable tree. > If someone wants it applied there, or to any other stable or longterm > tree, then please email the backport, including the original git commit > id to

Re: [for-4.4-rc6 PATCH] scatterlist: fix sg_phys() masking

2015-12-15 Thread Dan Williams
On Tue, Dec 15, 2015 at 2:35 AM, Joerg Roedel <j...@8bytes.org> wrote: > On Mon, Dec 14, 2015 at 03:17:39PM -0800, Dan Williams wrote: >> commit db0fa0cb0157 "scatterlist: use sg_phys()" did replacements of the >> form: >> >> phys_addr_t phys = page_t

[for-4.4-rc6 PATCH] scatterlist: fix sg_phys() masking

2015-12-14 Thread Dan Williams
kernel.org> Cc: Jens Axboe <ax...@fb.com> Cc: Joerg Roedel <j...@8bytes.org> Cc: Christoph Hellwig <h...@lst.de> Cc: Russell King <li...@arm.linux.org.uk> Cc: David Woodhouse <dw...@infradead.org> Cc: Andrew Morton <a...@linux-foundation.org> Reported-by: Vita

[PATCH] libnvdimm: fix namespace object confusion in is_uuid_busy()

2016-01-05 Thread Dan Williams
: <stable@vger.kernel.org> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- drivers/nvdimm/namespace_devs.c | 53 + drivers/nvdimm/region_devs.c| 56 --- 2 files changed, 53 insertions(+), 56 deleti

Re: [PATCH 4/8] mm, dax: truncate dax mappings at bdev or fs shutdown

2015-11-20 Thread Dan Williams
On Thu, Nov 19, 2015 at 8:25 PM, Dan Williams <dan.j.willi...@intel.com> wrote: > On Thu, Nov 19, 2015 at 8:06 PM, Dave Chinner <da...@fromorbit.com> wrote: [..] > What would be the recommended interface to tell XFS to sync if it can, > but give up quickly if it hits an er

[PATCH] block: protect rw_page against device teardown

2015-11-19 Thread Dan Williams
/0xf0 [] handle_mm_fault+0x11bd/0x1b50 Cc: <stable@vger.kernel.org> Cc: Jens Axboe <ax...@fb.com> Cc: Matthew Wilcox <wi...@linux.intel.com> Cc: Alexander Viro <v...@zeniv.linux.org.uk> Signed-off-by: Dan Williams <dan.j.willi...@intel.com> --- fs/block_dev.c |

Re: [PATCH 4/8] mm, dax: truncate dax mappings at bdev or fs shutdown

2015-11-19 Thread Dan Williams
On Thu, Nov 19, 2015 at 8:06 PM, Dave Chinner wrote: > On Fri, Nov 20, 2015 at 12:05:11AM +, Williams, Dan J wrote: >> On Fri, 2015-11-20 at 10:17 +1100, Dave Chinner wrote: >> > Actually, I think we need to trigger a filesystem shutdown before >> > doing anything else

Re: [PATCH 4/8] mm, dax: truncate dax mappings at bdev or fs shutdown

2015-11-19 Thread Dan Williams
On Thu, Nov 19, 2015 at 4:55 AM, Jan Kara <j...@suse.cz> wrote: >> Subject: mm, dax: unmap dax mappings at bdev or fs shutdown >> From: Dan Williams <dan.j.willi...@intel.com> >> >> Currently dax mappings leak past / survive block_device shutdown. Whi