Re: [Standards] Off-by-one error in XEP-372 "References"

2020-12-07 Thread JC Brand
Thanks everyone for the feedback. I've made a PR here: https://github.com/xsf/xeps/pull/1018 The proposed change is the have the begin index inclusive and the end index exclusive, similarly to how Converse and Xabber do it currently. This is known as the Dijkstra convention, and I presume

Re: [Standards] Off-by-one error in XEP-372 "References"

2020-12-05 Thread Sam Whited
Oh yes, of course. I see what you're saying now. —Sam On Sat, Dec 5, 2020, at 01:24, Andrew Nenakhov wrote: > сб, 5 дек. 2020 г. в 05:12, Sam Whited : > > > > > > > > On Fri, Dec 4, 2020, at 23:34, Andrew Nenakhov wrote: > > > 4. Start = first character (inclusive) and length = length of a > > >

Re: [Standards] Off-by-one error in XEP-372 "References"

2020-12-04 Thread Andrew Nenakhov
сб, 5 дек. 2020 г. в 05:12, Sam Whited : > > > > On Fri, Dec 4, 2020, at 23:34, Andrew Nenakhov wrote: > > 4. Start = first character (inclusive) and length = length of a > >substring. > > This is the same as "1. Start = first character (inclusive), end = last > character (exclusive);" No.

Re: [Standards] Off-by-one error in XEP-372 "References"

2020-12-04 Thread Sam Whited
On Fri, Dec 4, 2020, at 23:34, Andrew Nenakhov wrote: > 4. Start = first character (inclusive) and length = length of a >substring. This is the same as "1. Start = first character (inclusive), end = last character (exclusive);" —Sam ___ Standards

Re: [Standards] Off-by-one error in XEP-372 "References"

2020-12-04 Thread Andrew Nenakhov
There is actually a fourth sensible option: 4. Start = first character (inclusive) and length = length of a substring. Just saying. It could be easier to implement for some people. пт, 4 дек. 2020 г. в 19:21, Tedd Sterr : > > "How to specify character ranges" is a problem that keeps appearing -

Re: [Standards] Off-by-one error in XEP-372 "References"

2020-12-04 Thread Tedd Sterr
"How to specify character ranges" is a problem that keeps appearing - can we resolve this once and for all, and then ensure we're consistent with that in all XEPs? There are only three sensible options: 1. Start = first character (inclusive), end = last character (exclusive); 2. Start = first

Re: [Standards] Off-by-one error in XEP-372 "References"

2020-12-04 Thread Florian Schmaus
On 12/4/20 1:31 PM, JC Brand wrote: Hey folks In XEP-0372 in section 3.1, there is the following text: An end attribute is similarly  used for the index of the last character of the reference However, in the example in 3.2, the "end" attribute is set to 78, which is the index of the space

Re: [Standards] Off-by-one error in XEP-372 "References"

2020-12-04 Thread Andrew Nenakhov
Well most participants of the previous discussion on this list were strongly against i+0 approach which we did at first, so since we didn't really hold any strong position on this, we just switched to i+1. The one advantage of this approach is that you can derive the length of the string directly

Re: [Standards] Off-by-one error in XEP-372 "References"

2020-12-04 Thread Severino Ferrer de la Peñita
Hi, I already discussed this with the author, you can read more about it on the following logs: https://logs.xmpp.org/jdev/2020-10-06?p=h#2020-10-06-f8688aaa95f97e76 I honestly don't believe `i+1` is correct. Could you please share some of that feedback, Andrew? Kind regards, Seve

Re: [Standards] Off-by-one error in XEP-372 "References"

2020-12-04 Thread Andrew Nenakhov
We're currently use it in all our clients, extensively. We finally settled on +1 offset because of feedback. That said, we use our own namespace because we can and because XSF moves XMPP in the wrong direction. :-D пт, 4 дек. 2020 г. в 17:33, JC Brand : > > Hey folks > > In XEP-0372 in section

[Standards] Off-by-one error in XEP-372 "References"

2020-12-04 Thread JC Brand
Hey folks In XEP-0372 in section 3.1, there is the following text: An end attribute is similarly used for the index of the last character of the reference However, in the example in 3.2, the "end" attribute is set to 78, which is the index of the space after the nickname "Juliet". The