Re: [PATCH v5] Print absolute paths in printpathn when -yy is used

2014-08-24 Thread Zubin Mithra
> @@ -1772,10 +1772,10 @@ sys_renameat(struct tcb *tcp) > { > if (entering(tcp)) { > print_dirfd(tcp, tcp->u_arg[0]); > - printpath(tcp, tcp->u_arg[1]); > + printpathat(tcp, tcp->u_arg[0], tcp->u_arg[1]); > tprints(", "); > pr

Re: [PATCH v5] Print absolute paths in printpathn when -yy is used

2014-08-24 Thread Zubin Mithra
Hi Dmitry, Please find below a diff of the changes for having `renameat` decode paths using oldfd and newfd. Other *at syscalls could be modified similarly. Does this look good? diff --git a/defs.h b/defs.h index 4aedee3..97a0c08 100644 --- a/defs.h +++ b/defs.h @@ -679,7 +679,9 @@ extern void

Re: [PATCH v5] Print ip and port associated with descriptor with -yy

2014-08-24 Thread Zubin Mithra
Hi Dmitry, On 21-Aug-2014, at 4:27, Dmitry V. Levin wrote: > On Thu, Aug 21, 2014 at 02:53:46AM +0400, Dmitry V. Levin wrote: >> On Mon, Aug 11, 2014 at 02:21:01PM +0530, [email protected] wrote: > [...] >> if (!inet_ntop(diag_msg->idiag_family, diag_msg->id.idiag_dst, >>

Re: [PATCH v5] Print ip and port associated with descriptor with -yy

2014-08-24 Thread Zubin Mithra
Hi Dmitry, > Actually, it is quite linux specific: SOCK_DIAG_BY_FAMILY needs tcp_diag > kernel module to handle IPPROTO_TCP, and udp_diag - for IPPROTO_UDP > sockets. I’m not sure I understand the problem here — could you tell me which kernel version you had used so that I could try compiling th

Re: [PATCH v5] Print ip and port associated with descriptor with -yy

2014-08-24 Thread Zubin Mithra
On Thu, Aug 21, 2014 at 02:53:46AM +0400, Dmitry V. Levin wrote: > On Mon, Aug 11, 2014 at 02:21:01PM +0530, [email protected] wrote: [...] > if (!inet_ntop(diag_msg->idiag_family, diag_msg->id.idiag_dst, > remote_addr_buf, size) || !remote_addr_buf[0]) >