Re: Patch: Fix libunwind segfault when -p is passed before -k

2016-12-12 Thread Mike Frysinger
On 08 Dec 2016 10:00, Sean Stangl wrote: > +#ifdef USE_LIBUNWIND > +static void > +late_unwind_tcb_init() this needs a "(void)" in the def -mike signature.asc Description: Digital signature -- Check out the vibrant tech

Re: puzzle of ioctl decode in file_ioctl.c and userfaultfd.c

2016-12-12 Thread Dmitry V. Levin
On Mon, Dec 12, 2016 at 10:39:43AM +, Dr. David Alan Gilbert wrote: > * jingpiao chen (chenjingp...@gmail.com) wrote: > > Version:4.14-ab28d7f1e5ab9b51f5708741bd13f92e768123d4 > > > > 2.userfaultfd.c:126 > > > > 126 case UFFDIO_UNREGISTER: > > 127 case UFFDIO_WAKE: { > > 128

Re: Patch: Fix libunwind segfault when -p is passed before -k

2016-12-12 Thread Dmitry V. Levin
Hi, On Thu, Dec 08, 2016 at 10:00:59AM -1000, Sean Stangl wrote: > There is a segfault if strace is called as `strace -p 2260 -k`. > > The -k flag sets a global bool stack_trace_enabled. But -p already consults > stack_trace_enabled during tcb initialization. So if -p is passed first, > the

Re: puzzle of ioctl decode in file_ioctl.c and userfaultfd.c

2016-12-12 Thread Dr. David Alan Gilbert
* jingpiao chen (chenjingp...@gmail.com) wrote: > Version:4.14-ab28d7f1e5ab9b51f5708741bd13f92e768123d4 > > 2.userfaultfd.c:126 > > 126 case UFFDIO_UNREGISTER: > 127 case UFFDIO_WAKE: { > 128 struct uffdio_range ura; > 129 tprints(", "); > 130