Re: [PATCH v6 9/9] Add stacktrace filter action

2017-08-06 Thread Eugene Syromiatnikov
On Wed, Aug 02, 2017 at 12:36:49PM +0700, Nikolay Marchuk wrote: > * defs.h (QUAL_STACKTRACE): Add new qual flag. > (stacktrace): Add macro for checking QUAL_STACKTRACE. > (stack_trace_enabled): Change description. > * filter_action.c (action_types): Declare and add new filter action type. > (updat

Re: [PATCH v6 7/9] Add path filter

2017-08-06 Thread Eugene Syromiatnikov
On Wed, Aug 02, 2017 at 12:36:47PM +0700, Nikolay Marchuk wrote: > * basic_filters.c: Add path filter functions. > * filter.c (filter_types): Add path filter entries. > --- > basic_filters.c | 31 +++ > filter.c| 2 ++ > 2 files changed, 33 insertions(+) > > d

Re: [PATCH v6 6/9] Implement new filtering language parsing

2017-08-06 Thread Eugene Syromiatnikov
On Wed, Aug 02, 2017 at 12:36:46PM +0700, Nikolay Marchuk wrote: > * filter.h (parse_filter_action, parse_filter_expression): Add new > declarations. > * filter_action.c (parse_filter_action): Add new parsing function. > (filtering_parse_function): Use filtering_parse instead of > parse_qualify_fi

Re: [PATCH v6 5/9] Optimize default filtering

2017-08-06 Thread Eugene Syromiatnikov
On Wed, Aug 02, 2017 at 12:36:45PM +0700, Nikolay Marchuk wrote: > * filter_action.c (default_flags, update_default_flags): Add default flags. > (add_action): Clear default flags. > (filter_syscall): Add default_flags to qual_flg. > (filtering_parse_finish): Init trace action for pathtracing. Don't

Re: [PATCH v6 4/9] Improve fd filtering

2017-08-06 Thread Eugene Syromiatnikov
On Wed, Aug 02, 2017 at 12:36:44PM +0700, Nikolay Marchuk wrote: > * pathtrace.c (match_fd_common, pathtrace_match_set): Move fd matching to > separate function. > * filter.h (match_fd_common): Add new declaration. > * basic_filters.c (run_fd_filter): Use match_fd_common for fd filter. > --- > bas

Re: [PATCH v6 3/9] Introduce new filtering architecture

2017-08-06 Thread Eugene Syromiatnikov
On Wed, Aug 02, 2017 at 12:36:43PM +0700, Nikolay Marchuk wrote: > This change introduces new filtering architecture primitives: filter, > filter_action and bool_expression. Filtering is now done after decoding of > syscall and tcp->qual_flg stores filtering results. > > * basic_actions.c: New fil

Re: [PATCH v6 2/9] tests: Refactor syscall syntax testing

2017-08-06 Thread Dmitry V. Levin
On Wed, Aug 02, 2017 at 12:36:42PM +0700, Nikolay Marchuk wrote: > * tests/syntax.sh: New file. > * filtering_syscall-syntax.test: Likewise. > * tests/qual_fault-syntax.test: Move syscall set syntax testing to > filtering_syscall-syntax.test. > * tests/qual_inject-syntax.test: Likewise. > * tests/

Re: [PATCH v6 1/9] Split qualify.c into basic_filters.c and filter_qualify.c

2017-08-06 Thread Dmitry V. Levin
On Wed, Aug 02, 2017 at 12:36:41PM +0700, Nikolay Marchuk wrote: > * basic_filters.c: New file, part of qualify.c. > * filter_qualify.c: Likewise. > * filter.h: New file. > * qualify.c: Remove. > * Makefile.am (strace_SOURCES): Add new files, remove qualify.c. OK, merged with minor changes to mini

Re: [PATCH v2] pathtrace: Fix missing syscalls

2017-08-06 Thread Dmitry V. Levin
On Sun, Aug 06, 2017 at 07:22:06PM +0700, Nikolay Marchuk wrote: > * pathtrace.c (pathtrace_match_set): Fix symlink decoding, disable pathtracing > for inotify_init. Applied, thanks. -- ldv signature.asc Description: PGP signature --

Re: [PATCH RESEND 1/8] netlink: call get_fd_nl_family before decode nlmsghdr

2017-08-06 Thread Dmitry V. Levin
On Sun, Aug 06, 2017 at 07:52:17AM +0800, JingPiao Chen wrote: > On Sun, Aug 06, 2017 at 02:10:16AM +0300, Dmitry V. Levin wrote: > > On Tue, Aug 01, 2017 at 07:48:41AM +0800, JingPiao Chen wrote: > > > Prepare for NETLINK_KOBJECT_UEVENT decode. The messages > > > of NETLINK_KOBJECT_UEVENT do not c

Initial merge of filtering/lua/asinfo GSoC 2017 projects

2017-08-06 Thread Eugene Syromiatnikov
Hello. As GSoC 2017 nearing its completion, I decided that it's time to try to look at the merged version of the code. You can have a look at the results of my attempt at [1]. Some notes: * As expected, most conflicts are between Victor's and Nikolay's work. Edgar's part is applying without a

[PATCH v2] pathtrace: Fix missing syscalls

2017-08-06 Thread Nikolay Marchuk
* pathtrace.c (pathtrace_match_set): Fix symlink decoding, disable pathtracing for inotify_init. --- pathtrace.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pathtrace.c b/pathtrace.c index 26a52fec..f0b85513 100644 --- a/pathtrace.c +++ b/pathtrace.c @@ -200,6 +200,7 @@ pathtrace_match_s

Re: [PATCH] pathtrace: Fix missing syscalls

2017-08-06 Thread Dmitry V. Levin
On Sat, Aug 05, 2017 at 12:27:52PM +0700, Nikolay Marchuk wrote: > * pathtrace.c (pathtrace_match_set): Fix symlink decoding, disable pathtracing > for inotify_init. > --- > pathtrace.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/pathtrace.c b/pathtrace.c > index 26a52fe..b68d2f7 1