Re: [PATCH] Fix stat decoding for LP64 bionic.

2014-03-12 Thread enh
64__) +/* Bionic's "libc" struct stat and struct stat64 are identical. + * LP64 bionic doesn't have a "kernel" stat64, so for LP64 we need to use the + * kernel stat. + */ #define stat64 stat -#endif /* AARCH64 */ +#endif /* defined(__BIONIC__) && de

Re: [PATCH] Fix stat decoding for LP64 bionic.

2014-03-12 Thread Dmitry V. Levin
On Wed, Mar 12, 2014 at 01:44:06PM -0700, enh wrote: > On Wed, Mar 12, 2014 at 1:36 PM, Dmitry V. Levin wrote: > > On Wed, Mar 12, 2014 at 10:41:42AM -0700, enh wrote: > > [...] > >> In patch fb642bb6d63f7ffe2228bf48a6008bc8f56f67ff I fixed aarch64 but broke > >> x86_64. > > > > No code added unde

Re: [PATCH] Fix stat decoding for LP64 bionic.

2014-03-12 Thread enh
On Wed, Mar 12, 2014 at 1:36 PM, Dmitry V. Levin wrote: > On Wed, Mar 12, 2014 at 10:41:42AM -0700, enh wrote: > [...] >> In patch fb642bb6d63f7ffe2228bf48a6008bc8f56f67ff I fixed aarch64 but broke >> x86_64. > > No code added under #ifdef AARCH64 can ever break x86_64. true. the full story is th

Re: [PATCH] Fix stat decoding for LP64 bionic.

2014-03-12 Thread Dmitry V. Levin
On Wed, Mar 12, 2014 at 10:41:42AM -0700, enh wrote: [...] > In patch fb642bb6d63f7ffe2228bf48a6008bc8f56f67ff I fixed aarch64 but broke > x86_64. No code added under #ifdef AARCH64 can ever break x86_64. > The workaround needed to be applied to all LP64 architectures, not > just aarch64. This pa

[PATCH] Fix stat decoding for LP64 bionic.

2014-03-12 Thread enh
>From 29a8e0373319d05c4bd300e98a31442fcb2beff3 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Wed, 12 Mar 2014 10:31:04 -0700 Subject: [PATCH] Fix stat decoding for LP64 bionic. In patch fb642bb6d63f7ffe2228bf48a6008bc8f56f67ff I fixed aarch64 but broke x86_64. The workaround needed to