Re: [PATCH] more robustness against ptrace errors

2009-02-24 Thread Denys Vlasenko
On Tue, 2009-02-24 at 16:36 +0300, Dmitry V. Levin wrote: > On Tue, Feb 24, 2009 at 02:08:47PM +0100, Denys Vlasenko wrote: > > On Tue, 2009-02-24 at 03:04 +0300, Dmitry V. Levin wrote: > > > On Fri, Feb 13, 2009 at 11:37:07AM +0100, Denys Vlasenko wrote: > > > [...] > > > > Please review. > > > >

Re: [PATCH] more robustness against ptrace errors

2009-02-24 Thread Dmitry V. Levin
On Tue, Feb 24, 2009 at 02:08:47PM +0100, Denys Vlasenko wrote: > On Tue, 2009-02-24 at 03:04 +0300, Dmitry V. Levin wrote: > > On Fri, Feb 13, 2009 at 11:37:07AM +0100, Denys Vlasenko wrote: > > [...] > > > Please review. > > > > Sorry for the long delay. > > The change looks good indeed. See my

Re: [PATCH] more robustness against ptrace errors

2009-02-24 Thread Denys Vlasenko
On Tue, 2009-02-24 at 03:04 +0300, Dmitry V. Levin wrote: > On Fri, Feb 13, 2009 at 11:37:07AM +0100, Denys Vlasenko wrote: > [...] > > Please review. > > Sorry for the long delay. > The change looks good indeed. See my comments below, though. > > > + if (do_ptrace(PTRACE_SET_SYSCALL, tcp, NUL

Re: [PATCH] more robustness against ptrace errors

2009-02-23 Thread Dmitry V. Levin
On Fri, Feb 13, 2009 at 11:37:07AM +0100, Denys Vlasenko wrote: [...] > Please review. Sorry for the long delay. The change looks good indeed. See my comments below, though. > + if (do_ptrace(PTRACE_SET_SYSCALL, tcp, NULL, new, "SET_SYSCALL") != 0) The "SET_SYSCALL" is deducable from PTRACE

Re: [PATCH] more robustness against ptrace errors

2009-02-23 Thread Denys Vlasenko
On Sat, 2009-02-14 at 02:05 +0300, Dmitry V. Levin wrote: > Hi, > > On Fri, Feb 13, 2009 at 11:37:07AM +0100, Denys Vlasenko wrote: > > this patch is not yet in cvs. > > > > It replaces many more bare ptrace calls with calls to wrappers > > which do proper error-checking and set tcp->ptrace_errno

Re: [PATCH] more robustness against ptrace errors

2009-02-13 Thread Dmitry V. Levin
Hi, On Fri, Feb 13, 2009 at 11:37:07AM +0100, Denys Vlasenko wrote: > this patch is not yet in cvs. > > It replaces many more bare ptrace calls with calls to wrappers > which do proper error-checking and set tcp->ptrace_errno. [...] > Please review. This is definitely a good change. I'll try to

[PATCH] more robustness against ptrace errors

2009-02-13 Thread Denys Vlasenko
Hi, this patch is not yet in cvs. It replaces many more bare ptrace calls with calls to wrappers which do proper error-checking and set tcp->ptrace_errno. Incidentally, it makes many callsites simpler: - ptrace(PTRACE_POKETEXT, tcp->pid, (char *) tcp->baddr, LOOP); - if (errno) { -