Re: [PATCH v3] USE_SEIZE: fix detaching from stopped processes

2013-06-20 Thread Dmitry V. Levin
On Thu, Jun 20, 2013 at 01:00:59PM +0400, Dmitry V. Levin wrote: > On Thu, Jun 20, 2013 at 02:29:26AM +0200, Denys Vlasenko wrote: > > On 06/19/2013 08:18 PM, Dmitry V. Levin wrote: > > > On Wed, Jun 19, 2013 at 08:17:13PM +0400, Dmitry V. Levin wrote: > > >> On Wed, Jun 19, 2013 at 03:52:43PM +020

Re: [PATCH v3] USE_SEIZE: fix detaching from stopped processes

2013-06-20 Thread Dmitry V. Levin
On Thu, Jun 20, 2013 at 02:29:26AM +0200, Denys Vlasenko wrote: > On 06/19/2013 08:18 PM, Dmitry V. Levin wrote: > > On Wed, Jun 19, 2013 at 08:17:13PM +0400, Dmitry V. Levin wrote: > >> On Wed, Jun 19, 2013 at 03:52:43PM +0200, Denys Vlasenko wrote: > >>> V3: split SEIZE/!SEIZE code paths to reduc

Re: [PATCH v3] USE_SEIZE: fix detaching from stopped processes

2013-06-19 Thread Denys Vlasenko
On 06/19/2013 08:18 PM, Dmitry V. Levin wrote: > On Wed, Jun 19, 2013 at 08:17:13PM +0400, Dmitry V. Levin wrote: >> On Wed, Jun 19, 2013 at 03:52:43PM +0200, Denys Vlasenko wrote: >>> V3: split SEIZE/!SEIZE code paths to reduce confusion. >> >> With your tests/detach* enhancements, I see persisten

Re: [PATCH v3] USE_SEIZE: fix detaching from stopped processes

2013-06-19 Thread Dmitry V. Levin
On Wed, Jun 19, 2013 at 08:17:13PM +0400, Dmitry V. Levin wrote: > On Wed, Jun 19, 2013 at 03:52:43PM +0200, Denys Vlasenko wrote: > > V3: split SEIZE/!SEIZE code paths to reduce confusion. > > With your tests/detach* enhancements, I see persistent detach-stopped > failures on old (!use_seize) ker

Re: [PATCH v3] USE_SEIZE: fix detaching from stopped processes

2013-06-19 Thread Dmitry V. Levin
On Wed, Jun 19, 2013 at 03:52:43PM +0200, Denys Vlasenko wrote: > V3: split SEIZE/!SEIZE code paths to reduce confusion. With your tests/detach* enhancements, I see persistent detach-stopped failures on old (!use_seize) kernels: $ cat detach-stopped.log FAIL: detach-stopped (exit: 1) ===

[PATCH v3] USE_SEIZE: fix detaching from stopped processes

2013-06-19 Thread Denys Vlasenko
V3: split SEIZE/!SEIZE code paths to reduce confusion. Extensively comment every possible case. Verified that all tests/detach* tests work in both SEIZE and !SEIZE cases. * strace.c (detach): If PTRACE_SEIZE API is in use, stop the tracee using PTRACE_INTERRUPT instead of sending it a SIGSTOP. In