Re: [PATCH v7] Implement decoding of statx syscall

2017-03-18 Thread Dmitry V. Levin
On Sat, Mar 18, 2017 at 01:10:33PM +0300, Victor Krapivensky wrote: > On Sat, Mar 18, 2017 at 04:00:50AM +0300, Dmitry V. Levin wrote: > > I suggest placing AT_STATX_SYNC_TYPE before AT_STATX_FORCE_SYNC > > so we could use printflags. > > I don't see any sense in that: > AT_STATX_{SYNC_AS_STAT,FOR

Re: [PATCH v7] Implement decoding of statx syscall

2017-03-18 Thread Victor Krapivensky
On Sat, Mar 18, 2017 at 04:00:50AM +0300, Dmitry V. Levin wrote: > I suggest placing AT_STATX_SYNC_TYPE before AT_STATX_FORCE_SYNC > so we could use printflags. I don't see any sense in that: AT_STATX_{SYNC_AS_STAT,FORCE_SYNC,DONT_SYNC} are mutually exclusive, and statx called with flags=AT_STATX_

Re: [PATCH v7] Implement decoding of statx syscall

2017-03-17 Thread Dmitry V. Levin
On Fri, Mar 17, 2017 at 10:58:35PM +0300, Victor Krapivensky wrote: > * linux/i386/syscallent.h [383]: Add statx entry. > * linux/x32/syscallent.h [332]: Likewise. > * linux/x86_64/syscallent.h [332]: Likewise. > * pathtrace.c (pathtrace_match): Handle SEN_statx. > * statx.c: New file. > * statx.h:

[PATCH v7] Implement decoding of statx syscall

2017-03-17 Thread Victor Krapivensky
* linux/i386/syscallent.h [383]: Add statx entry. * linux/x32/syscallent.h [332]: Likewise. * linux/x86_64/syscallent.h [332]: Likewise. * pathtrace.c (pathtrace_match): Handle SEN_statx. * statx.c: New file. * statx.h: Likewise. * Makefile.am (strace_SOURCES): Add them. * tests/.gitignore: Add sta