Re: Signed-off-by/Acked-by convention (was: Add more futex decoding)

2009-08-12 Thread Dmitry V. Levin
On Wed, Aug 12, 2009 at 01:43:34PM -0700, Roland McGrath wrote: [...] > > Although my recent commits include this line, strace project has no such > > written convention atm, so it's time to clear up, is there any objections > > wrt to this convention. > > I do not think it serves any purpose for

Re: Add more futex decoding

2009-08-12 Thread Roland McGrath
> There is a common practice for git-based projects to append a > Signed-off-by line to commit messages, so I suppose that they are > following this convention for a good reason. The Linux kernel has particular conventions for this, and it is the prototype git project. I don't think most projects

Re: Add more futex decoding

2009-08-12 Thread Dmitry V. Levin
On Wed, Aug 12, 2009 at 10:54:45AM -0700, Roland McGrath wrote: > > Looks OK. Please append a Signed-off-by line to the commit message. > > Why? We do not have any such convention in this project. If you want to > establish any particular conventions for commit messages, we can discuss it > her

Re: Add more futex decoding

2009-08-12 Thread Roland McGrath
> Looks OK. Please append a Signed-off-by line to the commit message. Why? We do not have any such convention in this project. If you want to establish any particular conventions for commit messages, we can discuss it here. Thanks, Roland -

Re: Add more futex decoding

2009-08-12 Thread Andreas Schwab
"Dmitry V. Levin" writes: > Looks OK. Please append a Signed-off-by line to the commit message. README-hacking does not mention that. Andreas. -- Andreas Schwab, sch...@redhat.com GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E "And now for something completely diffe

Re: Add more futex decoding

2009-08-12 Thread Dmitry V. Levin
On Tue, Aug 11, 2009 at 04:12:39PM +0200, Andreas Schwab wrote: > This patch fixes the decoding of futex to include the recent additions > to its interface. > > Andreas. > > Add more futex decoding. > * process.c (FUTEX_WAIT_REQUEUE_PI,

Re: Add more futex decoding

2009-08-12 Thread Roland McGrath
> I don't have write access. Well, you should! I assume there is some way you ask to join the project that makes the sourceforge robots ask me to approve you. -- Let Crystal Reports handle the reporting - Free Crystal Re

Re: Add more futex decoding

2009-08-12 Thread Andreas Schwab
Roland McGrath writes: > Looks good to me. Can you commit it? I don't have write access. Andreas. -- Andreas Schwab, sch...@redhat.com GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E "And now for something completely different." -

Re: Add more futex decoding

2009-08-11 Thread Roland McGrath
Looks good to me. Can you commit it? -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core ap

Add more futex decoding

2009-08-11 Thread Andreas Schwab
This patch fixes the decoding of futex to include the recent additions to its interface. Andreas. Add more futex decoding. * process.c (FUTEX_WAIT_REQUEUE_PI, FUTEX_CMP_REQUEUE_PI) (FUTEX_PRIVATE_FLAG, FUTEX_CLOCK_REALTIME): Define. (futexops): Add entries for