Re: Patch: Fix libunwind segfault when -p is passed before -k

2016-12-13 Thread Dmitry V. Levin
On Mon, Dec 12, 2016 at 01:53:29PM +0300, Dmitry V. Levin wrote: > On Thu, Dec 08, 2016 at 10:00:59AM -1000, Sean Stangl wrote: > > There is a segfault if strace is called as `strace -p 2260 -k`. > > > > The -k flag sets a global bool stack_trace_enabled. But -p already consults > >

Re: Patch: Fix libunwind segfault when -p is passed before -k

2016-12-12 Thread Mike Frysinger
On 08 Dec 2016 10:00, Sean Stangl wrote: > +#ifdef USE_LIBUNWIND > +static void > +late_unwind_tcb_init() this needs a "(void)" in the def -mike signature.asc Description: Digital signature -- Check out the vibrant tech

Re: Patch: Fix libunwind segfault when -p is passed before -k

2016-12-12 Thread Dmitry V. Levin
Hi, On Thu, Dec 08, 2016 at 10:00:59AM -1000, Sean Stangl wrote: > There is a segfault if strace is called as `strace -p 2260 -k`. > > The -k flag sets a global bool stack_trace_enabled. But -p already consults > stack_trace_enabled during tcb initialization. So if -p is passed first, > the

Patch: Fix libunwind segfault when -p is passed before -k

2016-12-11 Thread Sean Stangl
this issue by having -k ensure that the libunwind components are initialized. Best, Sean Stangl From 886185a13e5a800c17330f4acf226426dc74 Mon Sep 17 00:00:00 2001 From: Sean Stangl <ssta...@mozilla.com> Date: Thu, 8 Dec 2016 09:54:24 -1000 Subject: [PATCH] Fix libunwind segfault when -p is