Re: [PATCH] netlink: add a basic netlink socket diag parser

2017-06-13 Thread JingPiao Chen
On Tue, Jun 13, 2017 at 02:40:56AM +0300, Dmitry V. Levin wrote: > On Mon, Jul 11, 2016 at 01:52:27PM +, Fabien Siron wrote: > [...] > First of all, the change is too big. [...] > In cases like this an array of functions with the same signature would be > a better choice than a switch statemen

Re: [PATCH] netlink: add a basic netlink socket diag parser

2017-06-12 Thread Dmitry V. Levin
On Mon, Jul 11, 2016 at 01:52:27PM +, Fabien Siron wrote: > * Makefile.am (strace_SOURCES): Add netlink_sock_diag.c. > (EXTRA_DIST): Add linux/packet_diag.h and linux/smc_diag.h. > * defs.h (ethernet_protocols, inet_protocols) > (socktypes): New xlat prototype. > (decode_netlink_sock_diag): New