Re: Make strace correctly handle SIGTRAP produced by e.g.

2009-11-10 Thread Andreas Schwab
Which ones are missing? Andreas. -- Andreas Schwab, sch...@redhat.com GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E "And now for something completely different." -- Let Crystal Reports handle

Re: Make strace correctly handle SIGTRAP produced by e.g.

2009-11-09 Thread Roland McGrath
That doesn't even address all the issues I cited in the earlier patch. -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and fo

Re: Make strace correctly handle SIGTRAP produced by e.g.

2009-11-09 Thread Andreas Schwab
>From e406ae13301618cd4d020de826ae9c3eaa192bdf Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Tue, 13 Jan 2009 18:30:55 + Subject: [PATCH] Make strace correctly handle SIGTRAP produced by e.g. kill(2) and by trapping instruction. * strace.c (ptrace_stop_sig): Define. (detach): Use it in

Re: Make strace correctly handle SIGTRAP produced by e.g.

2009-11-04 Thread Denys Vlasenko
On Tue, 2009-11-03 at 13:03 -0800, Roland McGrath wrote: > > + int sigtrap80; /* What sig we consider to be ptrace stop */ > > This is a lousy name for the member. "syscall_stopsig" or something fits. > But I'm not really sure it is worthwhile to have per-tcb state for this at > all.

Re: Make strace correctly handle SIGTRAP produced by e.g.

2009-11-03 Thread Roland McGrath
> + int sigtrap80; /* What sig we consider to be ptrace stop */ This is a lousy name for the member. "syscall_stopsig" or something fits. But I'm not really sure it is worthwhile to have per-tcb state for this at all. If the ptrace features work they work on this kernel, period, tha

Re: Make strace correctly handle SIGTRAP produced by e.g.

2009-11-02 Thread Andreas Schwab
>From 15a8755d7a53dbd035b914b8fb0eeafe6ba9dcd2 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Mon, 22 Dec 2008 19:14:47 + Subject: [PATCH] Make strace correctly handle SIGTRAP produced by e.g. kill(2) and by trapping instruction. * defs.h: Add sigtrap80 field to struct tcb. * strace.c (

Re: Make strace correctly handle SIGTRAP produced by e.g.

2009-10-29 Thread Roland McGrath
> So what's wrong with the patch? Propose a current, tested patch with a posting and/or git branch to get review. -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you nee

Re: Make strace correctly handle SIGTRAP produced by e.g.

2009-10-29 Thread Andreas Schwab
So what's wrong with the patch? Andreas. -- Andreas Schwab, sch...@redhat.com GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E "And now for something completely different." -- Come build with us!

Re: Make strace correctly handle SIGTRAP produced by e.g.

2009-10-28 Thread Roland McGrath
> Since I have no idea what's wrong with the patch I cannot propose > anything. If you're not proposing anything, there is no patch. You own the issue now. If there is a patch you like, post it, explain it, and defend it. -

Re: Make strace correctly handle SIGTRAP produced by e.g.

2009-10-28 Thread Andreas Schwab
Roland McGrath writes: > Sorry, is there a current patch you are proposing? Since I have no idea what's wrong with the patch I cannot propose anything. Andreas. -- Andreas Schwab, sch...@redhat.com GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E "And now for something

Re: Make strace correctly handle SIGTRAP produced by e.g.

2009-10-27 Thread Roland McGrath
Sorry, is there a current patch you are proposing? I think you forwarded an old message from Denys. That never looked like sending a tested patch with explanation of why you are proposing it. Thanks, Roland -- Come build

Re: Make strace correctly handle SIGTRAP produced by e.g.

2009-10-27 Thread Andreas Schwab
Any news about that thread? Andreas. -- Andreas Schwab, sch...@redhat.com GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E "And now for something completely different." -- Come build with us! The

Re: Make strace correctly handle SIGTRAP produced by e.g.

2009-09-07 Thread Roland McGrath
> Two months ago I said that I'd like to see reintroduced one change (which > was lost with big revert commit) made by Denys: "Replace many more bare > ptrace calls with calls to wrappers which do proper error-checking and > set tcp->ptrace_errno." Unfortunately, I failed to allocate time required

Re: Make strace correctly handle SIGTRAP produced by e.g.

2009-09-07 Thread Dmitry V. Levin
On Mon, Sep 07, 2009 at 11:54:31AM -0700, Roland McGrath wrote: > It's again been weeks since I said "let's release it now" and nobody has > followed up on the release work. Let's do it already! Two months ago I said that I'd like to see reintroduced one change (which was lost with big revert com

Re: Make strace correctly handle SIGTRAP produced by e.g.

2009-09-07 Thread Roland McGrath
I think that has some robustness issues with the variety of kernels out there. Moreover, I think this is sufficiently touchy a change that we should not be doing it before making the 4.5.19 release with existing fixes. It's again been weeks since I said "let's release it now" and nobody has follo