On Mon, Oct 05, 2009 at 11:10:09PM +0200, Frederik Schüler wrote:
[...]
> hppa issues fixed and tested, patch attached.
[...]
> --- a/syscall.c
> +++ b/syscall.c
> @@ -2119,12 +2119,19 @@ syscall_enter(struct tcb *tcp)
> {
> int i;
>
> + long args[] = { PT_GR26-4*0, PT_GR26-4*1,
> + PT_GR26-4*2, PT_GR26-4*3,
> + PT_GR26-4*4, PT_GR26-4*5 };
> +
> + /* How many arguments does this syscall have? */
> if (tcp->scno >= 0 && tcp->scno < nsyscalls &&
> sysent[tcp->scno].nargs != -1)
> + /* Syscall is known, and number of arguments is known.
> */
> tcp->u_nargs = sysent[tcp->scno].nargs;
> else
> - tcp->u_nargs = MAX_ARGS;
> + /* Unknown syscall, assume maximum number of arguments.
> */
> + tcp->u_nargs = sizeof(args)/sizeof(args[0]);
> for (i = 0; i < tcp->u_nargs; i++) {
> - if (upeek(tcp, PT_GR26-4*i, &tcp->u_arg[i]) < 0)
> + if (upeek(tcp, args[i], &tcp->u_arg[i]) < 0)
> return -1;
> }
> }This hunk does not look correct. If MAX_ARGS should be lowered on HPPA from 32 to 6, let's change it in the defs.h file. -- ldv
pgp61T2BDppDd.pgp
Description: PGP signature
------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
