Re: improved SI_TIMER decoding

2014-03-10 Thread Mike Frysinger
On Tue 11 Mar 2014 05:50:04 Dmitry V. Levin wrote: > On Mon, Mar 10, 2014 at 09:21:19PM -0400, Mike Frysinger wrote: > > On Mon 10 Mar 2014 17:40:17 enh wrote: > > > i think we might be talking at cross purposes. the pid/uid stuff that > > > > > > isn't relevant for SI_TIMER isn't in sigval_t; it'

Re: improved SI_TIMER decoding

2014-03-10 Thread Dmitry V. Levin
On Mon, Mar 10, 2014 at 09:21:19PM -0400, Mike Frysinger wrote: > On Mon 10 Mar 2014 17:40:17 enh wrote: > > i think we might be talking at cross purposes. the pid/uid stuff that > > > isn't relevant for SI_TIMER isn't in sigval_t; it's in siginfo_t. i > > did factor out the sigval_t stuff. > > y

Re: improved SI_TIMER decoding

2014-03-10 Thread Mike Frysinger
On Mon 10 Mar 2014 17:40:17 enh wrote: please don't top post > i think we might be talking at cross purposes. the pid/uid stuff that > isn't relevant for SI_TIMER isn't in sigval_t; it's in siginfo_t. i > did factor out the sigval_t stuff. yes, you factored out sigval_t, but you also copied & pa

Re: improved SI_TIMER decoding

2014-03-10 Thread enh
i think we might be talking at cross purposes. the pid/uid stuff that isn't relevant for SI_TIMER isn't in sigval_t; it's in siginfo_t. i did factor out the sigval_t stuff. On Mon, Mar 10, 2014 at 5:37 PM, Mike Frysinger wrote: > On Mon 10 Mar 2014 17:08:11 enh wrote: >> On Mon, Mar 10, 2014 at 4

Re: improved SI_TIMER decoding

2014-03-10 Thread Mike Frysinger
On Mon 10 Mar 2014 17:08:11 enh wrote: > On Mon, Mar 10, 2014 at 4:52 PM, Mike Frysinger wrote: > > On Thu 06 Mar 2014 18:20:50 enh wrote: > >> #ifdef SI_FROMUSER > >> if (SI_FROMUSER(sip)) { > >> - tprintf(", si_pid=%lu, si_uid=%lu", > >> -

Re: improved SI_TIMER decoding

2014-03-10 Thread enh
On Mon, Mar 10, 2014 at 4:52 PM, Mike Frysinger wrote: > On Thu 06 Mar 2014 18:20:50 enh wrote: >> Decode siginfo_t more clearly for si_code SI_TIMER. >> >> The 'pid' is actually a POSIX timer id, and the 'uid' is actually the >> overrun. >> >> Also factor out the si_value dumping so it's the same

Re: improved SI_TIMER decoding

2014-03-10 Thread Mike Frysinger
On Thu 06 Mar 2014 18:20:50 enh wrote: > Decode siginfo_t more clearly for si_code SI_TIMER. > > The 'pid' is actually a POSIX timer id, and the 'uid' is actually the > overrun. > > Also factor out the si_value dumping so it's the same for every si_code. please use `git send-email` rather than a

improved SI_TIMER decoding

2014-03-06 Thread enh
Decode siginfo_t more clearly for si_code SI_TIMER. The 'pid' is actually a POSIX timer id, and the 'uid' is actually the overrun. Also factor out the si_value dumping so it's the same for every si_code. Signed-off-by: Elliott Hughes diff --git a/signal.c b/signal.c index ce8ec0a..69fea37 10064