Re: [PATCH] Try to use PTRACE_SETOPTIONS to handle non-ptrace SIGTRAP

2010-03-03 Thread Roland McGrath
Sorry for the delay in reviewing this. I think this is mostly good, but I do have a couple of concerns. +#ifdef USE_PTRACE_SETOPTIONS + /* Don't set TCB_WAITEXECVE when PTRACE_SETOPTIONS works. */ + if (use_ptrace_setoptions 0) + return 0; +#endif Given +# define

Re: [PATCH] Try to use PTRACE_SETOPTIONS to handle non-ptrace SIGTRAP

2010-03-03 Thread Andreas Schwab
* defs.h (TCB_PTRACE_OPTIONS) [LINUX PTRACE_SETOPTIONS]: Define. * process.c (internal_fork): Copy TCB_PTRACE_OPTIONS flag to child. * strace.c (set_ptrace_options, is_ptrace_stop) (is_post_execve_trap): Define. (proc_open): Use them. --- defs.h| 12 + process.c |3 ++ strace.c