Re: [PATCH] m68k: fix sigreturn decoding

2015-03-11 Thread Dmitry V. Levin
On Wed, Mar 11, 2015 at 03:10:34PM +0100, Andreas Schwab wrote: * sigreturn.c (sys_sigreturn) [M68K]: Fetch the words of the signal mask from the proper place. --- sigreturn.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/sigreturn.c b/sigreturn.c

Re: [PATCH] tests/ipc_sem: don't match address of sem buffer

2015-03-11 Thread Dmitry V. Levin
On Wed, Mar 11, 2015 at 01:07:15PM +0100, Andreas Schwab wrote: On architectures where the semctl call is implemented by the ipc syscall the glibc wrapper passes a pointer to a local variable, so the value of the fourth argument is unknown. Wouldn't it be better to fix the parser, e.g. ---

Re: [PATCH] Fix decoding of mmap2 for arm

2015-03-11 Thread Dmitry V. Levin
On Tue, Mar 10, 2015 at 10:53:35AM +0100, Andreas Schwab wrote: Dmitry V. Levin l...@altlinux.org writes: Is CONFIG_ARM64_64K_PAGES necessary to see the difference? Yes and no. Currently, CONFIG_ARM64_64K_PAGES forbids CONFIG_COMPAT, so you won't be able to observe the bug, but if you

Re: [PATCH] Fix crash in ipc_sem test

2015-03-11 Thread Dmitry V. Levin
On Wed, Mar 11, 2015 at 01:08:58PM +0100, Andreas Schwab wrote: Properly use union semun as argument of semctl. Indeed, on some architectures, union of a pointer is not the same as a pointer. --- a/tests/ipc_sem.c +++ b/tests/ipc_sem.c @@ -2,10 +2,19 @@ #include errno.h #include

Re: [PATCH] m68k: fix sigreturn decoding

2015-03-11 Thread Mike Frysinger
On 11 Mar 2015 15:10, Andreas Schwab wrote: + addr -= sizeof (mask) - sizeof(long); + if (umoven(tcp, addr, sizeof (mask) - sizeof(long), (char *) mask[1]) 0) should be consistent with sizeof (foo) vs sizeof(foo) (should use the latter) -mike signature.asc

Re: GSoC 2015

2015-03-11 Thread Prateek Gupta
Thanks for the replies. I am sorry that I could not reply any sooner because I was out of station. I have started working on the proposal and will soon share an initial draft for insight. In the meantime I have some queries which I will convey to you soon. Regards, Prateek On Thu, Mar 5, 2015 at

[PATCH] m68k: define HAVE_SA_RESTORER

2015-03-11 Thread Andreas Schwab
On m68k the kernel sigaction structure has the sa_restorer member for historical reasons. * signal.c (HAVE_SA_RESTORER): Define for M68K. --- signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/signal.c b/signal.c index 710fb19..867e156 100644 --- a/signal.c +++

[PATCH] tests/ipc_sem: don't match address of sem buffer

2015-03-11 Thread Andreas Schwab
On architectures where the semctl call is implemented by the ipc syscall the glibc wrapper passes a pointer to a local variable, so the value of the fourth argument is unknown. * ipc_sem.c (main): Don't try to match address of sem buffer. --- tests/ipc_sem.c | 8 1 file changed, 4

[PATCH] Fix crash in ipc_sem test

2015-03-11 Thread Andreas Schwab
Properly use union semun as argument of semctl. * ipc_sem.c (main): Properly use union semun as argument of semctl. Don't handle EFAULT specially. * ipc_sem.test: Revert last change. --- tests/ipc_sem.c| 24 tests/ipc_sem.test | 19 --- 2 files