[PATCH 1/3] util: change type of struct xlat.val to uint64_t

2016-04-28 Thread Jeff Mahoney
Some ioctls have flags fields that are 64-bit. A 32-bit val means these flags will never be matched or printed. * util.c: (xlookup) Use uint64_t for val. (xlat_search) Likewise. (printxvals) Likewise. (addflags64) New function. (printflags64) New function. (sprintflags64) New function

[PATCH 0/3 v2] Add btrfs ioctl support

2016-04-28 Thread Jeff Mahoney
Hi all - This short series adds support for the btrfs ioctls. Its structures make heavy use of __u64 so rather than cast every single member, I added new PRI* macros to print them properly. It also uses 64-bit flags and defines values that are larger than can be described by a 32-bit variable, s

[PATCH 2/3] defs: define PRI__[uxs]64 to print __[su]64 values

2016-04-28 Thread Jeff Mahoney
Rather than cast every __u64 or __s64 before printing, we can define printing helpers for those types directly. * defs.h: define PRI__[uxs]64. --- defs.h | 20 1 file changed, 20 insertions(+) diff --git a/defs.h b/defs.h index ead12dd..cc2a0d4 100644 --- a/defs.h +++ b/defs

[PATCH 3/3] Add btrfs ioctl support.

2016-04-28 Thread Jeff Mahoney
* btrfs.c: New file. * file_ioctl.c: New file. * Makefile.am (strace_SOURCES): Add it. * defs.h [LINUX] (btrfs_ioctl): New function. * ioctls.c (ioctl_decode) [LINUX]: Use it to decode BTRFS_* ioctls. * configure.ac: Add check for struct btrfs_ioctl_feature_flags. Add check for struct btrfs_ioctl

Re: [PATCH 0/3 v2] Add btrfs ioctl support

2016-04-28 Thread Jeff Mahoney
On 4/28/16 11:26 AM, Jeff Mahoney wrote: > Hi all - Bad $SUBJECT. This is v3. -Jeff > This short series adds support for the btrfs ioctls. Its structures > make heavy use of __u64 so rather than cast every single member, I added > new PRI* macros to print them properly. It also uses 64-bit fl

Re: [PATCH 2/3] defs: define PRI__[uxs]64 to print __[su]64 values

2016-04-28 Thread Dmitry V. Levin
On Thu, Apr 28, 2016 at 11:27:00AM -0400, Jeff Mahoney wrote: > Rather than cast every __u64 or __s64 before printing, we can > define printing helpers for those types directly. > > * defs.h: define PRI__[uxs]64. This commit is already merged. I changed PRI__s64 to PRI__d64 in a follow-up commit

Re: [PATCH 1/3] util: change type of struct xlat.val to uint64_t

2016-04-28 Thread Dmitry V. Levin
On Thu, Apr 28, 2016 at 11:26:59AM -0400, Jeff Mahoney wrote: > Some ioctls have flags fields that are 64-bit. A 32-bit val means > these flags will never be matched or printed. > > * util.c: > (xlookup) Use uint64_t for val. > (xlat_search) Likewise. > (printxvals) Likewise. > (addflags6

Re: [PATCH 3/3] Add btrfs ioctl support.

2016-04-28 Thread Dmitry V. Levin
On Thu, Apr 28, 2016 at 11:27:01AM -0400, Jeff Mahoney wrote: > * btrfs.c: New file. > * file_ioctl.c: New file. First, you've forgotten to include file_ioctl.c into the patch. > * Makefile.am (strace_SOURCES): Add it. > * defs.h [LINUX] (btrfs_ioctl): New function. > * ioctls.c (ioctl_decode) [L

Re: [RFC v2] Decode UFFDIO_* ioctls

2016-04-28 Thread Dmitry V. Levin
On Sat, Apr 23, 2016 at 05:39:42AM +0300, Dmitry V. Levin wrote: > On Fri, Apr 22, 2016 at 07:02:08PM +0100, Dr. David Alan Gilbert (git) wrote: [...] > >don't use my decode_flags64 - I guess I should be using printflags > >but printflags uses struct xlat and they're both unsigned int >