Hello.
I've stumbled upon a subtle bug in timerfd_settime parser - it retrieves
old_value argument on entering and not on exiting. Turns out it hasn't
been noticed by timerfd_xettime test since it fills old_value argument
buffer with exactly the same values as returned by the call (more precisely,
It is needed in order to differentiate it from the value returned by the
call. As a consequence, it enables revealing possible bugs in syscall
parsers, for example, when the value read on syscall entering and not on
syscall exiting (as it is the case with timerfd_settime parser).
* tests/timer_xet
This is done similar to timer_settime syscall parser.
* time.c (SYS_FUNC(timerfd_settime)): retrieve old_value argument on
exiting and not on entering. Return 0 instead of RVAL_DECODED
(since call hasn't been decoded in full on entering).
---
time.c | 20 +++-
1 file changed
On Fri, Aug 19, 2016 at 09:35:23PM +0100, Richard W.M. Jones wrote:
> (Adding Palmer who wrote the original patch to CC)
>
> On Fri, Aug 19, 2016 at 05:05:32PM +0300, Dmitry V. Levin wrote:
> > On Fri, Aug 19, 2016 at 02:16:40PM +0100, Richard W.M. Jones wrote:
> > > v2 -> v3:
> > >
> > > - Remo
On Sat, Aug 20, 2016 at 05:02:55PM +0300, Eugene Syromyatnikov wrote:
> This change prevents scattering of ll-related hacks and simplifies
> pread/pwrite
> syscalls parsers' logic a bit.
Thanks, merged to master.
--
ldv
pgpelXu1mWSGj.pgp
Description: PGP signature
---
Hi,
On Mon, Aug 22, 2016 at 11:47:02AM +0300, Eugene Syromyatnikov wrote:
> Hello.
>
> I've stumbled upon a subtle bug in timerfd_settime parser - it retrieves
> old_value argument on entering and not on exiting. Turns out it hasn't
> been noticed by timerfd_xettime test since it fills old_value
On Mon, 22 Aug 2016 03:02:02 PDT (-0700), l...@altlinux.org wrote:
> On Fri, Aug 19, 2016 at 09:35:23PM +0100, Richard W.M. Jones wrote:
>> (Adding Palmer who wrote the original patch to CC)
>>
>> On Fri, Aug 19, 2016 at 05:05:32PM +0300, Dmitry V. Levin wrote:
>> > On Fri, Aug 19, 2016 at 02:16:40