Re: [PATCH v2 01/25] netlink: add a basic rtnetlink parser of addr messages

2017-08-13 Thread Dmitry V. Levin
On Sun, Aug 13, 2017 at 10:22:19AM +0800, JingPiao Chen wrote: > * rtnl_addr.c: New file. > * Makefile.am (strace_SOURCES): Add it. > * configure.ac (AC_CHECK_HEADERS): Add linux/if_addr.h. > * netlink_route.h (decode_ifaddrmsg): New prototype. > * netlink_route.c (route_decoders): Add RTM_DELADDR,

Re: [PATCH 16/26] netlink: add a basic rtnetlink parser of addrlabel messages

2017-08-13 Thread Dmitry V. Levin
On Thu, Aug 10, 2017 at 09:08:32AM +0800, JingPiao Chen wrote: > * rtnl_addrlabel.c: New file. > * Makefile.am (strace_SOURCES): Add it. > * netlink_route.h (decode_ifaddrlblmsg): New prototype. > * configure.ac (AC_CHECK_HEADERS): Add linux/if_addrlabel.h. > (AC_CHECK_TYPES): Check for struct ifad

Re: [PATCH 20/26] netlink: add a basic rtnetlink parser of netconf messages

2017-08-13 Thread Dmitry V. Levin
On Thu, Aug 10, 2017 at 09:10:17AM +0800, JingPiao Chen wrote: > * rtnl_netconf.c: New file. > * Makefile.am (strace_SOURCES): Add it. > * netlink_route.h (decode_netconfmsg): New prototype. > * configure.ac (AC_CHECK_HEADERS): Add linux/netconf.h. > (AC_CHECK_TYPES): Check for struct netconfmsg in

Re: [PATCH v7 3/8] Improve fd filtering

2017-08-13 Thread Eugene Syromiatnikov
On Fri, Aug 11, 2017 at 05:43:48PM +0700, Nikolay Marchuk wrote: > * pathtrace.c (match_fd_common, pathtrace_match_set): Move fd matching to > separate function. > * filter.h (match_fd_common): Add new declaration. > * basic_filters.c (run_fd_filter): Use match_fd_common for fd filter. > --- > bas

Re: [PATCH v7 4/8] Optimize default filtering

2017-08-13 Thread Eugene Syromiatnikov
On Fri, Aug 11, 2017 at 05:43:49PM +0700, Nikolay Marchuk wrote: > * filter_action.c (default_flags): Add default flags variable. > (add_action): Update default flags. > (filter_syscall): Add default_flags to qual_flg. > (filtering_parse_finish): Init trace action for pathtracing. > * strace.c (ini

Re: [PATCH v2 05/25] netlink: add a basic rtnetlink parser of rule messages

2017-08-13 Thread Dmitry V. Levin
On Sun, Aug 13, 2017 at 10:22:23AM +0800, JingPiao Chen wrote: > * defs.h (routing_table_ids): New xlat prototype. > * netlink_route.c: New file. > * Makefile.am (strace_SOURCES): Add it. > * defs.h (ip_type_of_services, > routing_table_ids): New xlat prototypes. > * netlink_route.h (decode_fib_rul

Re: [PATCH v2 07/25] netlink: add a basic rtnetlink parser of neigh messages

2017-08-13 Thread Dmitry V. Levin
On Sun, Aug 13, 2017 at 10:22:25AM +0800, JingPiao Chen wrote: > * rtnl_neigh.c: New file. > * Makefile.am (strace_SOURCES): Add it. > * netlink_route.h (decode_ndmsg, decode_rtm_getneigh): New prototypes. > * configure.ac (AC_CHECK_HEADERS): Add linux/neighbour.h. > * netlink_route.c (route_decode

Re: [PATCH v2 09/25] netlink: add a basic rtnetlink parser of neightbl messages

2017-08-13 Thread Dmitry V. Levin
On Sun, Aug 13, 2017 at 10:22:27AM +0800, JingPiao Chen wrote: > * rtnl_neightbl.c: New file. > * Makefile.am (strace_SOURCES): Add it. > * netlink_route.h (decode_ndtmsg): New prototype. > * netlink_route.c (route_decoders): Add RTM_GETNEIGHTBL, > RTM_NEWNEIGHTBL and RTM_SETNEIGHTBL. [...] > +#inc

Re: [PATCH v2 09/25] netlink: add a basic rtnetlink parser of neightbl messages

2017-08-13 Thread JingPiao Chen
On Mon, Aug 14, 2017 at 04:23:21AM +0300, Dmitry V. Levin wrote: > On Sun, Aug 13, 2017 at 10:22:27AM +0800, JingPiao Chen wrote: > > * rtnl_neightbl.c: New file. > > * Makefile.am (strace_SOURCES): Add it. > > * netlink_route.h (decode_ndtmsg): New prototype. > > * netlink_route.c (route_decoders)

Re: [PATCH v7 fix 5/8] Implement new filtering language parsing

2017-08-13 Thread Eugene Syromiatnikov
On Sat, Aug 12, 2017 at 03:23:24PM +0700, Nikolay Marchuk wrote: > * basic_filters.c (parse_set, parse_syscall_set): Use set inversion only in > qualify mode. > * filter.h (parse_filter_action, parse_qualify_action, > parse_filter_expression): Add new declarations. > * filter_action.c (parse_filter

Re: [PATCH v7 7/8] tests: check fd filter

2017-08-13 Thread Eugene Syromiatnikov
On Fri, Aug 11, 2017 at 05:43:52PM +0700, Nikolay Marchuk wrote: > * tests/filtering_fd-syntax.test: New file. > * tests/filtering_fd.c: Likewise. > * tests/filtering_fd.test: Likewise. > * tests/options-syntax.test: Remove fd filtering checks. > * tests/.gitignore: Add filtering_fd. > * tests/Make

Re: [PATCH v7 8/8] Add stacktrace filter action

2017-08-13 Thread Eugene Syromiatnikov
On Fri, Aug 11, 2017 at 05:43:53PM +0700, Nikolay Marchuk wrote: > * defs.h (QUAL_STACKTRACE): Add new qual flag. > (stacktrace): Add macro for checking QUAL_STACKTRACE. > (stack_trace_enabled): Change description. > * filter_action.c (action_types): Declare and add new filter action type. > (updat