[PATCH 2/2] Move SUPPORTED_PERSONALITIES to separate file

2017-08-22 Thread Edgar Kaziakhmedov
Since the defs.h contains unrelated set of functions which are redundant(and parhaps conflicting) for other binaries included in the strace package, part with quantifying the SUPPORTED_PERSONALITIES definition should be in separate file. * defs.h: Include "supported_personalities.h". (SUPPORTED_PE

[PATCH 1/2] Move string_to_uint* functions to separate file

2017-08-22 Thread Edgar Kaziakhmedov
To allow usage of utility function 'string_to_uint*' by other binaries included in the strace package and avoid useless includes of unnecessary headers, that are needed for util.c. * string_to_uint.h: New file. * defs.h: Include it. (string_to_uint_ex, string_to_uint_upto, string_to_uint): Move to

JingPiao Chen's GSoC status report - #12 of 13

2017-08-22 Thread JingPiao Chen
Hello, strace community! Project: Netlink socket parsers. Accoplisment: Fixed and decode NETLINK_ROUTE netlink attribute. Next week, do the same work. My Work Product Submission[1] have completed. If the link is broken, please tell me. Thank you. [1] https://ppiao.github.io/2017/08/22/strace-

Edgar Kaziakhmedov's GSoC status report - #11 of 13

2017-08-22 Thread Edgar Kaziakhmedov
Hi, strace community! Accomplishemnts: 1) asinfo implemented completely On the day, I'll send out patch with MAN and NEWS. And I am going to wtite final evaluation. As for specs, I am not really sure, does asinfo require it? I ask because asinfo tool is just the binary in the strace package, can

Edgar Kaziakhmedov's GSoC status report - #12 of 13

2017-08-22 Thread Edgar Kaziakhmedov
On Tue, 22 Aug 2017 17:33:56 +0300 Edgar Kaziakhmedov wrote: Hi, strace community! Accomplishemnts: 1) asinfo implemented completely On the day, I'll send out patch with MAN and NEWS. And I am going to wtite final evaluation. As for specs, I am not really sure, does asinfo require it? I ask

Re: [PATCH v2 1/3] inet_diag: rename decode_inet_addr to decode_inet_diag_hostcond_addr

2017-08-22 Thread Dmitry V. Levin
On Tue, Aug 22, 2017 at 02:45:47PM +0800, JingPiao Chen wrote: > decode_inet_addr only use to decode inet_diag_hostcond.addr, > rename to decode_inet_diag_hostcond_addr. Well, I thought you'd choose a different approach: generalize this decode_inet_addr on top of print_inet_addr, and make rtnetlin

Re: [PATCH v2 2/3] rtnl_addr: decode ifaddrmsg netlink attributes

2017-08-22 Thread Dmitry V. Levin
On Tue, Aug 22, 2017 at 02:45:48PM +0800, JingPiao Chen wrote: > * address.c: New file. > * Makefile.am (strace_SOURCES): Add it. > * defs.h (decode_inet_address, decode_proto_address): New prototypes. > * rtnl_addr.c (decode_ifa_address, > decode_ifa_cacheinfo, decode_ifa_flags): New functions. >

Re: [PATCH v2 3/3] tests: check decoding of ifaddrmsg netlink attributes

2017-08-22 Thread Dmitry V. Levin
On Tue, Aug 22, 2017 at 02:45:49PM +0800, JingPiao Chen wrote: > * tests/nlattr_ifaddrmsg.c: Include . > (IFA_FLAGS, SET_IFA_FAMILY): New macros. > (init_ifaddrmsg): Set ifaddrmsg.ifa_family field. > (print_ifaddrmsg): Print ifaddrmsg.ifa_family field use %s format. > (main): Check decoding of IFA_

Re: [PATCH v8 01/12] tests: improve syscall set syntax testing

2017-08-22 Thread Dmitry V. Levin
On Tue, Aug 22, 2017 at 01:01:42PM +0700, Nikolay Marchuk wrote: > * tests/filtering_syscall-syntax.test: New file. > * tests/options-syntax.test: Move syscall set syntax testing to > filtering_syscall-syntax.test. > * tests/qual_fault-syntax.test: Likewise. > * tests/qual_inject-syntax.test: Likew

Re: [PATCH 1/2] Move string_to_uint* functions to separate file

2017-08-22 Thread Dmitry V. Levin
On Tue, Aug 22, 2017 at 03:35:02PM +0300, Edgar Kaziakhmedov wrote: > To allow usage of utility function 'string_to_uint*' by other binaries > included in the strace package and avoid useless includes of > unnecessary headers, that are needed for util.c. > > * string_to_uint.h: New file. > * defs.

Re: [PATCH 2/2] Move SUPPORTED_PERSONALITIES to separate file

2017-08-22 Thread Dmitry V. Levin
On Tue, Aug 22, 2017 at 03:35:03PM +0300, Edgar Kaziakhmedov wrote: > Since the defs.h contains unrelated set of functions which are > redundant(and parhaps conflicting) for other binaries included in > the strace package, part with quantifying the SUPPORTED_PERSONALITIES > definition should be in

Re: [PATCH 2/2] Move SUPPORTED_PERSONALITIES to separate file

2017-08-22 Thread Edgar Kaziakhmedov
On Tue, 22 Aug 2017 19:32:36 +0300 "Dmitry V. Levin" wrote: > On Tue, Aug 22, 2017 at 03:35:03PM +0300, Edgar Kaziakhmedov wrote: > > Since the defs.h contains unrelated set of functions which are > > redundant(and parhaps conflicting) for other binaries included in > > the strace package, part w

Re: [PATCH 2/2] Move SUPPORTED_PERSONALITIES to separate file

2017-08-22 Thread Dmitry V. Levin
On Tue, Aug 22, 2017 at 07:40:49PM +0300, Edgar Kaziakhmedov wrote: > On Tue, 22 Aug 2017 19:32:36 +0300 > "Dmitry V. Levin" wrote: > > > On Tue, Aug 22, 2017 at 03:35:03PM +0300, Edgar Kaziakhmedov wrote: > > > Since the defs.h contains unrelated set of functions which are > > > redundant(and pa

Re: [PATCH v8 02/12] Introduce new filtering architecture

2017-08-22 Thread Dmitry V. Levin
On Tue, Aug 22, 2017 at 01:01:43PM +0700, Nikolay Marchuk wrote: > This change introduces new filtering architecture primitives: filter, > filter_action and bool_expression. Filtering is now done after decoding of > syscall and tcp->qual_flg stores filtering results. > > * basic_actions.c: New fil

[PATCH 1/2] Move string_to_uint* functions to separate file

2017-08-22 Thread Edgar Kaziakhmedov
To allow usage of utility function 'string_to_uint*' by other binaries included in the strace package and avoid useless includes of unnecessary headers, that are needed for util.c. * string_to_uint.h: New file. * defs.h: Include it. (string_to_uint_ex, string_to_uint_upto, string_to_uint): Move to

[PATCH 2/2] Move SUPPORTED_PERSONALITIES to separate file

2017-08-22 Thread Edgar Kaziakhmedov
Since the defs.h contains unrelated set of functions which are redundant(and parhaps conflicting) for other binaries included in the strace package, part with quantifying the SUPPORTED_PERSONALITIES definition should be in separate file. * defs.h: Include "supported_personalities.h". (SUPPORTED_PE

Re: [PATCH 1/2] Move string_to_uint* functions to separate file

2017-08-22 Thread Edgar Kaziakhmedov
On Tue, 22 Aug 2017 21:17:45 +0300 Edgar Kaziakhmedov wrote: > To allow usage of utility function 'string_to_uint*' by other binaries > included in the strace package and avoid useless includes of > unnecessary headers, that are needed for util.c. > > * string_to_uint.h: New file. > * defs.h: In

[PATCH 2/2] tests: check decoding of rtmsg netlink attributes

2017-08-22 Thread JingPiao Chen
* tests/nlattr_rtmsg.c (LWTUNNEL_ENCAP_NONE, RTA_ENCAP_TYPE): New macros. (main): Check decoding of RTA_DST, RTA_OIF, RTA_METRICS, RTA_MULTIPATH, RTA_CACHEINFO, RTA_MFC_STATS, RTA_VIA and RTA_ENCAP_TYPE. --- tests/nlattr_rtmsg.c | 112 +++ 1 file cha

[PATCH 1/2] rtnl_route: decode rtmsg netlink attributes

2017-08-22 Thread JingPiao Chen
* configure.ac (AC_CHECK_TYPES): Check for rta_mfc_stats and rtvia structures in . * nlattr.c (decode_nla_ifindex): New function. * nlattr.h (decode_nla_ifindex): New prototype. * rtnl_route.c (decode_route_addr, decode_rta_metrics, decode_rta_multipath, decode_rta_cacheinfo, decode_rta_mfc_stats,

Re: [PATCH v8 02/12] Introduce new filtering architecture

2017-08-22 Thread Dmitry V. Levin
On Tue, Aug 22, 2017 at 08:33:01PM +0300, Dmitry V. Levin wrote: > On Tue, Aug 22, 2017 at 01:01:43PM +0700, Nikolay Marchuk wrote: [...] > > diff --git a/filter_qualify.c b/filter_qualify.c > > index 4283e769..ff54720a 100644 > > --- a/filter_qualify.c > > +++ b/filter_qualify.c > > @@ -38,16 +38,

Re: [PATCH 2/4] Move is_number_in_set prototype to filter.h

2017-08-22 Thread Dmitry V. Levin
On Tue, Aug 22, 2017 at 09:37:38AM +0700, Nikolay Marchuk wrote: > On 22.08.2017 01:23, Edgar Kaziakhmedov wrote: > > On Mon, Aug 21, 2017 at 07:21:44PM +0300, Dmitry V. Levin wrote: > > > On Mon, Aug 21, 2017 at 03:06:57AM +0300, Edgar Kaziakhmedov wrote: > > > > Since the filter.h unites set of f

Re: [PATCH 0/2] rtnl_link: decode ifinfomsg netlink attributes

2017-08-22 Thread Dmitry V. Levin
On Fri, Aug 18, 2017 at 04:43:56PM +0800, JingPiao Chen wrote: > The place where should review stricter: > > * decode_ifla_address(): AF_INET and AF_INET6 address print format. > * decode_rtnl_link_ifmap(): mpersify struct rtnl_link_ifmap. > * tests: test address should change the header message,

Re: [PATCH 1/2] rtnl_route: decode rtmsg netlink attributes

2017-08-22 Thread Dmitry V. Levin
On Wed, Aug 23, 2017 at 08:45:18AM +0800, JingPiao Chen wrote: > * configure.ac (AC_CHECK_TYPES): Check for > rta_mfc_stats and rtvia structures in . > * nlattr.c (decode_nla_ifindex): New function. > * nlattr.h (decode_nla_ifindex): New prototype. > * rtnl_route.c (decode_route_addr, decode_rta_me

Re: [PATCH 2/2] tests: check decoding of rtmsg netlink attributes

2017-08-22 Thread Dmitry V. Levin
On Wed, Aug 23, 2017 at 08:45:19AM +0800, JingPiao Chen wrote: > * tests/nlattr_rtmsg.c (LWTUNNEL_ENCAP_NONE, > RTA_ENCAP_TYPE): New macros. > (main): Check decoding of RTA_DST, RTA_OIF, RTA_METRICS, > RTA_MULTIPATH, RTA_CACHEINFO, RTA_MFC_STATS, > RTA_VIA and RTA_ENCAP_TYPE. [...] > + static s

Re: [PATCH 1/2] rtnl_route: decode rtmsg netlink attributes

2017-08-22 Thread JingPiao Chen
On Wed, Aug 23, 2017 at 04:30:28AM +0300, Dmitry V. Levin wrote: > On Wed, Aug 23, 2017 at 08:45:18AM +0800, JingPiao Chen wrote: > > * configure.ac (AC_CHECK_TYPES): Check for > > rta_mfc_stats and rtvia structures in . > > * nlattr.c (decode_nla_ifindex): New function. > > * nlattr.h (decode_nla_

Re: [PATCH 1/2] rtnl_route: decode rtmsg netlink attributes

2017-08-22 Thread Dmitry V. Levin
On Wed, Aug 23, 2017 at 09:57:37AM +0800, JingPiao Chen wrote: > On Wed, Aug 23, 2017 at 04:30:28AM +0300, Dmitry V. Levin wrote: > > On Wed, Aug 23, 2017 at 08:45:18AM +0800, JingPiao Chen wrote: > > > * configure.ac (AC_CHECK_TYPES): Check for > > > rta_mfc_stats and rtvia structures in . > > > *