Re: GSoC 2017: proposal v2

2017-04-03 Thread Eugene Syromiatnikov
On Sun, Apr 02, 2017 at 04:29:36AM +0300, Edgar Kaziahmedov wrote: > https://github.com/edosedgar/xs-pkg/blob/master/proposal.txt The other thing (besides syscallents.h) I think might useful to leverage is the current syscall filtering mechanism, so it would be possible to check out which system c

Re: GSOC 2017: Project Proposal

2017-04-03 Thread Eugene Syromiatnikov
On Mon, Apr 03, 2017 at 08:08:34PM +0530, sandhya bankar wrote: > Please review my proposal link for the project "Comprehensive test suite" > > https://docs.google.com/document/d/1RY5cdJGb0UVN-5q5imuwrcVnFRlVgM0Rx3okdrfkxTU/edit?usp=sharing Can you please provide information regarding the sched

Re: GSOC 2017: Project Proposal

2017-04-03 Thread Eugene Syromiatnikov
On Mon, Apr 03, 2017 at 08:51:34PM +0530, sandhya bankar wrote: > To deal with code coverage, I will run individual test cases to find > out why the coverage is below 100%. OK, let's be more specific: what are your suggestions in regards of increasing coverage of dm.c up to 100%?

Re: GSOC 2017: Project Proposal

2017-04-03 Thread Eugene Syromiatnikov
On Mon, Apr 03, 2017 at 09:26:59PM +0530, sandhya bankar wrote: > On Mon, Apr 3, 2017 at 9:10 PM, Eugene Syromiatnikov wrote: > > On Mon, Apr 03, 2017 at 08:51:34PM +0530, sandhya bankar wrote: > >> To deal with code coverage, I will run individual test cases to find > >&

Re: GSoC 2017: patch for the stat/nanosecond bug

2017-04-03 Thread Eugene Syromiatnikov
On Mon, Apr 03, 2017 at 07:46:10PM +0300, Dmitry Savelyev wrote: > Hello. My name is Dmitry Savelyev and I'm a third year student at CMC MSU > looking to participate in this year's GSoC with strace. > > I have, of course, already submitted my proposal for netlink socket parsers, > although I did k

Re: [PATCH 2/3] Implement simple color output

2017-04-04 Thread Eugene Syromiatnikov
On Fri, Mar 31, 2017 at 07:20:52PM +0800, JingPiao Chen wrote: [...] > diff --git a/color.h b/color.h > new file mode 100644 > index 000..8e58c90 > --- /dev/null > +++ b/color.h > @@ -0,0 +1,29 @@ > +#ifndef STRACE_COLOR_H > +#define STRACE_COLOR_H > + > +#define C_CLEAR "\033[0m"

Re: [PATCH 1/3] xlat/v4l2*.in: update of various v4l2's flags

2017-04-04 Thread Eugene Syromiatnikov
On Tue, Apr 04, 2017 at 03:27:35AM +0300, Dmitry V. Levin wrote: > V4L2_BUF_FLAG_INPUT was removed in Linux 3.6, so you sync removes it but > the changelog just says about new flags. I haven't looked at the patch yet, but personally I'm against removal of anything which is supported by at least on

Re: [PATCH 1/2] v4l2: add all printings to print_v4l2_format

2017-04-13 Thread Eugene Syromiatnikov
On Thu, Apr 13, 2017 at 04:32:31PM +0300, Edgar Kaziahmedov wrote: > On Wed, 12 Apr 2017 04:15:28 +0300 > "Dmitry V. Levin" wrote: > > > v2.5.46~39^2~23^2~4 > > I am sorry for this question, but Linux kernel placed on kernel.org > consists of the earliest version just Linux-2.6.12-rc2. How do >

Re: [post 1]GSoC 2017: Netlink socket parsers

2017-05-09 Thread Eugene Syromiatnikov
On Sun, May 07, 2017 at 10:47:02PM +0800, JingPiao Chen wrote: > Hi, strace community: > > My name is JingPiao Chen. I'm luckily selected by strace to work on > Netlink socket parsers in GSoC this year. My main goal is to extend to > support > more netlink family protocols. > > I want to

Re: Netlink Socket Parser

2017-05-09 Thread Eugene Syromiatnikov
On Wed, May 03, 2017 at 09:06:28PM +0530, Abhishek Tiwari wrote: > I have read about netlink packet structure and its use for IPC between > kernel and userspace and different processes in user space. > > There are various commits from Saruta's netlink branch that have still > not been merged into

Re: Problem with strace quotactl tests under Linux x86_64

2017-05-09 Thread Eugene Syromiatnikov
On Tue, May 09, 2017 at 06:33:16PM -0400, Andy Riebs wrote: > With kernel address space randomization enabled (the default, "sysctl > kernel.randomize_va_space=1"), the build is just fine. However, if it is > disabled (sysctl kernel.randomize_va_space=0"), the quotactl tests fail, > as shown bel

Re: Conflicting projects.

2017-05-12 Thread Eugene Syromiatnikov
On Fri, May 12, 2017 at 09:34:21PM +0700, Nikolay Marchuk wrote: > Hello, > I found that my Gsoc project and Victor Krapivenskiy's project are > conflicting because both of them include syscall filtering. My solution > of this conflict is to remove filtering part from Viktor's project and I > will

Re: Introducing new filtering architecture.

2017-06-05 Thread Eugene Syromiatnikov
On Sun, Jun 04, 2017 at 01:15:05PM +0700, Nikolay Marchuk wrote: > Hello, > This message describes new filtering architecture. Please, review it and > give me feedback. > > Filtering language. > The format of new filtering expression is: > > action(expr [, argument1=value1[,argument2=value2

Re: Introducing new filtering architecture.

2017-06-05 Thread Eugene Syromiatnikov
On Sun, Jun 04, 2017 at 01:15:05PM +0700, Nikolay Marchuk wrote: > Hello, > This message describes new filtering architecture. Please, review it and > give me feedback. One more aspect which I forgot to cover: by which means you expect to provide backwards compatibility for the existing filtering

Re: Edgar Kaziakhmedov's GSoC status report - #1 of 13

2017-06-05 Thread Eugene Syromiatnikov
On Mon, Jun 05, 2017 at 09:54:29AM +0300, Edgar Kaziahmedov wrote: > Hi, Strace Community > > Advanced syscall information tool > Accomplishments: > -> Edited configure and created Makefile.am's in tools and tools/asinfo > directories to build multiple executables. > -> Confirmed the final version

Re: [PATCH RFC v1 1/1] Initial support for Lua scripting

2017-06-15 Thread Eugene Syromiatnikov
On Sat, Jun 10, 2017 at 11:17:29PM +0300, Victor Krapivensky wrote: > * Makefile.am: Build with LuaJIT if configured so. > (strace_SOURCES): Add defs_reuse.h. > * configure.ac: Add new --with-luajit configure option. > * defs.h: Move code that needs to be fed to LuaJIT's FFI to... > * defs_reuse.h:

Re: [PATCH] Introduce new filtering architecture

2017-06-18 Thread Eugene Syromiatnikov
On Thu, Jun 15, 2017 at 11:22:57AM +0700, Nikolay Marchuk wrote: > This change introduces new filtering architecture primitives: filter, > filter_action and bool_expression. It also splits qualify.c > into basic_filters.c and basic_actions.c and changes processing of -e > strace option. Now, filter

Re: [PATCH] asinfo: Introduce static query tool asinfo

2017-06-18 Thread Eugene Syromiatnikov
On Thu, Jun 15, 2017 at 03:14:05PM +0300, Edgar Kaziahmedov wrote: > Main features were described in the status report, It's better to reiterate the description in the commit message, as the phrase "described in the status report" would be of little value in several years from now. > for example n

Re: [PATCH v3 2/6] Introduce new filtering architecture

2017-07-03 Thread Eugene Syromiatnikov
On Thu, Jun 29, 2017 at 02:46:11PM +0700, Nikolay Marchuk wrote: > This change introduces new filtering architecture primitives: filter, > filter_action and bool_expression. It also changes processing of -e > strace option. Now, filtering is done after decoding of syscall and > tcp->qual_flg stores

Re: [PATCH v3 3/6] Implement parsing of inject and fault filter actions

2017-07-03 Thread Eugene Syromiatnikov
On Thu, Jun 29, 2017 at 02:46:12PM +0700, Nikolay Marchuk wrote: > * basic_actions.c (parse_inject, parse_fault, apply_fault): Implement. > (apply_inject): Change inject private data. > * defs.h (inject_vec): Remove. > (inject_opts): Add init flag. > * filter.h (parse_inject_token): Add definition.

Re: [PATCH v3 4/6] Improve fd filtering

2017-07-03 Thread Eugene Syromiatnikov
On Thu, Jun 29, 2017 at 02:46:13PM +0700, Nikolay Marchuk wrote: > * basic_actions (apply_read, apply_write): Add syscall check. > * basic_filters (run_fd_filter): Implement more accurate fd filtering. > * defs.h (read_dumped, write_dumped): Add new flag checking macroses. > * syscall.c (dumpio): A

Re: [PATCH v3 5/6] Optimize default filtering

2017-07-03 Thread Eugene Syromiatnikov
On Thu, Jun 29, 2017 at 02:46:14PM +0700, Nikolay Marchuk wrote: > * filter_action.c (default_flags, clear_default_flags): Add default flags. > (add_action): Use action type as argument. Clear default flags. > (filter_syscall): Add default_flags to qual_flg. > * strace.c (init): Remove default filt

Re: [PATCH v3 6/6] Implement new filtering language parsing

2017-07-03 Thread Eugene Syromiatnikov
On Thu, Jun 29, 2017 at 02:46:15PM +0700, Nikolay Marchuk wrote: > * defs.h (parse_action): Add definition. > * filter.c: Add filters parsing function. > * filter.h: Add new definitions. > * filter_action.c: Add action parsing function. > * filter_expression.c: Add expression parsing function. > *

Re: [PATCH 1/2] Replace errs and mem subroutines to separate files

2017-07-09 Thread Eugene Syromiatnikov
On Wed, Jun 28, 2017 at 05:56:39AM +0300, Edgar Kaziahmedov wrote: > According to the current state of affairs, strace.c contains "According to the current state of affairs" makes little sense to me. It probably will be better if the reason for the change is mentioned in the first place, like "In o

Re: [PATCH 2/2] asinfo: Introduce static query tool asinfo

2017-07-09 Thread Eugene Syromiatnikov
On Wed, Jun 28, 2017 at 05:56:40AM +0300, Edgar Kaziahmedov wrote: > From: Edgar Kaziahmedov > > The first version of asinfo tool. The asinfo tool has the > following architecture: > architecture dispatcher->system call dispatcher->filter dispatcher > > As for arch. dispatcher, the asinfo has ge

Re: [PATCH 2/2] asinfo: Introduce static query tool asinfo

2017-07-10 Thread Eugene Syromiatnikov
On Wed, Jun 28, 2017 at 05:56:40AM +0300, Edgar Kaziahmedov wrote: > ... I've also forgot to mention the lack of documentation, test suite, and wiring of the tool installation in the spec/dsc files. -- Check out the vibra

Re: [PATCH v3 2/6] Introduce new filtering architecture

2017-07-12 Thread Eugene Syromiatnikov
On Wed, Jul 05, 2017 at 04:47:18PM +0700, Nikolay Marchuk wrote: > >> +void > >> +set_filters_qualify_mode(struct filter **filters, unsigned int *nfilters) > >> +{ > >> + unsigned int i; > >> + for (i = 0; i < *nfilters - 1; ++i) { > >> + free_filter(*filters + i); > >> + } > >> + **fi

Re: [PATCH v8 2/2] Introduce upoken function and expose it to LuaJIT scripts

2017-07-13 Thread Eugene Syromiatnikov
On Tue, Jul 11, 2017 at 02:48:50PM +0300, Victor Krapivensky wrote: > This patch implies that we have process_vm_writev if and only if we have Rather, the check. However, I'd prefer that process_vm_write's availability is checked separately. > process_vm_readv, and that they are either both suppor

Re: [PATCH v8 1/2] Initial support for LuaJIT scripting

2017-07-13 Thread Eugene Syromiatnikov
On Tue, Jul 11, 2017 at 02:48:48PM +0300, Victor Krapivensky wrote: > * .gitignore: Add luajit_lib.h. > * Makefile.am: Build with LuaJIT if configured so. > (strace_SOURCES): Add defs_shared.h, ffi.h. > (luajit_lib.h): Auto-generate from luajit_lib.lua. > * configure.ac: Add new --with-luajit confi

Re: [PATCH v4 2/6] Introduce new filtering architecture

2017-07-23 Thread Eugene Syromiatnikov
On Fri, Jul 14, 2017 at 09:55:31PM +0700, Nikolay Marchuk wrote: > This change introduces new filtering architecture primitives: filter, > filter_action and bool_expression. It also changes processing of -e > strace option. In which way? My understanding was that only implementation is what has cha

Re: [PATCH v5 4/8] Improve fd filtering

2017-07-23 Thread Eugene Syromiatnikov
On Wed, Jul 19, 2017 at 05:26:47PM +0700, Nikolay Marchuk wrote: > * pathtrace.c (match_fd_common, pathtrace_match_set): Move fd matching to > separate function. > * filter.h (match_fd_common): Add new declaration. > * basic_filters.c (run_fd_filter): Use match_fd_common for fd filter. > --- > bas

Re: [PATCH v5 4/8] Improve fd filtering

2017-07-23 Thread Eugene Syromiatnikov
Here's a draft of some small and quirky test for checking path tracing functionality, which you might found useful before some proper pathtrace test will be adopted in master: https://github.com/esyr-rh/strace/tree/pathtrace -

Re: [PATCH v5 6/8] Implement new filtering language parsing

2017-07-23 Thread Eugene Syromiatnikov
On Wed, Jul 19, 2017 at 05:26:49PM +0700, Nikolay Marchuk wrote: > * filter.h (parse_filter_action, parse_filter_expression): Add new > declarations. > * filter_action.c (parse_filter_action): Add new parsing function. > * filter_expression.c (parse_filter_expression): Implement parsing of filter

Re: [PATCH v5 7/8] Add path filter

2017-07-24 Thread Eugene Syromiatnikov
On Wed, Jul 19, 2017 at 05:26:50PM +0700, Nikolay Marchuk wrote: > * basic_filters.c: Add path filter functions. > * filter.c (filter_types): Add path filter entries. > --- > basic_filters.c | 34 ++ > filter.c| 4 +++- > 2 files changed, 37 insertions(+),

Re: [PATCH v5 8/8] tests: check fd filter

2017-07-24 Thread Eugene Syromiatnikov
On Wed, Jul 19, 2017 at 05:26:51PM +0700, Nikolay Marchuk wrote: > * tests/filtering_fd-syntax.test: New file. > * tests/filtering_fd.c: Likewise. > * tests/filtering_fd.test: Likewise. > * tests/options-syntax.test: Remove fd filtering checks. > * tests/.gitignore: Add filtering_fd. > * tests/Make

Re: Nikolay Marchuk's GSoC status report - #8 of 13

2017-07-25 Thread Eugene Syromiatnikov
On Tue, Jul 25, 2017 at 06:26:06PM +0700, Nikolay Marchuk wrote: > Hello, strace community! > > Project: Advanced syscall filtering syntax. > > > Accomplishments: this week I've been working on improvements of fd > filtering. Unfortunately, I haven't found good solution for the issue > with nega

Re: [PATCH v9 1/3] Initial support for LuaJIT scripting

2017-07-30 Thread Eugene Syromiatnikov
On Tue, Jul 25, 2017 at 03:59:50PM +0300, Victor Krapivensky wrote: > * .gitignore: Add luajit_lib.h. > * Makefile.am: Build with LuaJIT if configured so. > (strace_SOURCES): Add defs_shared.h, ffi.h. > (luajit_lib.h): Auto-generate from luajit_lib.lua. > * configure.ac: Add new --with-luajit confi

Re: [PATCH v9 2/3] Introduce upoken function and expose it to LuaJIT scripts

2017-07-30 Thread Eugene Syromiatnikov
On Tue, Jul 25, 2017 at 03:59:52PM +0300, Victor Krapivensky wrote: > This patch implies that we have process_vm_writev if and only if we have > process_vm_readv, and that they are either both supported or both > unsupported. > > * defs.h: Add declaration for upoken. > * luajit.h (func_upoke): New

Re: [PATCH v9 3/3] tests: check LuaJIT scripting support

2017-07-30 Thread Eugene Syromiatnikov
On Tue, Jul 25, 2017 at 03:59:54PM +0300, Victor Krapivensky wrote: > * tests/.gitignore: Add lua. > * tests/Makefile.am (check_PROGRAMS): Likewise. > (LUAJIT_TESTS): New variable. > (TESTS): Add LUAJIT_TESTS. > (EXTRA_DIST): Add lua.sh, lua-basics.test, lua-qual.test, > lua-tampering.test. > * tes

Re: [PATCH 2/2] asinfo: Introduce static query tool asinfo

2017-07-30 Thread Eugene Syromiatnikov
On Fri, Jul 28, 2017 at 06:43:25PM +0300, Edgar Kaziakhmedov wrote: > From: Edgar Kaziakhmedov > > The 1.2 version of asinfo tool. The asinfo tool has the This version is not mentioned anywhere else. > following architecture: > commnand dispatcher->architecture dispatcher->abi dispatcher-> "comm

Initial merge of filtering/lua/asinfo GSoC 2017 projects

2017-08-06 Thread Eugene Syromiatnikov
Hello. As GSoC 2017 nearing its completion, I decided that it's time to try to look at the merged version of the code. You can have a look at the results of my attempt at [1]. Some notes: * As expected, most conflicts are between Victor's and Nikolay's work. Edgar's part is applying without a

Re: [PATCH v6 3/9] Introduce new filtering architecture

2017-08-06 Thread Eugene Syromiatnikov
On Wed, Aug 02, 2017 at 12:36:43PM +0700, Nikolay Marchuk wrote: > This change introduces new filtering architecture primitives: filter, > filter_action and bool_expression. Filtering is now done after decoding of > syscall and tcp->qual_flg stores filtering results. > > * basic_actions.c: New fil

Re: [PATCH v6 4/9] Improve fd filtering

2017-08-06 Thread Eugene Syromiatnikov
On Wed, Aug 02, 2017 at 12:36:44PM +0700, Nikolay Marchuk wrote: > * pathtrace.c (match_fd_common, pathtrace_match_set): Move fd matching to > separate function. > * filter.h (match_fd_common): Add new declaration. > * basic_filters.c (run_fd_filter): Use match_fd_common for fd filter. > --- > bas

Re: [PATCH v6 5/9] Optimize default filtering

2017-08-06 Thread Eugene Syromiatnikov
On Wed, Aug 02, 2017 at 12:36:45PM +0700, Nikolay Marchuk wrote: > * filter_action.c (default_flags, update_default_flags): Add default flags. > (add_action): Clear default flags. > (filter_syscall): Add default_flags to qual_flg. > (filtering_parse_finish): Init trace action for pathtracing. Don't

Re: [PATCH v6 6/9] Implement new filtering language parsing

2017-08-06 Thread Eugene Syromiatnikov
On Wed, Aug 02, 2017 at 12:36:46PM +0700, Nikolay Marchuk wrote: > * filter.h (parse_filter_action, parse_filter_expression): Add new > declarations. > * filter_action.c (parse_filter_action): Add new parsing function. > (filtering_parse_function): Use filtering_parse instead of > parse_qualify_fi

Re: [PATCH v6 7/9] Add path filter

2017-08-06 Thread Eugene Syromiatnikov
On Wed, Aug 02, 2017 at 12:36:47PM +0700, Nikolay Marchuk wrote: > * basic_filters.c: Add path filter functions. > * filter.c (filter_types): Add path filter entries. > --- > basic_filters.c | 31 +++ > filter.c| 2 ++ > 2 files changed, 33 insertions(+) > > d

Re: [PATCH v6 9/9] Add stacktrace filter action

2017-08-06 Thread Eugene Syromiatnikov
On Wed, Aug 02, 2017 at 12:36:49PM +0700, Nikolay Marchuk wrote: > * defs.h (QUAL_STACKTRACE): Add new qual flag. > (stacktrace): Add macro for checking QUAL_STACKTRACE. > (stack_trace_enabled): Change description. > * filter_action.c (action_types): Declare and add new filter action type. > (updat

Re: [PATCH v10 1/3] Initial support for LuaJIT scripting

2017-08-07 Thread Eugene Syromiatnikov
On Wed, Aug 02, 2017 at 12:50:54PM +0300, Victor Krapivensky wrote: > * .gitignore: Add luajit_lib.h. > * Makefile.am: Build with LuaJIT if configured so. > (strace_SOURCES): Add defs_shared.h, ffi.h. > (luajit_lib.h): Auto-generate from luajit_lib.lua. > * configure.ac: Add new --with-luajit confi

Re: [PATCH v10 2/3] Introduce upoken function and expose it to LuaJIT scripts

2017-08-07 Thread Eugene Syromiatnikov
On Wed, Aug 02, 2017 at 12:50:56PM +0300, Victor Krapivensky wrote: > This patch implies that we have process_vm_writev if and only if we have > process_vm_readv, and that they are either both supported or both > unsupported. > > * defs.h: Add declaration for upoken. > * luajit.h (func_upoke): New

Re: [PATCH 1/3] Move err/mem subroutines to separate files

2017-08-07 Thread Eugene Syromiatnikov
On Sat, Aug 05, 2017 at 04:57:34AM +0300, Edgar Kaziakhmedov wrote: > From: Edgar Kaziakhmedov "virtuozzo" > > In order to allow usage of utility functions by other binaries > included in the strace package (like the upcoming asinfo utility), > these functions should be moved to separate files.

Re: [PATCH 2/3] Move shorthand notations to separate file

2017-08-07 Thread Eugene Syromiatnikov
On Sat, Aug 05, 2017 at 04:57:35AM +0300, Edgar Kaziakhmedov wrote: > In order to allow usage shorthand notations of defines in sysent.h file "usage of shorthand notations of definitions from sysent.h used in syscallent.h files" > by other binaries in the strace package these defines should be mov

Re: [PATCH 2/2] asinfo: Introduce static query tool asinfo

2017-08-07 Thread Eugene Syromiatnikov
On Tue, Aug 01, 2017 at 01:13:56AM +0300, Edgar Kaziakhmedov wrote: > On Mon, 31 Jul 2017 06:19:23 +0200 > Eugene Syromiatnikov wrote: > > > +enum impl_type > > > +al_sck_syscall(struct arch_service *m, unsigned index) > > > +{ > > > + struct arch_descri

Re: [PATCH 3/3] asinfo: Introduce static query tool asinfo

2017-08-07 Thread Eugene Syromiatnikov
On Sat, Aug 05, 2017 at 04:57:36AM +0300, Edgar Kaziakhmedov wrote: > From: Edgar Kaziakhmedov "virtuozzo" > > The main purpose of this program is to present all information concluded > at sysent.h files as a query tool. > The asinfo tool has the following architecture: > command dispatcher->arc

Re: [PATCH 3/3] asinfo: Introduce static query tool asinfo

2017-08-10 Thread Eugene Syromiatnikov
On Sat, Aug 05, 2017 at 04:57:36AM +0300, Edgar Kaziakhmedov wrote: > + > +#define ARCH_DESC_DEFINE(arch, base_arch, mode) \ > + [ARCH_##arch##_##mode] = { \ > + .arch_num = ARCH_##arch##_##mode, \ > + .arch_name = #arch, \ > + .arc

Re: [PATCH v7 3/8] Improve fd filtering

2017-08-13 Thread Eugene Syromiatnikov
On Fri, Aug 11, 2017 at 05:43:48PM +0700, Nikolay Marchuk wrote: > * pathtrace.c (match_fd_common, pathtrace_match_set): Move fd matching to > separate function. > * filter.h (match_fd_common): Add new declaration. > * basic_filters.c (run_fd_filter): Use match_fd_common for fd filter. > --- > bas

Re: [PATCH v7 4/8] Optimize default filtering

2017-08-13 Thread Eugene Syromiatnikov
On Fri, Aug 11, 2017 at 05:43:49PM +0700, Nikolay Marchuk wrote: > * filter_action.c (default_flags): Add default flags variable. > (add_action): Update default flags. > (filter_syscall): Add default_flags to qual_flg. > (filtering_parse_finish): Init trace action for pathtracing. > * strace.c (ini

Re: [PATCH v7 fix 5/8] Implement new filtering language parsing

2017-08-13 Thread Eugene Syromiatnikov
On Sat, Aug 12, 2017 at 03:23:24PM +0700, Nikolay Marchuk wrote: > * basic_filters.c (parse_set, parse_syscall_set): Use set inversion only in > qualify mode. > * filter.h (parse_filter_action, parse_qualify_action, > parse_filter_expression): Add new declarations. > * filter_action.c (parse_filter

Re: [PATCH v7 7/8] tests: check fd filter

2017-08-13 Thread Eugene Syromiatnikov
On Fri, Aug 11, 2017 at 05:43:52PM +0700, Nikolay Marchuk wrote: > * tests/filtering_fd-syntax.test: New file. > * tests/filtering_fd.c: Likewise. > * tests/filtering_fd.test: Likewise. > * tests/options-syntax.test: Remove fd filtering checks. > * tests/.gitignore: Add filtering_fd. > * tests/Make

Re: [PATCH v7 8/8] Add stacktrace filter action

2017-08-13 Thread Eugene Syromiatnikov
On Fri, Aug 11, 2017 at 05:43:53PM +0700, Nikolay Marchuk wrote: > * defs.h (QUAL_STACKTRACE): Add new qual flag. > (stacktrace): Add macro for checking QUAL_STACKTRACE. > (stack_trace_enabled): Change description. > * filter_action.c (action_types): Declare and add new filter action type. > (updat

Re: [PATCH v11 1/3] Initial support for LuaJIT scripting

2017-08-23 Thread Eugene Syromiatnikov
On Tue, Aug 15, 2017 at 01:09:23AM +0300, Victor Krapivensky wrote: > * .gitignore: Add luajit_lib.h. > * Makefile.am: Build with LuaJIT if configured so. > (strace_SOURCES): Add defs_shared.h, ffi.h. > (luajit_lib.h): Auto-generate from luajit_lib.lua. > * basic_filters.c (make_number_set_universa

Re: [PATCH v11 1/3] Initial support for LuaJIT scripting

2017-08-25 Thread Eugene Syromiatnikov
On Fri, Aug 25, 2017 at 11:33:30PM +0300, Victor Krapivensky wrote: > strace is built with a Lua implementation, not a FFI library. LuaJIT > comes with its own FFI library, non-LuaJIT users have to install a > standalone one. A compile-time difference is that LuaJIT defines > LUA_FFILIBNAME, and, i

Re: [PATCH] Add gdb remote protocol handling to strace

2017-11-02 Thread Eugene Syromiatnikov
On Thu, Nov 02, 2017 at 06:38:39AM +0300, Dmitry V. Levin wrote: > On Tue, Oct 17, 2017 at 02:29:31PM -0400, Stan Cox wrote: > [...] > > + /* Make sure SIGCHLD has the default action so that waitpid > > + definitely works without losing track of children. The user > > + should not have

Re: strace requires gawk 4 but doesn't test for it

2018-01-18 Thread Eugene Syromiatnikov
On Fri, Jan 05, 2018 at 04:15:10PM -0500, DJ Delorie wrote: > > "Dmitry V. Levin" writes: > > checking whether mpers.sh -m32 works... gawk: ./mpers.awk:42: > > array_return = array[array_idx][array_member] > > gawk: ./mpers.awk:42: ^ syntax error > > ... > > no

Re: [strace PATCH 00/12] s390 architecture support improvements

2018-01-22 Thread Eugene Syromiatnikov
On Sat, Jan 20, 2018 at 12:23:23PM +0100, Heiko Carstens wrote: > On Thu, Jan 18, 2018 at 07:16:31AM +0100, Eugene Syromyatnikov wrote: > > Hello. > > > > This patch set introduces compat personality support on s390x along with > > decoders of s390-specific system calls. > > > > Unfortunately, I

Re: [strace PATCH 04/12] Introduce s390_sthyi system call decoder

2018-01-22 Thread Eugene Syromiatnikov
On Mon, Jan 22, 2018 at 02:16:43PM +0100, Heiko Carstens wrote: > On Thu, Jan 18, 2018 at 07:16:44AM +0100, Eugene Syromyatnikov wrote: > > +static void > > +print_sthyi_hypervisor(struct tcb *tcp, struct sthyi_hypervisor *hdr, > > + uint16_t size, int num, bool mt) > > +{ > > +

Re: Issue #31: PID namespace translation

2018-02-06 Thread Eugene Syromiatnikov
On Tue, Feb 06, 2018 at 04:03:05PM +0530, Abhishek Tiwari wrote: > I want to work on this issue. Please clarify syntax of *printxval* function. What do you mean by "syntax"? For what it's worth, printxval is a simple wrapper around printxvals for the case when there's only one xlat table to get n

Re: Issue #31: PID namespace translation

2018-02-09 Thread Eugene Syromiatnikov
On Fri, Feb 09, 2018 at 03:06:52PM +0530, Abhishek Tiwari wrote: > please do reply Well, I did [1]. [1] https://sourceforge.net/p/strace/mailman/message/36217447/ -- Check out the vibrant tech community on one of the wor

Re: 4.21 build failure

2018-02-19 Thread Eugene Syromiatnikov
On Thu, Feb 15, 2018 at 12:39:15AM +0100, Andreas Schwab wrote: > 4.21 fails to build for aarch64: > > checking gnu/stubs-32.h usability... no > checking gnu/stubs-32.h presence... no > checking for gnu/stubs-32.h... no > configure: Created empty gnu/stubs-32.h > checking for m32 personality compi

Re: 4.21 build failure

2018-02-21 Thread Eugene Syromiatnikov
On Mon, Feb 19, 2018 at 09:21:59PM +0100, Andreas Schwab wrote: > On Feb 19 2018, Eugene Syromiatnikov wrote: > > > On Mon, Feb 19, 2018 at 07:31:57PM +0100, Andreas Schwab wrote: > >> On Feb 19 2018, Eugene Syromiatnikov wrote: > >> > >> > On Thu,

Re: GSOC:Microproject

2018-02-22 Thread Eugene Syromiatnikov
On Thu, Feb 15, 2018 at 07:07:59PM +0530, Abhishek Tiwari wrote: > Hi, > > I want to work on microproject > > extend -e trace=class syntax with new classes > > > I have gone through mailing list. Is following grouping ok > > {,l,f}setxattr TRACE_SETXATTR TFX Doesn't -e trace='/[lf]?