[PATCH 4/5] Update linux/ioctlent.h.in file

2015-01-15 Thread Gabriel Laskar
* linux/ioctlent.h.in: Regenerate from v3.18 headers and with newly decoded apis. Signed-off-by: Gabriel Laskar gabr...@lse.epita.fr --- There is a lot of conflict with Android ioctls and the rest of them. Maybe it would be better to enable Android support only if asked, in order to avoir

[PATCH 2/5] Add decoding for parametered ioctls

2015-01-15 Thread Gabriel Laskar
. * ioctl.c (ioctl_decode_number): Implement this new function. Signed-off-by: Gabriel Laskar gabr...@lse.epita.fr --- defs.h | 1 + io.c| 19 +++ ioctl.c | 115 3 files changed, 128 insertions(+), 7 deletions(-) diff --git

[PATCH 0/5] ioctl name for missing APIs

2015-01-15 Thread Gabriel Laskar
in evdev, are parametered. In order to decode them correctly, there is some code added in ioctl.c, in order to display the parameters. For Android, the headers lives inside driver/staging/android/uapi, so a path had to be added. I am not sure that it is the right way to do it. Gabriel Laskar (5

[PATCH 3/5] Add Decoding support for android ioctls

2015-01-15 Thread Gabriel Laskar
Android exposes 6 ioctls APIs, but they are placed in drivers/staging/android/uapi/. Moreover, binder ioctls are defined in an enum and with a define. * linux/ioctlent.h: Add parsing support for android ioctls. Signed-off-by: Gabriel Laskar gabr...@lse.epita.fr --- linux/ioctlent.sh | 17

[PATCH 1/5] Add parsing support for named ioctls APIs

2015-01-15 Thread Gabriel Laskar
Some ioctls APIs (drm, omapfb, and hsi_char) have an intermediate define for their definitions. ioctlent.sh is now able to find them correctly. * linux/ioctlent.sh: Add decoding support for drm, omapfb and hsi_char ioctls Signed-off-by: Gabriel Laskar gabr...@lse.epita.fr --- It should

[PATCH 5/5] Add ioctl decoding for android_alarm.

2015-01-15 Thread Gabriel Laskar
Android Alarms are parametered by the alarm type. This change add the output with the correct string. * ioctl.c (evdev_decode_number): Add android_alarm_decode_number call and implementation. * xlat/android_alarm_type.in: New file. Signed-off-by: Gabriel Laskar gabr...@lse.epita.fr --- ioctl.c

Re: [PATCH 4/5] Update linux/ioctlent.h.in file

2015-01-15 Thread Gabriel Laskar
the conflicts. On DRM, it will not solve the conflicts for the device specific ioctls, but it should be feasible. -- Gabriel Laskar -- New Year. New Location. New Benefits. New Data Center in Ashburn, VA. GigeNET

[PATCH v3] Add decoding for parametered ioctls

2015-01-21 Thread Gabriel Laskar
. * ioctl.c (ioctl_decode_number): Implement this new function. * xlat/evdev_abs.in: new file. * xlat/evdev_ev.in: new file. Signed-off-by: Gabriel Laskar gabr...@lse.epita.fr --- Here is a new version, which this time compiles, and is fullt merged. defs.h| 1 + io.c | 17

[PATCH v4] Add decoding for parametered ioctls

2015-01-21 Thread Gabriel Laskar
(sys_ioctl): Use ioctl_decode_number. * ioctl.c (ioctl_decode_number): New function. * xlat/evdev_abs.in: New file. * xlat/evdev_ev.in: New file. Signed-off-by: Gabriel Laskar gabr...@lse.epita.fr --- Here is a corrected version. I hope the Changelog is right this time. I added the check for linux

Re: [PATCH 4/5] Update linux/ioctlent.h.in file

2015-01-16 Thread Gabriel Laskar
why I have occulted this solution. I have missed the 14/13 bit snafu though. Maybe we can create 2 ioctlent.h.in files, 1 for the 14 bits size, and another one for the 13 bits one and compile the right one for each arch. -- Gabriel Laskar

Re: [PATCH 4/5] Update linux/ioctlent.h.in file

2015-01-16 Thread Gabriel Laskar
On Fri, Jan 16, 2015 at 3:41 PM, Dmitry V. Levin l...@altlinux.org wrote: On Fri, Jan 16, 2015 at 09:49:19AM +0100, Gabriel Laskar wrote: On Fri, Jan 16, 2015 at 12:39 AM, Dmitry V. Levin wrote: [...] strace uses only 16 bits (8-bit number and 8-bit type) of the 32-bit ioctl command, so

Re: [PATCH 1/5] Add parsing support for named ioctls APIs

2015-01-16 Thread Gabriel Laskar
On Fri, Jan 16, 2015 at 8:31 PM, Dmitry V. Levin l...@altlinux.org wrote: On Thu, Jan 15, 2015 at 08:32:26PM +0100, Gabriel Laskar wrote: [...] --- a/linux/ioctlent.sh +++ b/linux/ioctlent.sh @@ -94,6 +94,21 @@ regexp='^[[:space:]]*#[[:space:]]*define[[:space:]]\+[A-Z][A-Z0-9_]*[[:space

Re: Preparing for the next release: call for testing

2015-03-03 Thread Gabriel Laskar
, 0x63, 0x10, 0x04), 0) = -1 EBADF (Bad file descriptor) -- Gabriel Laskar -- Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media

Re: [GSOC2015] JSON Formatting

2015-03-03 Thread Gabriel Laskar
it as well. http://download.gmane.org allow to download an mbox archive of any mirrored list. -- Gabriel Laskar -- Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed

Re: [Intel-gfx] [RFC 0/2] strace/drm: Add i915 ioctls to strace

2015-05-11 Thread Gabriel Laskar
, 0x64, 0x41, 0x04), 0) = 0 +++ exited with 0 +++ $ sudo ~/source/strace/strace -e ioctl ./i915-ioctls ioctl(3, 0x40046441 /* I915_IOCTL_??? */, 0) = 0 +++ exited with 0 +++ -- Gabriel Laskar -- One dashboard for servers

Re: [Intel-gfx] [RFC 0/2] strace/drm: Add i915 ioctls to strace

2015-05-12 Thread Gabriel Laskar
On Tue, 12 May 2015 14:35:28 +0200 Patrik Jakobsson patrik.jakobs...@linux.intel.com wrote: On Mon, May 11, 2015 at 08:08:19PM +0200, Gabriel Laskar wrote: On Mon, 11 May 2015 15:54:24 +0200 Patrik Jakobsson patrik.jakobs...@linux.intel.com wrote: On Mon, May 11, 2015 at 12:50:36PM

Re: [PATCH 4/4] drm: Add decoding of DRM and KMS ioctls

2015-06-09 Thread Gabriel Laskar
On Tue, 9 Jun 2015 16:29:31 +0200 Patrik Jakobsson patrik.jakobs...@linux.intel.com wrote: On Tue, Jun 09, 2015 at 03:51:08PM +0200, Gabriel Laskar wrote: On Tue, 9 Jun 2015 13:26:44 +0200 Patrik Jakobsson patrik.jakobs...@linux.intel.com wrote: This patch adds many of the DRM and KMS

Re: [PATCH 2/4] drm: Add dispatcher and driver identification for DRM

2015-06-09 Thread Gabriel Laskar
/rxreg.h (possible overlap) + * d drm/drm.h * f sys/filio.h * g sunwindow/win_ioctl.h -no overlap- * g sunwindowdev/winioctl.c !no manifest constant! -no overlap- -- Gabriel Laskar

Re: [PATCH 4/4] drm: Add decoding of DRM and KMS ioctls

2015-06-09 Thread Gabriel Laskar
: + return drm_mode_map_dumb(tcp, code, arg); + case DRM_IOCTL_MODE_DESTROY_DUMB: + return drm_mode_destroy_dumb(tcp, code, arg); + case DRM_IOCTL_GEM_CLOSE: + return drm_gem_close(tcp, code, arg); + } + return 0; } -- Gabriel Laskar

Re: [PATCH v2 5/5] drm: Add decoding of DRM and KMS ioctls

2015-06-29 Thread Gabriel Laskar
*/ if (exiting(tcp) tcp-priv_data != NULL) { free(tcp-priv_data); -- Gabriel Laskar -- Don't Limit Your Business. Reach for the Cloud. GigeNET's Cloud Solutions provide you with the tools and support that you need

Re: [Intel-gfx] [PATCH v4 0/5] drm: Add decoding for DRM/KMS and i915 ioctls

2015-09-07 Thread Gabriel Laskar
| 51 > xlat/drm_i915_setparams.in | 4 + > 11 files changed, 1125 insertions(+) > create mode 100644 drm.c > create mode 100644 drm_i915.c > create mode 100644 xlat/drm_i915_getparams.in > create mode 100644 xlat/drm_i915_ioctls.in > create mode 100644 xlat/drm_i91

[PATCH v2] ioctl: fix conflicts command number decoding in case of conflicts

2015-09-23 Thread Gabriel Laskar
(1) or MCE_GET_RECORD_LEN, 0x7ffee435ce08) = 0 * ioctl.c (SYS_FUNC(ioctl)): fix ioctl command number decoding in case of conflicts * tests/ioctl.c: add case for conflicts Signed-off-by: Gabriel Laskar <gabr...@lse.epita.fr> --- v2: * changed the test to be able to handle iop == NULL

[PATCH] ioctl: allow to stop decoding number

2015-12-03 Thread Gabriel Laskar
* ioctl.c (SYS_FUNC(ioctl)): use IOCTL_NUMBER_* to stop the decoding Signed-off-by: Gabriel Laskar <gabr...@lse.epita.fr> Suggested-by: Patrik Jakobsson <patrik.r.jakobs...@gmail.com> --- defs.h | 4 ioctl.c | 20 +++- 2 files changed, 15 insertions(+), 9 deleti

Re: [PATCH] getdents: fix typos in array output

2015-11-18 Thread Gabriel Laskar
On Thu, 19 Nov 2015 02:54:12 +0300 "Dmitry V. Levin" <l...@altlinux.org> wrote: > On Thu, Nov 19, 2015 at 12:11:33AM +0100, Gabriel Laskar wrote: > > Array should be enclosed by square brakets, and elements should be > > separated by commas. > > >

[PATCH] getdents: fix typos in array output

2015-11-19 Thread Gabriel Laskar
Array should be enclosed by square brakets, and elements should be separated by commas. * dirent.c: fix typos in array output of getdents() * tests/getdents.awk: change test to fix typos * tests/getdents.out: output modified to match output Signed-off-by: Gabriel Laskar <gabr...@lse.epita

[PATCH] recvmsg: add support for IP_PKTINFO decoding

2015-11-19 Thread Gabriel Laskar
* net.c (printcmsghdr): add IP_PKTINFO decoding * xlat/sol_ip_vals.in: new file Signed-off-by: Gabriel Laskar <gabr...@lse.epita.fr> Suggested-by: Orion Poplawski <or...@cora.nwra.com> --- net.c | 11 +++ xlat/sol_ip_vals.in | 1 + 2 files changed, 12 insertion

Re: [PATCH v2 1/3] Add decoding for binder ioctls

2016-06-22 Thread Gabriel Laskar
BR_ACQUIRE_RESULT, > > > > BR_DEAD_REPLY, > > > > + BR_TRANSACTION_COMPLETE, > > > > BR_INCREFS, BR_ACQUIRE, > > > > + BR_RELEASE, BR_DECREFS, > > > >

Re: Update strace-graph to handle current strace output

2016-02-01 Thread Gabriel Laskar
in the graph > > strace-graph | 40 > 1 file changed, 28 insertions(+), 12 deletions(-) I don't really know perl, but this looks good to me. -- Gabriel Laskar -- Site24x7 APM Insight: Get Deep Visibil

[PATCH] Add configure --enable-check-coverage option

2016-02-01 Thread Gabriel Laskar
Signed-off-by: Gabriel Laskar <gabr...@lse.epita.fr> * configure.ac: enable AX_CODE_COVERAGE * Makefile.am: use AX_CODE_COVERAGE * m4/ax_code_coverage.m4: support for AX_CODE_COVERAGE * .gitignore: now ignore *.gcda and *.gcno files --- This patch add activation for gcov/lcov support. We c

GSOC Projects proposals

2016-02-18 Thread Gabriel Laskar
Hi, Here is my 2 projects proposal for GSOC 2016. Fault injection for syscalls Suggested by: Gabriel Laskar Strace is basically a big pattern matcher for syscalls. It is mainly used for diagnostics and debugging purpose. But it seems that with a code base like this we could do more. We receive

Re: Fault Injection in strace [GSOC 2016]. A sample implementation.

2016-03-08 Thread Gabriel Laskar
ls to be failed using the > newly implemented -g option. It seems to be working. > > Since it is not a patch, how should I share the code for everyone to > see. > Can't you give us a diff? -- Gabriel Laskar --

Re: [GSOC 2016] Netlink socket parsers

2016-03-06 Thread Gabriel Laskar
col before. There may be some work done on that point (retrieve the address family/type/protocol under a socket) but I am not sure about it. I hope this answers your interrogations, and helps you in order to crea

Re: GSOC 2016

2016-03-06 Thread Gabriel Laskar
contribution should also be a good idea. You can search the mailing list archives to see something that can be done. -- Gabriel Laskar -- ___ Strace-devel mailing list Strace

Re: GSOC 2016 - Comprehensive test suite Project

2016-03-02 Thread Gabriel Laskar
Hi, On Wed, 02 Mar 2016 22:53:44 +0300 Anchit Jain <mailingl...@anchitja.in> wrote: > I was hoping if anyone could please guide me and suggest material to > read/ issues to fix. You can start by sending a small fix, for example add a test for an untested syscall. -- Ga

Re: [GSoC 2016] Netlink socket parser

2016-03-07 Thread Gabriel Laskar
ould be great start." We need something like: * for starter a good way to have a structured output in strace (how do we specifiy all the parameters, what level of parsing we need, etc…) * a decent file format specification, that can work in most situations * and a good

Re: RFC userfaultfd ioctl decode

2016-04-21 Thread Gabriel Laskar
> + } else { > + /* copy also returns the number of > bytes > + * copied */ > + sprintf(auxbuf, "copy=%" PRId64, > + (int6

Re: We need a doc to guide new contributors patch submission [was: Re: Working on -e trace]

2016-04-29 Thread Gabriel Laskar
bmit the wiki page? Good idea, thanks! I guess, on the mailing, in order for everyone to be able to review it should be a good idea. -- Gabriel Laskar -- Find and fix application performance issues faster with Applicat

Re: [PATCH] Add netlink domain sockets support to socketutils

2016-05-13 Thread Gabriel Laskar
On Fri, 13 May 2016 12:02:37 + Fabien Siron <fabien.si...@epita.fr> wrote: > * socketutils.c: (print_sockeaddr_by_inode): Call netlink_print. > (netlink_send_query, netlink_parse_response, netlink_print): New > functions. > --- Looks good to me. Acked-by: Ga

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-07-29 Thread Gabriel Laskar
_syscall_enter): New function. > (fault_syscall_exit): Likewise. > (trace_syscall_entering): Discard syscall if needed. > (trace_syscall_exiting): Set syscall's return error value, print when > syscall > has been discarded. > > Signed-off-by: Nahim El Atmani <nahim+...@naa

Re: [PATCH 3/4] Introduce syscall fault injection feature

2016-07-29 Thread Gabriel Laskar
ed. > > (trace_syscall_exiting): Set syscall's return error value, print > > when syscall has been discarded. > > > > Signed-off-by: Nahim El Atmani <nahim+...@naam.me> > > Reviewed-By: Gabriel Laskar <gabr...@lse.epita.fr> > > --- > > * T

[PATCH] xattr: use printstr_ex instead of print_quoted_string

2016-12-22 Thread Gabriel Laskar
This fixes the display when using `-s` to limit the string size of the values displayed by {get,set}xattr. Signed-off-by: Gabriel Laskar <gabr...@lse.epita.fr> Reported-by: Марк Коренберг <socketp...@gmail.com> * xattr.c (print_xattr_val): use printstr_ex instead of print_quoted_st

[PATCH v2 2/2] tests: test for correct ellipsis with -s in xattr

2016-12-22 Thread Gabriel Laskar
* tests/xattr-strings.c: New file. * tests/xattr-strings.test: New test. * tests/.gitignore: Add xattr-string. * tests/Makefile.am (check_PROGRAMS): Likewise. (DECODER_TESTS): Add xattr-string.test. Signed-off-by: Gabriel Laskar <gabr...@lse.epita.fr> --- tests/.gitignore | 1 +

[PATCH v2 1/2] xattr: use printstr_ex instead of print_quoted_string

2016-12-22 Thread Gabriel Laskar
This fixes the display when using `-s` to limit the string size of the values displayed by {get,set}xattr. * xattr.c (print_xattr_val): use printstr_ex instead of print_quoted_string Reported-by: Марк Коренберг <socketp...@gmail.com> Signed-off-by: Gabriel Laskar <gabr...@lse