I think we can even remove it because there is no associated tld, so
no possibility to use it in a page.
This tag is very old and was developed to provide a better integration
between tiles and struts when tiles wasn't even in the contrib area.
This tag has no reason to be left now, unless
[EMAIL PROTECTED] wrote:
dgraham 2003/03/17 18:42:59
Modified:src/share/org/apache/struts/taglib/tiles InsertTag.java
Log:
Formatting changes only (in preparation of bug fix).
May I recall that the consensus is actually to not reformating classes ?
Check
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18095.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18095.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18095.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18096.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18096.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
[EMAIL PROTECTED] wrote:
dgraham 2003/03/17 18:46:02
Modified:src/share/org/apache/struts/taglib/tiles InsertTag.java
Log:
Only include page if it's != null.
Revision ChangesPath
1.14 +13 -5 jakarta-struts/src/share/org/apache/struts/taglib/tiles/InsertTag.java
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18094.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
husted 2003/03/18 02:50:31
Modified:doc/userGuide struts-html.xml
Log:
Apply fix per #17592 (Harvey van der Meer). Tag should support a naked collection
that is not a property of a bean.
Revision ChangesPath
1.54 +1 -1
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18096.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
husted 2003/03/18 03:17:34
Modified:doc using.xml
Log:
Apply update per #18095 (I-Shen Leong).
Revision ChangesPath
1.7 +2 -2 jakarta-struts/doc/using.xml
Index: using.xml
===
RCS
OK, we're back down to two. =:0)
http://issues.apache.org/bugzilla/show_bug.cgi?id=17562
Cedric, I can't quite follow the thread on this one myself. Does it look
like Redding's patch would help (at least for now). Lavy seems to say it
doesn't work for him.
Personally, I would say that volunteering to actively maintain a piece
of code and creating a bug fix is not reformatting for the sake of
reformatting. It is apply the established code conventions to help with
fixing an implementation issue.
The code should have observed the style of Craig's
husted 2003/03/18 03:38:46
Modified:doc/resources books.xml
Log:
Add new Wrox book on Struts, et al.
Revision ChangesPath
1.19 +14 -1 jakarta-struts/doc/resources/books.xml
Index: books.xml
husted 2003/03/18 03:39:14
Modified:doc index.xml
Log:
And then there were six.
Revision ChangesPath
1.43 +11 -1 jakarta-struts/doc/index.xml
Index: index.xml
===
RCS file:
husted 2003/03/18 03:40:53
Modified:doc status.xml
Log:
Routine update.
Revision ChangesPath
1.29 +2 -2 jakarta-struts/doc/status.xml
Index: status.xml
===
RCS file:
husted 2003/03/18 03:43:38
Added: doc/images/books 1861007817.jpg
Log:
Image for Struts Apps book.
Revision ChangesPath
1.1 jakarta-struts/doc/images/books/1861007817.jpg
Binary file
Ted Husted wrote:
Personally, I would say that volunteering to actively maintain a piece
of code and creating a bug fix is not reformatting for the sake of
reformatting. It is apply the established code conventions to help
with fixing an implementation issue.
The code should have observed
arron 2003/03/18 04:50:37
Modified:doc/userGuide struts-nested.xml
Log:
Changed the nested:define's tei class to reference a new
custom tei class for the nested tags.
Revision ChangesPath
1.17 +1 -1 jakarta-struts/doc/userGuide/struts-nested.xml
Index:
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18066.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
arron 2003/03/18 05:20:04
Added: src/share/org/apache/struts/taglib/nested/bean
NestedDefineTei.java
Log:
Initial commit.
Revision ChangesPath
1.1
[...cut...]
http://issues.apache.org/bugzilla/show_bug.cgi?id=18066
Arron (or Antoni). Does it seem like there would be an easy patch
here? Would specifying the type be a reasonable workaround? -- at
least until we can fix it properly in the next iteration.
If we can swat these two, we
Ted Husted wrote:
OK, we're back down to two. =:0)
http://issues.apache.org/bugzilla/show_bug.cgi?id=17562
Cedric, I can't quite follow the thread on this one myself. Does it
look like Redding's patch would help (at least for now). Lavy seems to
say it doesn't work for him.
I have to do
Cedric,
Here's the problem as I understand it:
To extend a definition you must declare all the attributes in the parent
definition even if they're set to , right?
So, only in WAS 5 when I try tile:insert I get an error. The attribute is
defined, it's just set to . So, it's burdensome to use
The bottom line on this issue is that we already have a standard, the Sun
Java coding conventions documented here:
http://java.sun.com/docs/codeconv/
When modifying code it is our responsibility to ensure that it meets these
standards.
David
Personally, I would say that volunteering to
dgraham 2003/03/18 07:04:42
Modified:src/share/org/apache/struts/taglib/tiles InsertTag.java
Log:
Remove page check before including for more investigation.
Revision ChangesPath
1.15 +7 -6
jakarta-struts/src/share/org/apache/struts/taglib/tiles/InsertTag.java
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17823.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18066.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18107.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11852.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11852.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
Well, not all plugins read xml files so it would be inappropriate to supply
it as a base implementation. However, it may be useful to distribute it as
an optional plugin that an app can use. Post an enhancement request with
your code for people to review.
David
From: Joe Germuska [EMAIL
I disagree with you, we don't have a standard. Just take a look to the
code (not mine, Craig's one ;-) and you will see that we originally
don't follow completely the Sun standard.
We follow it for several important things like naming convention and
javadoc. We don't follow it for the
David Graham wrote:
Cedric,
Here's the problem as I understand it:
To extend a definition you must declare all the attributes in the
parent definition even if they're set to , right?
No. The parent definition only declare the attributes relevant to the
parent. A child (extending a parent)
I disagree with you, we don't have a standard.
Every Jakarta project explicitly follows the Sun standard guidelines unless
listed here:
http://jakarta.apache.org/site/faqs.html
Struts follows the Sun guidelines and it is our responsibility to ensure the
code is consistent or be in violation of
No. The parent definition only declare the attributes relevant to the
parent. A child (extending a parent) can add some new attributes.
If an attribute is not used in a parent, you don't need to declare it.
In your case, the attribute is used by the associated layout, but you
want the layout
+1
Adopting a coding convention is part and parcel of being a ASF product.
If a Jakarta product doesn't choose one, Sun is the default. It's been
that way from the beginning.
It's true that we have been lax in the past. (Jakarta products have been
lax about a lot of things.)
Moving forward,
I've been tagging the resolved laters for the unknown build and then
indicating a milestone.
This gets them off the list of things we need to handle for the current
iteration, but does not force us to go through the red tape of
reopening it later.
-T.
[EMAIL PROTECTED] wrote:
DO NOT REPLY TO
We could just put it in the Actions package, like the DispatchAction and
such. If a few more crop up, we could start a PlugIns package.
-T.
David Graham wrote:
Well, not all plugins read xml files so it would be inappropriate to
supply it as a base implementation. However, it may be useful to
There's already a .plugins package that we can put it in if adopted.
David
From: Ted Husted [EMAIL PROTECTED]
Reply-To: Struts Developers List [EMAIL PROTECTED]
To: Struts Developers List [EMAIL PROTECTED]
Subject: Re: Base PlugIn implementation?
Date: Tue, 18 Mar 2003 13:11:42 -0500
We could
Traditionally, people have setup a web page describing the enhancement,
that we could link from the Resource pages. If it gets talked about
enough on the lists, it eventually finds its way into the distribution.
Another way to go might be to extend the sample validator application
already in
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17306.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17306.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18107.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18111.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
The idea is that we want to start slating tickets for different families
and milestones. If your'e interested in bugs against the Nightly Build
or RC1 (and prior), then select everything but unknown.
[NOT RESOLVED, NOT CLOSED, STRUTS, NOT UNKNOWN].
Ted Husted [EMAIL PROTECTED] wrote in message
news:[EMAIL PROTECTED]
I've been tagging the resolved laters for the unknown build and then
indicating a milestone.
The problem with this is that we don't know what version it was reported
against, and therefore don't know what version to attempt
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18123.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
Ted Husted [EMAIL PROTECTED] wrote in message
news:[EMAIL PROTECTED]
snip/
If we can swat these two, we might be able to roll out RC2.
I've been somewhat absent from here for a while, primarily because I'm
working on getting FileUpload into shape. In the process of addressing a
couple of
+1
I'll try to keep toeing the line on the new Bugzilla tickets [with
David's help I'm sure :0)], so it will be ready to roll when you are.
I'm quite glad we're making such progress with Fileupload, since that
has been a troublesome component in the past.
-T.
Martin Cooper wrote:
Ted Husted
Why not just go to RC1 instead of beta 2?
On a related topic, it looks like Validator has cleared all the bugs for a
1.0.2 release. I think we could release Struts 1.1 RC2 before any final
releases of FileUpload and Validator just to see what bugs (if any) get
reported on those components.
This is mainly for enhancement requests, not outstanding problems we can
fix now with a submitted patch.
When there is a patch that we could use later, I am noting the version
referenced in the comments field and adding the patch keyword.
-T.
Martin Cooper wrote:
Ted Husted [EMAIL
Hello,
I am using tiles:insert tag inside logic:iterate tag with struts 1.1rc1
release. It renders output incorrectly only in following scenario.
logic:iterate id=aname name=list type=java.lang.String
TABLE valign=top
tiles:insert name=%=aname% flush=false/
/TABLE
/logic:iterate
It
There's a bug report regrading this problem. If you can, download the
patch and see if it helps.
http://issues.apache.org/bugzilla/show_bug.cgi?id=17562
Greg
On Tue, 2003-03-18 at 16:10, Anand Joshi wrote:
Hello,
I am using tiles:insert tag inside logic:iterate tag with struts 1.1rc1
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18127.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18127.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
David Graham [EMAIL PROTECTED] wrote in message
news:[EMAIL PROTECTED]
Why not just go to RC1 instead of beta 2?
The problem is that some methods need to be removed before 1.0 Final. If the
next milestone is RC1, then the methods need to be removed immediately,
otherwise it's not a true release
dgraham 2003/03/18 20:49:04
Modified:doc/userGuide dev_validator.xml
Log:
Remove duplicate example.
Revision ChangesPath
1.29 +0 -15 jakarta-struts/doc/userGuide/dev_validator.xml
Index: dev_validator.xml
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18123.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
dmkarr 2003/03/18 20:53:24
Modified:contrib/struts-el/doc/userGuide struts-html-el.xml
Log:
making property attribute of optionsCollection tag be not required, to
match same change made for #17592 in base tag.
Revision ChangesPath
1.17 +1 -1
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17592.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
noshade=/
--
+h3a name=20030318/a18 Mar 2003 - Struts-Faces Integration Library
Available/h3
+
+p
+ The emStruts-Faces Integration Library/em is an add-on library
+ that supports the use of
+ a href=http://java.sun.com/j2ee/javaserverfaces/;JavaServer Faces
63 matches
Mail list logo
