RE: Tags more extensible (was: Suggestions for Calendar Popup tag lib?)

2003-08-19 Thread John Jefferson
s close as > possible). > > Edgar > > > -Original Message- > > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] > > Sent: Tuesday, August 19, 2003 7:06 AM > > To: '[EMAIL PROTECTED]'; > '[EMAIL PROTECTED]' > > Subject: RE: T

RE: Tags more extensible (was: Suggestions for Calendar Popup tag lib?)

2003-08-19 Thread Edgar Dollin
-Original Message- > From: David Graham [mailto:[EMAIL PROTECTED] > Sent: Tuesday, August 19, 2003 01:00 > To: Struts Developers List > Subject: RE: Tags more extensible (was: Suggestions for > Calendar Popup tag lib?) > > > --- Edgar Dollin <[EMAIL PROTECTED]>

RE: Tags more extensible (was: Suggestions for Calendar Popup tag lib?)

2003-08-19 Thread Shai.Berger
extensible (was: Suggestions for Calendar Popup tag lib?) --- Edgar Dollin <[EMAIL PROTECTED]> wrote: > Exactly some of the problems I have been having with the tags as they > currently exist. The best thing to do is to open a bugzilla enhancement request with *specific* tags and met

RE: Tags more extensible (was: Suggestions for Calendar Popup tag lib?)

2003-08-18 Thread Edgar Dollin
Original Message- From: David Graham [mailto:[EMAIL PROTECTED] Sent: Monday, August 18, 2003 6:00 PM To: 'Struts Developers List' Subject: RE: Tags more extensible (was: Suggestions for Calendar Popup tag lib?) --- Edgar Dollin <[EMAIL PROTECTED]> wrote: > Exactly some of

Re: Tags more extensible (was: Suggestions for Calendar Popup tag lib?)

2003-08-18 Thread David Graham
> I agree *iff* we're careful about the way it's done. Some of the method > calls will probably go away anyway if the code is automatically inlined, > so > I don't believe method invocation would be the issue. > > However, looking at FormTag right now, I see several methods that build > up > strin

Re: Tags more extensible (was: Suggestions for Calendar Popup tag lib?)

2003-08-18 Thread Martin Cooper
"Robert Leland" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Replyied Inline. > > Paananen, Tero wrote: > > >[this is in response to Robert Leland's reply to my > > post on the struts-user list griping about the > > (un)extensibility of custom tags] > > > > > > > >>>My #1 pet peev

RE: Tags more extensible (was: Suggestions for Calendar Popup tag lib?)

2003-08-18 Thread David Graham
evant to the current state of the tags. David > > Edgar > > -Original Message- > From: Paananen, Tero [mailto:[EMAIL PROTECTED] > Sent: Monday, August 18, 2003 5:42 PM > To: 'Struts Developers List' > Subject: RE: Tags more extensible (was: Suggestio

RE: Tags more extensible (was: Suggestions for Calendar Popup tag lib?)

2003-08-18 Thread Edgar Dollin
Exactly some of the problems I have been having with the tags as they currently exist. Edgar -Original Message- From: Paananen, Tero [mailto:[EMAIL PROTECTED] Sent: Monday, August 18, 2003 5:42 PM To: 'Struts Developers List' Subject: RE: Tags more extensible (was: Sugge

RE: Tags more extensible (was: Suggestions for Calendar Popup tag lib?)

2003-08-18 Thread Paananen, Tero
> I agree totally, at the level were currenrly arguing, > I dare anyone to disagree ! > > A good way to tackle this is Use Case by Use Case, to > avoid talking in general terms. > > 1) What specific tags have you or do you want to modify the > behaviour of. Well, this is the thing...how would I

Re: Tags more extensible (was: Suggestions for Calendar Popup tag lib?)

2003-08-18 Thread David Graham
> A good way to tackle this is Use Case by Use Case, to avoid talking in > general terms. +1 There's no way to factor the tags properly without a specific use case to guide us. David > 1) What specific tags have you or do you want to modify the behaviour > of. > 2) What level of granularity ma

RE: Tags more extensible (was: Suggestions for Calendar Popup tag lib?)

2003-08-18 Thread David Graham
--- "Paananen, Tero" <[EMAIL PROTECTED]> wrote: > > > From what I've seen most custom tags seem to have been > > > implemented as one big doStartTag() or doEndTag(). The > > > entire implementation of the tag is in that one method. > > > > I have worked to move most of the code out of doStartTag()

RE: Tags more extensible (was: Suggestions for Calendar Popup tag lib?)

2003-08-18 Thread Paananen, Tero
> > From what I've seen most custom tags seem to have been > > implemented as one big doStartTag() or doEndTag(). The > > entire implementation of the tag is in that one method. > > I have worked to move most of the code out of doStartTag() > and doEndTag() for many tags. My pattern has been to

Re: Tags more extensible (was: Suggestions for Calendar Popup tag lib?)

2003-08-18 Thread David Graham
> From what I've seen most custom tags seem to have been > implemented as one big doStartTag() or doEndTag(). The > entire implementation of the tag is in that one method. I have worked to move most of the code out of doStartTag() and doEndTag() for many tags. My pattern has been to have a "rende