Re: [PATCH] Beta 1.3 pulls tag values from wrong bean

2003-01-04 Thread Ted Husted
The general Bugzilla page is wrong in our case (been meaning to fix that). We prefer that patches be attached to Bugzilla issues so that they dont' get buried on the list =:0) -Ted. David Morris wrote: I located the source of the problem, which is caused by a change to the nested tags. The

Re: Proposed: logic:else clause

2003-01-04 Thread Ted Husted
If you wrote a patch and it worked, there'd be no technical reason to veto it. But since it is a straight-line convenience enhancement, it would have to wait for Struts 1.2.x. The general feeling has been, as others have expressed, that it would be better to put development effort into

Modules and path mapping (/do/*)

2003-01-04 Thread Matt Raible
I decided to try to get modules to work with path-mapping tonight with no luck. I'll enter this into Bugzilla if you'd like. Basically, I have a forward that switches to the module: With extension mapping: forward name=uploadResume contextRelative=true path=/upload/index.do

RE: Modules and path mapping (/do/*)

2003-01-04 Thread James Mitchell
http://www.mail-archive.com/struts-dev@jakarta.apache.org/msg11133.html http://www.mail-archive.com/struts-user@jakarta.apache.org/msg35941.html -- James Mitchell Software Engineer/Open Source Evangelist http://www.open-tools.org C makes it easy to shoot yourself in the foot; C++ makes it

DO NOT REPLY [Bug 15799] New: - Nested tags picks up wrong bean for values

2003-01-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15799. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

Comment RE: Bug 11932

2003-01-04 Thread Charles Fineman
I was poking around the comments for this bug when I noticed the following passage: This method no longer deals with message resources. In 1.1 b2 it puts the correct message resource for a sub-app in the request. However, it was not dealing with possible bundle keys. Is there a benifit that

Another bright idea, make indexed work with JSTL forEach and friends

2003-01-04 Thread James Turner
As has been pointed out, about the only remaining reason to use logic:iterate over c:forEach is that you can't use an html:text tag (or friends) with an indexed property set, because it only looks for logic:iterate on the page stack. Now, it would be very simple (having peered at the source) to

Re: Another bright idea, make indexed work with JSTL forEach andfriends

2003-01-04 Thread Craig R. McClanahan
On Sat, 4 Jan 2003, James Turner wrote: Date: Sat, 4 Jan 2003 13:26:34 -0500 From: James Turner [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Another bright idea, make indexed work with JSTL forEach and friends As has been

Re: Another bright idea, make indexed work with JSTL forEach and friends

2003-01-04 Thread David M. Karr
Craig == Craig R McClanahan [EMAIL PROTECTED] writes: Craig On Sat, 4 Jan 2003, James Turner wrote: Date: Sat, 4 Jan 2003 13:26:34 -0500 From: James Turner [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Another

Re: Another bright idea, make indexed work with JSTL forEach andfriends

2003-01-04 Thread Martin Cooper
On Sat, 4 Jan 2003, James Turner wrote: As has been pointed out, about the only remaining reason to use logic:iterate over c:forEach is that you can't use an html:text tag (or friends) with an indexed property set, because it only looks for logic:iterate on the page stack. Now, it would

Message Resource is not multi-app aware (was: Comment RE: Bug 11932)

2003-01-04 Thread Charles Fineman
[ Forgive the re-post I wanted to give this a more meaningfull subject. ] I was poking around the comments for this bug when I noticed the following passage: This method no longer deals with message resources. In 1.1 b2 it puts the correct message resource for a sub-app in the request.

RE: Another bright idea, make indexed work with JSTL forEach and friends

2003-01-04 Thread James Turner
On Sat, 4 Jan 2003, Martin Cooper wrote: If you want to do this, I'd rather see it happen in the html-el taglib than the regular html taglib. Struts-EL already depends on JSTL, and is designed to work in cooperation with it, so it's a much more natural fit than trying to sneak JSTL

Re: Modules and path mapping (/do/*)

2003-01-04 Thread Ted Husted
Something I've been meaning to try is to actual define the module as /do/$MODULE, but I don't have any open projects that use modules to try this with =:( -T. Matt Raible wrote: I decided to try to get modules to work with path-mapping tonight with no luck. I'll enter this into Bugzilla if

Tag Elimination

2003-01-04 Thread Edgar P. Dollin
The html tags are useful struts tags in a standard browser environment. The nested iterators, since they iteract nicely with html tags, seem more straight forward to use than the equivalent JSTL. If you are already iterating using the nested taglib, the nested logic tags are again more

Re: Another bright idea, make indexed work with JSTL forEach and friends

2003-01-04 Thread David M. Karr
James == James Turner [EMAIL PROTECTED] writes: James On Sat, 4 Jan 2003, Martin Cooper wrote: If you want to do this, I'd rather see it happen in the html-el taglib than the regular html taglib. Struts-EL already depends on JSTL, and is designed to work in cooperation

Re: Another bright idea, make indexed work with JSTL forEach andfriends

2003-01-04 Thread Craig R. McClanahan
On 4 Jan 2003, David M. Karr wrote: Can anyone envision any other situations in the Struts code where indirect references to the JSTL would be convenient? That, at least, could give us some additional perspective on this. General purpose access to the EL evaluator (which David used in

RE: Another bright idea, make indexed work with JSTL forEach andfriends

2003-01-04 Thread Martin Cooper
On Sat, 4 Jan 2003, James Turner wrote: On Sat, 4 Jan 2003, Martin Cooper wrote: If you want to do this, I'd rather see it happen in the html-el taglib than the regular html taglib. Struts-EL already depends on JSTL, and is designed to work in cooperation with it, so it's a much more

cvs commit: jakarta-struts/doc/resources powered.xml

2003-01-04 Thread martinc
martinc 2003/01/04 14:15:10 Modified:.build.xml doc/resources powered.xml Log: Add Benefit Systems to the Powered By page. PR: 15753 Submitted by: James Turner Revision ChangesPath 1.89 +25 -0 jakarta-struts/build.xml Index:

DO NOT REPLY [Bug 15753] - Add powered by entry

2003-01-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15753. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

cvs commit: jakarta-struts build.xml

2003-01-04 Thread martinc
martinc 2003/01/04 14:22:24 Modified:.build.xml Log: Whoops! Didn't mean to check in that change to build.xml... Revision ChangesPath 1.90 +0 -25 jakarta-struts/build.xml Index: build.xml

RE: Another bright idea, make indexed work with JSTL forEach and friends

2003-01-04 Thread James Turner
Ok, here's a more practical reason to do it in the base release... The Struts-EL package doesn't handle the indexed tag at all, it relies on the fact that it extends the org.apache.struts.taglib.html versions of the tags which in turn eventually extend BaseHandlerTag. So, to implement it in

Re: Struts Action Chaining

2003-01-04 Thread Karl Baum
There is a new URL for my Struts Action Chaining package. http://www.strutschaining.org/ Thanks for all of your feedback! Karl - Original Message - From: Karl Baum [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Sent: Monday, December 30, 2002 11:07 PM Subject: Struts

cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/logic MessagesPresentTag.java

2003-01-04 Thread martinc
martinc 2003/01/04 16:40:04 Modified:src/share/org/apache/struts/config ConfigHelperInterface.java src/share/org/apache/struts/taglib/bean MessageTag.java src/share/org/apache/struts/taglib/html FormTag.java

Re: Proposed: logic:else clause

2003-01-04 Thread David Graham
It looks like you're a committer now (congratulations!) so you could do this if you wanted. I think it's a waste of time because you can just use the JSTL. Dave From: James Turner [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject:

RE: Proposed: logic:else clause

2003-01-04 Thread James Turner
I think I'll pass, I've decided to make the (Struts) world safe for JSTL instead. :-) James -Original Message- From: David Graham [mailto:[EMAIL PROTECTED]] Sent: Saturday, January 04, 2003 8:03 PM To: [EMAIL PROTECTED] Subject: Re: Proposed: logic:else clause It looks like

RE: Another bright idea, make indexed work with JSTL forEach andfriends

2003-01-04 Thread Martin Cooper
On Sat, 4 Jan 2003, James Turner wrote: Ok, here's a more practical reason to do it in the base release... The Struts-EL package doesn't handle the indexed tag at all, it relies on the fact that it extends the org.apache.struts.taglib.html versions of the tags which in turn eventually

cvs commit: jakarta-struts/src/share/org/apache/struts/tiles/actions NoOpAction.java ReloadDefinitionsAction.java ViewDefinitionsAction.java

2003-01-04 Thread martinc
martinc 2003/01/04 17:24:48 Modified:src/share/org/apache/struts/tiles ActionComponentServlet.java ActionController.java ComponentDefinitionsFactory.java DefinitionAttribute.java

RE: Another bright idea, make indexed work with JSTL forEach and friends

2003-01-04 Thread James Turner
From: Martin Cooper [mailto:[EMAIL PROTECTED]] Sigh. OK, OK. But three changes I'd like to see in the code you posted earlier: 1) Instead of calling Class.forName(), you should use RequestUtils.applicationClass(), to make sure the context class loader is tried first. I'll do dat.

cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/html BaseHandlerTag.java

2003-01-04 Thread martinc
martinc 2003/01/04 17:40:44 Modified:src/share/org/apache/struts/taglib/html BaseHandlerTag.java Log: Ack! Fix one more (newly added!) unused import. Revision ChangesPath 1.22 +4 -5 jakarta-struts/src/share/org/apache/struts/taglib/html/BaseHandlerTag.java

RE: Another bright idea, make indexed work with JSTL forEach andfriends

2003-01-04 Thread Martin Cooper
On Sat, 4 Jan 2003, James Turner wrote: From: Martin Cooper [mailto:[EMAIL PROTECTED]] Sigh. OK, OK. But three changes I'd like to see in the code you posted earlier: 1) Instead of calling Class.forName(), you should use RequestUtils.applicationClass(), to make sure the context

cvs commit: jakarta-struts build.properties.sample build.xml

2003-01-04 Thread martinc
martinc 2003/01/04 18:48:22 Modified:.build.properties.sample build.xml Log: Add new tasks for running Checkstyle and PMD, if available. If the tools are not available, the tasks do nothing. Revision ChangesPath 1.24 +12 -1

Re: Struts commit access

2003-01-04 Thread Craig R. McClanahan
Karma granted. Welcome aboard James! Craig On Sat, 4 Jan 2003, James Turner wrote: Date: Sat, 4 Jan 2003 18:42:59 -0500 From: James Turner [EMAIL PROTECTED] Reply-To: Jakarta Project Management Committee List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Struts commit access

Re: Another bright idea, make indexed work with JSTL forEach andfriends

2003-01-04 Thread Craig R. McClanahan
On 4 Jan 2003, David M. Karr wrote: Date: 04 Jan 2003 17:28:58 -0800 From: David M. Karr [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Re: Another bright idea, make indexed work with JSTL forEach and friends Craig == Craig R

Struts Version 2 Proposal - Workflow and extra

2003-01-04 Thread paul.t.smith
Dear Struts Commiters, I know that the current focus is on finalizing Struts 1.1, but I would like to propose a design for version 2.0. I have taken the commons-workflow package and built on top of it a package which I have been calling PageFlow. The modifications Ive made basically webify the

2.0 Proposal example config files

2003-01-04 Thread paul.t.smith
I didnt include any example configuration files in my previous post and I thought they might help. These are from the working prototype. I also didnt mention the error handling which Ive added recently. The error handling is very powerful and allows the developer to use an "action" made up

RE: Struts commit access

2003-01-04 Thread James Turner
-Original Message- From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]] Sent: Saturday, January 04, 2003 10:19 PM To: Jakarta Project Management Committee List Cc: [EMAIL PROTECTED] Subject: Re: Struts commit access Karma granted. Welcome aboard James! Craig Pulling a

DO NOT REPLY [Bug 15805] New: - Enhance ModuleException to allow getting chained Exceptions

2003-01-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15805. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

DO NOT REPLY [Bug 15805] - Enhance ModuleException to allow getting chained Exceptions

2003-01-04 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15805. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.

New PMD and Checkstyle tasks

2003-01-04 Thread Martin Cooper
I've added two new tasks to the main build.xml file to allow us to easily run PMD and Checkstyle on the entire src/share source tree. Even if you don't know what these tools are, read on. PMD --- PMD is a Java source code analyzer which can detect many, many different kinds of problems,

Re: Jelly actions (was Re: Another bright idea, make indexed workwith JSTL forEach and friends)

2003-01-04 Thread Martin Cooper
On Sat, 4 Jan 2003, Craig R. McClanahan wrote: Longer term (2.0 time frame probably), I'm playing with more interesting ideas like using Jelly scripts (or JSP pages) as Actions so you don't have to write them in Java. We also need a good high level multi-request framework, and it might be