RE: DO NOT REPLY [Bug 8138] New: - The synchronized keyword is used too early in the processActionCreate() method of the RequestProcessor class

This would be an imprecise use of synchronization for the HashMap. The atomic set of operations that needs synchronized is: 1. Lookup 2. If there, return 3. If not, create and add new one Without synchronization around that entire set of operations, there is a race condition when two threads get

RE: The synchronized keyword is used too early in the processActionCreate() method of the RequestProcessor class

See below. > > You mentioned that the three steps are atomic. To me, atomic means that > they all succeed or the operation set fails. I don't think this > is the case > here. If the lookup finds an action, the other operations are not > executed. > To me, the atomic part is, if the action is not

RE: 1.1 new build needs setter for every getter?

One more thing on this - a while back we had an issue along these lines using the IBM JDK for AIX where it wouldn't find a read property if the type for the set didn't match the type for the get. Sun's JDK on Windows did find the read property in the same situation. I was able to create a nice, s

Struts extensibility, multiple servlets, etc. (cont.)

Folks, I know I'm jumping in late here, so please forgive me if I'm rehashing too much old material, stepping on toes, etc. I've spent the last day or so spelunking much of the ActionServlet and related code with an eye toward extensibility. My motivation is adapting/extending Struts, preferably

RE: Struts extensibility, multiple servlets, etc. (cont.)

Ted, Thanks for responding. >>I think we'd all be happy to see better support for Velocity, and other templating mechanisms. Geir did some work along these lines last spring.<< I've seen this work, and we're having related conversations on velocity-user now. >>Forwarding and redirecting is how

RE: Struts extensibility, multiple servlets, etc. (cont.)

Ted, Again, I appreciate the response(s). >> In what way would you like them to act on themselves? Initially, the ActionForward is a way to give a URI a logical name. The ActionServlet asks for a path, and it is given a path in return. Of course, how that path is generated is the ActionForward's

RE: Multiple controller servlets

>>I'm just thinking that many of the components that we use may have wider user, and we should avoid binding things to the ActionServlet class. << I agree strongly with this. Nearly all of the collections, maps, etc. which are initialized by and accessed via the ActionServlet should instead be a

Problems building from source

Folks, My apologies if this has been addressed recently. The most relevant messages for it seemed to be from February this year, so I'm bringing it up again. I retrieved the source, tip revisions, from CVS and attempted to build. I created a build.properties as indicated; and I haven't had any p

RE: Problems building from source

Martin, Re: the prerequisites page - I was looking at the instructions in build.properties.sample and build.xml. Those things weren't listed in there. I guess I'd have expected a comment in the .sample file to create a property like "xalan.home=". So, I guess I'm suggesting that prerequisites be

FW: Opinion on design ideas???

e to a JavaBean, and any Java technology can access a JavaBean, if only to expose it through another interface. Objects like an ActionForm, MessageResource, or ActionMapping have no idea who's accessing them. Struts "pipeline" enhancement Donnie Hale 01 Dec 2001

RE: Multiple controller servlets

Re: double-check locking - it's definitely not safe following the normal pattern in Java. There are some esoteric workarounds which use ThreadLocal, but until the Java Memory Management JSR gets rolling, accepted, and implemented; that's the way it is. The easiest fix is just to move a single lock

RE: Multiple controller servlets

make sense, all those method names would need changed. Is that right? Any other input? Thanks, Donnie -Original Message- From: Ted Husted [mailto:[EMAIL PROTECTED]] Sent: Monday, December 03, 2001 7:04 AM To: Struts Developers List Subject: Re: Multiple controller servlets Do

RE: Multiple controller servlets

List Subject: Re: Multiple controller servlets Donnie Hale wrote: > Re: the proposed interface - I'd like to see one, perhaps a base interface > for what you're proposing, which has access to everything for which the > current request isn't needed. And that's most

RE: Multiple controller servlets

ticket on ActionServlet would be to refactor those nasty process* methods into a coherent helper object. Donnie Hale wrote: > > Ted, > > There are a number of public methods on ActionServlet right now like: > > addDataSource > addFormBean > addForward > addMapping > > Some

RE: Struts & Filters (Servlets 2.3)

Craig, Could you briefly enumerate the advantages a filter would have over a servlet for what ActionServlet *currently* does? I can see how it would be useful for certain new features, and I can see how the context lifecycle events would be nice to monitor; but I'm not sure I see what a filter bu

RE: [Design Discussion] Multiple Controllers Per Web App

> -Original Message- > From: Ted Husted [mailto:[EMAIL PROTECTED]] > Sent: Wednesday, December 26, 2001 11:26 PM > To: Struts Developers List > Subject: Re: [Design Discussion] Multiple Controllers Per Web App > > > +1 overall. > > Very much one of those brilliant ideas that only seem ob

RE: [Design Discussion] Multiple Controllers Per Web App

> > (Ted's absolutely right - we need a better name than "application" for > this thing :-). > True, but let's not use the "let" suffix yet again. Anything but that. :) Donnie -- To unsubscribe, e-mail: For additional commands, e-mail:

RE: [Design Discussion] Multiple Controllers Per Web App

:07 PM > To: Struts Developers List > Subject: RE: [Design Discussion] Multiple Controllers Per Web App > > > It's a "Strutlet". > > Bryan > > > > On Thu, 2001-12-27 at 20:52, Craig R. McClanahan wrote: > > On Thu, 27 Dec 2001, Do

RE: Forced URL rewriting

Craig, I think the point is that WebLogic meets the spec criteria but, for the application in question it was decided to turn off cookie-less support via URL rewriting. Thus users of the application must have cookies enabled. That doesn't reflect at all on the container's spec compliance, just th

RE: Forced URL rewriting

ject: RE: Forced URL rewriting > > > > > On Fri, 4 Jan 2002, Donnie Hale wrote: > > > Date: Fri, 4 Jan 2002 19:49:30 -0500 > > From: Donnie Hale <[EMAIL PROTECTED]> > > Reply-To: Struts Developers List <[EMAIL PROTECTED]> > > To: Struts Dev

RE: AspectJ and Struts Exception handling:

I just posted a message to commons about aspectj. :) Very, very cool stuff+ACE- What I'd like to see next from that arena is the ability to define pointcuts and aspects dynamically rather than with a recompile. Donnie +AD4- -Original Message- +AD4- From: Nicholas Lesiecki +AFs-mailto:

RE: The BIG Check-In for Multi-App Support

I've finally had a chance to download this check-in. Please note that while I've built it, I haven't yet had a chance to test it with anything. Are there any examples yet which include all these new features (exceptions, roles, multi-apps, etc.)? There's a lot get one's arms around. Most importan

RE: Bad classloading, why does Struts continue to use Class.forName()?

Craig, I thought the context classloader was defined to be the same as the loader you'd get via "class.forName" if the context classloader had not otherwise been explicitly set. From the javadocs for getContextClassLoader: Returns the context ClassLoader for this Thread.

RE: The BIG Check-In for Multi-App Support

Craig, Thanks for the detailed reply. See below. [snip[ > > > > 1. I don't know if this is carved in stone yet, but IMHO this > is much more > > than a 1.1 release. Perhaps not a 2.0 release, but at least a > 1.5 release. > > The implications of a single point release to me are minor functional

RE: Bad classloading, why does Struts continue to use Class.forName()?

One other thought. Perhaps a utility method should be added (where?) that the various Struts classes would use when needing either a new Class instance or a new instance for a given Class. Donnie > -Original Message- > From: Donnie Hale [mailto:[EMAIL PROTECTED]] > Sent

RE: Throwing exceptions from within Struts tags

I took advantage just this week of an exception being saved via saveException. A place higher in the Struts call stack had turned the exception into a "return null", so I couldn't tell why that was happening until I pulled the exception out of the context and dumped its stack trace. FWIW... Donn