Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:fix_getaddrinfo_for_v6_only into maas:master

2023-06-07 Thread Christian Grabowski
jenkins: !tests -- https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/443923 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:fix_getaddrinfo_for_v6_only into maas:master

2023-06-06 Thread Christian Grabowski
> +1 > > PS: do you have the upstream bug id? if so, add a reference to the TODO in > safe_getaddrinfo() Ah good point, will do -- https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/443923 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list:

Re: [Sts-sponsors] [Merge] ~alexsander-souza/maas:lp2022833_fix_machine_hints into maas:master

2023-06-05 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~alexsander-souza/maas/+git/maas/+merge/444074 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

[Sts-sponsors] [Merge] ~cgrabowski/maas-ci/+git/system-tests:add_dns_tests into ~maas-committers/maas-ci/+git/system-tests:master

2023-06-02 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas-ci/+git/system-tests:add_dns_tests into ~maas-committers/maas-ci/+git/system-tests:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cgrabowski/maas-ci/+git/system-tests/+merge/443618 -- Your

Re: [Sts-sponsors] [Merge] ~troyanov/maas:zerologlint into maas:master

2023-06-02 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/444029 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

Re: [Sts-sponsors] [Merge] ~alexsander-souza/maas:lp1996204_fix_prometheus_labels into maas:master

2023-06-01 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~alexsander-souza/maas/+git/maas/+merge/443916 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

[Sts-sponsors] [Merge] ~cgrabowski/maas:fix_getaddrinfo_for_v6_only into maas:master

2023-05-31 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas:fix_getaddrinfo_for_v6_only into maas:master. Commit message: use a higher level resolver when stack is v6 only Requested reviews: MAAS Maintainers (maas-maintainers) Related bugs: Bug #2020142 in MAAS: "commission fails if

Re: [Sts-sponsors] [Merge] ~alexsander-souza/maas-ci/+git/maas-ci-internal:use_proxy into ~maas-committers/maas-ci/+git/maas-ci-internal:main

2023-05-30 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~alexsander-souza/maas-ci/+git/maas-ci-internal/+merge/443826 Your team MAAS Committers is subscribed to branch ~maas-committers/maas-ci/+git/maas-ci-internal:main. -- Mailing list: https://launchpad.net/~sts-sponsors Post to :

[Sts-sponsors] [Merge] ~cgrabowski/maas-ci/+git/system-tests:add_dns_tests into ~maas-committers/maas-ci/+git/system-tests:master

2023-05-25 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas-ci/+git/system-tests:add_dns_tests into ~maas-committers/maas-ci/+git/system-tests:master. Commit message: fix fqdn comparison add marker to pyproject.toml fix passing args to Go bin add pytests for DNS tests add dnstester Go code

Re: [Sts-sponsors] [Merge] ~troyanov/maas:tags-with-kernel-opts-metrics into maas:master

2023-05-24 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/443507 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

[Sts-sponsors] [Merge] ~cgrabowski/maas-ci/+git/maas-ci-config:fix_ansible_collections_permissions_issue into ~maas-committers/maas-ci/+git/maas-ci-config:master

2023-05-12 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas-ci/+git/maas-ci-config:fix_ansible_collections_permissions_issue into ~maas-committers/maas-ci/+git/maas-ci-config:master has been updated. Status: Needs review => Approved For more details, see:

[Sts-sponsors] [Merge] ~cgrabowski/maas-ci/+git/maas-ci-config:fix_ansible_collections_permissions_issue into ~maas-committers/maas-ci/+git/maas-ci-config:master

2023-05-11 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas-ci/+git/maas-ci-config:fix_ansible_collections_permissions_issue into ~maas-committers/maas-ci/+git/maas-ci-config:master. Commit message: fix file permissions in ansible collections Requested reviews: MAAS Committers (maas

Re: [Sts-sponsors] [Merge] ~troyanov/maas:expose-enable_hw_sync into maas:master

2023-05-11 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442692 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

[Sts-sponsors] [Merge] ~philroche/maas-images:feature/opening-mantic into maas-images:master

2023-05-11 Thread Christian Grabowski
The proposal to merge ~philroche/maas-images:feature/opening-mantic into maas-images:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~philroche/maas-images/+git/maas-images/+merge/442661 -- Your team maintainers of maas images is

Re: [Sts-sponsors] [Merge] ~philroche/maas-images:feature/opening-mantic into maas-images:master

2023-05-11 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~philroche/maas-images/+git/maas-images/+merge/442661 Your team maintainers of maas images is subscribed to branch maas-images:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net

Re: [Sts-sponsors] [Merge] ~ack/maas:2018149-netplan-bool into maas:master

2023-05-11 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~ack/maas/+git/maas/+merge/442657 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

[Sts-sponsors] [Merge] ~cgrabowski/maas:bump_go_pcap_for_vlan_id_support into maas:master

2023-05-09 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:bump_go_pcap_for_vlan_id_support into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/442538 -- Your team MAAS Committers is subscribed to branch

[Sts-sponsors] [Merge] ~cgrabowski/maas:bump_go_pcap_for_vlan_id_support into maas:master

2023-05-09 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:bump_go_pcap_for_vlan_id_support into maas:master has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/442538 -- Your team MAAS Committers is subscribed to branch

[Sts-sponsors] [Merge] ~cgrabowski/maas:bump_go_pcap_for_vlan_id_support into maas:master

2023-05-09 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:bump_go_pcap_for_vlan_id_support into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/442538 -- Your team MAAS Committers is subscribed to branch

[Sts-sponsors] [Merge] ~cgrabowski/maas:bump_go_pcap_for_vlan_id_support into maas:master

2023-05-09 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:bump_go_pcap_for_vlan_id_support into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/442538 -- Your team MAAS Committers is subscribed to branch

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:bump_go_pcap_for_vlan_id_support into maas:master

2023-05-09 Thread Christian Grabowski
> I see that your PR to go-pcap was merged. Nice! > > Should we makes changes to our code in order to benefit from VLAN tags parsing > in go-pcap? Thanks! So no changes are needed in our code, the existing parser will just see the ethernet type and should already parse the VLAN tag. --

[Sts-sponsors] [Merge] ~cgrabowski/maas:bump_go_pcap_for_vlan_id_support into maas:master

2023-05-09 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas:bump_go_pcap_for_vlan_id_support into maas:master. Commit message: bump go-pcap to add vlan tags Requested reviews: MAAS Maintainers (maas-maintainers) For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas

Re: [Sts-sponsors] [Merge] ~troyanov/maas:refactor-maasagent-tests into maas:master

2023-05-09 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442489 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

Re: [Sts-sponsors] [Merge] ~troyanov/maas:fix-parallel-make into maas:master

2023-05-04 Thread Christian Grabowski
Diff comments: > diff --git a/src/maasagent/Makefile b/src/maasagent/Makefile > index 5c8f97b..dbd102a 100644 > --- a/src/maasagent/Makefile > +++ b/src/maasagent/Makefile > @@ -20,7 +20,9 @@ $(BIN_DIR): ; mkdir -p $@ > ARTIFACTS := $(subst /,,$(subst cmd/,,$(wildcard cmd/*/))) > > .PHONY:

[Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-05-03 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:go_network_discovery into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/441702 -- Your team MAAS Committers is subscribed to branch maas:master. --

Re: [Sts-sponsors] [Merge] ~troyanov/maas:lint-go-fix into maas:master

2023-05-03 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442284 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

Re: [Sts-sponsors] [Merge] ~lloydwaltersj/maas-ci/+git/maas-ci-config:fix-external-gh-testers into ~maas-committers/maas-ci/+git/maas-ci-config:master

2023-05-03 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~lloydwaltersj/maas-ci/+git/maas-ci-config/+merge/442268 Your team MAAS Committers is subscribed to branch ~maas-committers/maas-ci/+git/maas-ci-config:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to :

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-05-03 Thread Christian Grabowski
Diff comments: > diff --git a/src/maasagent/cmd/netmon/main.go > b/src/maasagent/cmd/netmon/main.go > index e83655f..7b60e83 100644 > --- a/src/maasagent/cmd/netmon/main.go > +++ b/src/maasagent/cmd/netmon/main.go > @@ -1,9 +1,83 @@ > package main > > +/* > + Copyright 2023 Canonical

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-05-03 Thread Christian Grabowski
Diff comments: > diff --git a/src/maasagent/internal/netmon/service.go > b/src/maasagent/internal/netmon/service.go > index 14ebdc6..11be56a 100644 > --- a/src/maasagent/internal/netmon/service.go > +++ b/src/maasagent/internal/netmon/service.go > @@ -1,3 +1,255 @@ > package netmon > >

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-05-03 Thread Christian Grabowski
Diff comments: > diff --git a/src/maasagent/cmd/netmon/main.go > b/src/maasagent/cmd/netmon/main.go > index e83655f..7b60e83 100644 > --- a/src/maasagent/cmd/netmon/main.go > +++ b/src/maasagent/cmd/netmon/main.go > @@ -1,9 +1,83 @@ > package main > > +/* > + Copyright 2023 Canonical

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-05-03 Thread Christian Grabowski
> I've left some comments. Thanks Tom. I've pushed an update based on your feedback. -- https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/441702 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to :

Re: [Sts-sponsors] [Merge] ~troyanov/maas:go-lint-all into maas:master

2023-05-01 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442131 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-05-01 Thread Christian Grabowski
Diff comments: > diff --git a/src/maasagent/cmd/netmon/main.go > b/src/maasagent/cmd/netmon/main.go > index e83655f..c88d9bf 100644 > --- a/src/maasagent/cmd/netmon/main.go > +++ b/src/maasagent/cmd/netmon/main.go > @@ -1,9 +1,84 @@ > package main > > +/* > + Copyright 2023 Canonical

Re: [Sts-sponsors] [Merge] ~alexsander-souza/maas:fix_vmfs_alignment into maas:master

2023-04-28 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~alexsander-souza/maas/+git/maas/+merge/442113 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-04-27 Thread Christian Grabowski
Diff comments: > diff --git a/src/maasagent/cmd/netmon/main.go > b/src/maasagent/cmd/netmon/main.go > index e83655f..5acd102 100644 > --- a/src/maasagent/cmd/netmon/main.go > +++ b/src/maasagent/cmd/netmon/main.go > @@ -1,9 +1,80 @@ > package main > > +/* > + Copyright 2023 Canonical

Re: [Sts-sponsors] [Merge] ~troyanov/maas:maasagent-cleanup into maas:master

2023-04-27 Thread Christian Grabowski
Diff comments: > diff --git a/Makefile b/Makefile > index 53fc526..8215f4c 100644 > --- a/Makefile > +++ b/Makefile > @@ -189,8 +189,13 @@ lint-oapi: openapi.yaml > .PHONY: lint-oapi > > # Go fmt > +<<< Makefile seems like a merge conflict got committed? > lint-go:

[Sts-sponsors] [Merge] ~cgrabowski/maas:backport_dns_tx_serialization_fix into maas:3.3

2023-04-26 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas:backport_dns_tx_serialization_fix into maas:3.3. Commit message: skip checking serial if a newer one exists update interface+ip trigger to ignore controllers handled in other trigger (cherry picked from commit

[Sts-sponsors] [Merge] ~cgrabowski/maas:backport_dns_tx_serialization_fix into maas:3.3

2023-04-26 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:backport_dns_tx_serialization_fix into maas:3.3 has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/441968 -- Your team MAAS Committers is subscribed to branch

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:backport_dns_tx_serialization_fix into maas:3.3

2023-04-26 Thread Christian Grabowski
Review: Approve self-approving backport -- https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/441968 Your team MAAS Committers is subscribed to branch maas:3.3. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

[Sts-sponsors] [Merge] ~cgrabowski/maas:fix_dns_tx_serialization into maas:master

2023-04-26 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:fix_dns_tx_serialization into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/441964 -- Your team MAAS Committers is subscribed to branch maas:master.

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:fix_dns_tx_serialization into maas:master

2023-04-26 Thread Christian Grabowski
jenkins: !test -- https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/441964 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:fix_dns_tx_serialization into maas:master

2023-04-26 Thread Christian Grabowski
jenkins: !test -- https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/441964 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

[Sts-sponsors] [Merge] ~cgrabowski/maas:fix_dns_tx_serialization into maas:master

2023-04-26 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas:fix_dns_tx_serialization into maas:master. Commit message: skip checking serial if a newer one exists update interface+ip trigger to ignore controllers handled in other trigger Requested reviews: MAAS Maintainers (maas-maintainers

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-04-25 Thread Christian Grabowski
Diff comments: > diff --git a/src/maasagent/cmd/netmon/main.go > b/src/maasagent/cmd/netmon/main.go > index e83655f..09306fa 100644 > --- a/src/maasagent/cmd/netmon/main.go > +++ b/src/maasagent/cmd/netmon/main.go > @@ -1,9 +1,93 @@ > package main > > +/* > + Copyright 2023 Canonical

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-04-25 Thread Christian Grabowski
> This is too large to review effectively, could it be splitted in branches with > related logical changes? Well there's the ARP parsing and the service itself, but that would only split out two files from the rest, which I can do if that is desirable. --

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-04-24 Thread Christian Grabowski
Diff comments: > diff --git a/src/maasagent/internal/arp/ethernet.go > b/src/maasagent/internal/arp/ethernet.go > new file mode 100644 > index 000..0d3e7d3 > --- /dev/null > +++ b/src/maasagent/internal/arp/ethernet.go > @@ -0,0 +1,133 @@ > +package arp > + > +/* > + Copyright 2023

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-04-24 Thread Christian Grabowski
Diff comments: > diff --git a/src/maasagent/cmd/netmon/main.go > b/src/maasagent/cmd/netmon/main.go > index e83655f..09306fa 100644 > --- a/src/maasagent/cmd/netmon/main.go > +++ b/src/maasagent/cmd/netmon/main.go > @@ -1,9 +1,93 @@ > package main > > +/* > + Copyright 2023 Canonical

[Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-04-24 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas:go_network_discovery into maas:master. Commit message: print results as json add netmon service add package for parsing ARP packets Requested reviews: Mark Laing (markylaing) Thomas Parrott (tomparrott) MAAS Maintainers (maas

[Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-04-21 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas:go_network_discovery into maas:master. Commit message: print results as json add netmon service add package for parsing ARP packets Requested reviews: MAAS Maintainers (maas-maintainers) For more details, see: https

[Sts-sponsors] [Merge] ~cgrabowski/maas:go_network_discovery into maas:master

2023-04-21 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:go_network_discovery into maas:master has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/441702 -- Your team MAAS Maintainers is requested to review the

Re: [Sts-sponsors] [Merge] ~troyanov/maas:maas-agent into maas:master

2023-04-18 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/441357 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

[Sts-sponsors] [Merge] ~cgrabowski/maas:cleanup_rpc_disconnect_logging into maas:master

2023-04-14 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas:cleanup_rpc_disconnect_logging into maas:master. Commit message: only log that a Rack Controller has disconnected when all connections are gone Requested reviews: MAAS Maintainers (maas-maintainers) For more details, see: https

Re: [Sts-sponsors] [Merge] ~adam-collard/maas-images:drop-xgene-lunar into maas-images:master

2023-04-14 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~adam-collard/maas-images/+git/maas-images/+merge/441100 Your team maintainers of maas images is subscribed to branch maas-images:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net

Re: [Sts-sponsors] [Merge] ~troyanov/maas:go-style-doc into maas:master

2023-04-12 Thread Christian Grabowski
Overall, looks good, just a couple nits inline. Diff comments: > diff --git a/go-style-guide.md b/go-style-guide.md > new file mode 100644 > index 000..13baa41 > --- /dev/null > +++ b/go-style-guide.md > @@ -0,0 +1,758 @@ > +# MAAS Go style guide > + > +This document represents a set of

[Sts-sponsors] [Merge] ~cgrabowski/maas-ci/+git/maas-ci-config:add_ansible_collection_tests into ~maas-committers/maas-ci/+git/maas-ci-config:master

2023-04-12 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas-ci/+git/maas-ci-config:add_ansible_collection_tests into ~maas-committers/maas-ci/+git/maas-ci-config:master has been updated. Status: Needs review => Approved For more details, see:

[Sts-sponsors] [Merge] ~cgrabowski/maas-ci/+git/maas-ci-config:add_ansible_collection_tests into ~maas-committers/maas-ci/+git/maas-ci-config:master

2023-04-11 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas-ci/+git/maas-ci-config:add_ansible_collection_tests into ~maas-committers/maas-ci/+git/maas-ci-config:master. Commit message: add job definitions for ansible-collection Requested reviews: MAAS Committers (maas-committers) For more

Re: [Sts-sponsors] [Merge] ~ack/maas/+git/maas-release-tools:annotate-tag-command into ~maas-committers/maas/+git/maas-release-tools:main

2023-04-05 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~ack/maas/+git/maas-release-tools/+merge/440412 Your team MAAS Committers is subscribed to branch ~maas-committers/maas/+git/maas-release-tools:main. -- Mailing list: https://launchpad.net/~sts-sponsors Post to :

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas-ci/+git/system-tests:ha_postgres_system_tests into ~maas-committers/maas-ci/+git/system-tests:master

2023-03-30 Thread Christian Grabowski
Diff comments: > diff --git a/setup.py b/setup.py > index 21d75cd..3143a0a 100644 > --- a/setup.py > +++ b/setup.py > @@ -8,6 +9,7 @@ install_requires = ( > 'pytest-steps', > 'pyyaml', > 'retry', > +'requests', +1 > 'ruamel.yaml', > ) > > diff --git

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas-ci/+git/system-tests:ha_postgres_system_tests into ~maas-committers/maas-ci/+git/system-tests:master

2023-03-30 Thread Christian Grabowski
Diff comments: > diff --git a/stubs/netaddr/ip/__init__.pyi b/stubs/netaddr/ip/__init__.pyi > new file mode 100644 > index 000..034d875 > --- /dev/null > +++ b/stubs/netaddr/ip/__init__.pyi +1 > @@ -0,0 +1,23 @@ > +from __future__ import annotations > + > +from typing import Optional,

[Sts-sponsors] [Merge] ~cgrabowski/maas:backport_fix_missing_dns_records_to_3.3 into maas:3.3

2023-03-17 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:backport_fix_missing_dns_records_to_3.3 into maas:3.3 has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/439185 -- Your team MAAS Committers is subscribed to branch

[Sts-sponsors] [Merge] ~cgrabowski/maas:backport_fix_missing_dns_records_to_3.3 into maas:3.3

2023-03-17 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:backport_fix_missing_dns_records_to_3.3 into maas:3.3 has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/439185 -- Your team MAAS Committers is subscribed to branch

[Sts-sponsors] [Merge] ~cgrabowski/maas:backport_fix_missing_dns_records_to_3.3 into maas:3.3

2023-03-17 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:backport_fix_missing_dns_records_to_3.3 into maas:3.3 has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/439185 -- Your team MAAS Committers is subscribed to branch

[Sts-sponsors] [Merge] ~cgrabowski/maas:backport_fix_missing_dns_records_to_3.3 into maas:3.3

2023-03-17 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas:backport_fix_missing_dns_records_to_3.3 into maas:3.3. Commit message: ensure needsDNSUpdate is true when there were queued updates (cherry picked from commit 229f33899ba06b9067067b63b5c72689ab7a44e0) Requested reviews: Christian

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:backport_fix_missing_dns_records_to_3.3 into maas:3.3

2023-03-17 Thread Christian Grabowski
Review: Approve self-approving backport -- https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/439185 Your team MAAS Committers is subscribed to branch maas:3.3. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

[Sts-sponsors] [Merge] ~cgrabowski/maas:fix_missing_dns_records into maas:master

2023-03-17 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:fix_missing_dns_records into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/439183 -- Your team MAAS Committers is subscribed to branch maas:master.

[Sts-sponsors] [Merge] ~cgrabowski/maas:fix_missing_dns_records into maas:master

2023-03-17 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas:fix_missing_dns_records into maas:master. Commit message: ensure needsDNSUpdate is true when there were queued updates Requested reviews: MAAS Maintainers (maas-maintainers) For more details, see: https://code.launchpad.net

Re: [Sts-sponsors] [Merge] ~alexsander-souza/maas-ci/+git/system-tests:refresh_maas_cli_on_upgrade into ~maas-committers/maas-ci/+git/system-tests:master

2023-03-16 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~alexsander-souza/maas-ci/+git/system-tests/+merge/439091 Your team MAAS Committers is subscribed to branch ~maas-committers/maas-ci/+git/system-tests:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to :

Re: [Sts-sponsors] [Merge] ~adam-collard/maas:no-amp-debug into maas:master

2023-03-16 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/439085 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

Re: [Sts-sponsors] [Merge] ~maas-committers/maas-ci/+git/maas-ci-config:Jenkins-autojob-ansible into ~maas-committers/maas-ci/+git/maas-ci-config:master

2023-03-15 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~maas-committers/maas-ci/+git/maas-ci-config/+merge/438683 Your team MAAS Committers is subscribed to branch ~maas-committers/maas-ci/+git/maas-ci-config:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to :

Re: [Sts-sponsors] [Merge] ~ack/maas-ci/+git/maas-ci-internal:drop-machine-list-spike into ~maas-committers/maas-ci/+git/maas-ci-internal:main

2023-03-15 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~ack/maas-ci/+git/maas-ci-internal/+merge/438989 Your team MAAS Committers is subscribed to branch ~maas-committers/maas-ci/+git/maas-ci-internal:main. -- Mailing list: https://launchpad.net/~sts-sponsors Post to :

[Sts-sponsors] [Merge] ~cgrabowski/maas:fix_boot_params_on_deployment into maas:master

2023-03-15 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:fix_boot_params_on_deployment into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/438942 -- Your team MAAS Committers is subscribed to branch

[Sts-sponsors] [Merge] ~cgrabowski/maas:fix_boot_params_on_deployment into maas:master

2023-03-14 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:fix_boot_params_on_deployment into maas:master has been updated. Commit message changed to: add units for get_node_from_mac_or_hardware_uuid ensure MAC is properly formatted for boot config query For more details, see:

[Sts-sponsors] [Merge] ~cgrabowski/maas:fix_boot_params_on_deployment into maas:master

2023-03-14 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas:fix_boot_params_on_deployment into maas:master. Commit message: add units for get_node_from_mac_or_hardware_uuid ensure MAC is properly sorts for boot config query Requested reviews: MAAS Maintainers (maas-maintainers) For more

Re: [Sts-sponsors] [Merge] ~troyanov/maas:fix-testtools into maas:master

2023-03-14 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/438928 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

[Sts-sponsors] [Merge] ~cgrabowski/maas-ci/+git/system-tests:ha_postgres_system_tests into ~maas-committers/maas-ci/+git/system-tests:master

2023-03-07 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas-ci/+git/system-tests:ha_postgres_system_tests into ~maas-committers/maas-ci/+git/system-tests:master. Commit message: specify floating ip parameters add ha postgres tests add new roles Requested reviews: MAAS Committers (maas

Re: [Sts-sponsors] [Merge] ~ack/maas:drop-verbose-regex-validator into maas:master

2023-02-27 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~ack/maas/+git/maas/+merge/437951 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

Re: [Sts-sponsors] [Merge] ~thorsten-merten/maas-site-manager:MAASENG-1285-monorepo into maas-site-manager:main

2023-02-24 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/437893 Your team MAAS Committers is subscribed to branch ~thorsten-merten/maas-site-manager:MAASENG-1285-monorepo. -- Mailing list: https://launchpad.net/~sts-sponsors Post to

Re: [Sts-sponsors] [Merge] ~adam-collard/maas-ci/+git/maas-ci-internal:unify-lander into ~maas-committers/maas-ci/+git/maas-ci-internal:main

2023-02-21 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~adam-collard/maas-ci/+git/maas-ci-internal/+merge/437621 Your team MAAS Committers is subscribed to branch ~maas-committers/maas-ci/+git/maas-ci-internal:main. -- Mailing list: https://launchpad.net/~sts-sponsors Post to :

Re: [Sts-sponsors] [Merge] ~alexsander-souza/maas:3_1_update_submodules into maas:3.1

2023-02-15 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~alexsander-souza/maas/+git/maas/+merge/437385 Your team MAAS Committers is subscribed to branch maas:3.1. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

Re: [Sts-sponsors] [Merge] ~maas-committers/maas-ci/+git/maas-ci-internal:update-site-manager into ~maas-committers/maas-ci/+git/maas-ci-internal:main

2023-02-15 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~maas-committers/maas-ci/+git/maas-ci-internal/+merge/437366 Your team MAAS Committers is subscribed to branch ~maas-committers/maas-ci/+git/maas-ci-internal:main. -- Mailing list: https://launchpad.net/~sts-sponsors Post to :

[Sts-sponsors] [Merge] ~cgrabowski/maas-ci/+git/maas-ci-internal:fixes_from_renaming_terraform_job into ~maas-committers/maas-ci/+git/maas-ci-internal:main

2023-02-02 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas-ci/+git/maas-ci-internal:fixes_from_renaming_terraform_job into ~maas-committers/maas-ci/+git/maas-ci-internal:main has been updated. Status: Needs review => Approved For more details, see:

[Sts-sponsors] [Merge] ~cgrabowski/maas-ci/+git/maas-ci-internal:fixes_from_renaming_terraform_job into ~maas-committers/maas-ci/+git/maas-ci-internal:main

2023-02-02 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas-ci/+git/maas-ci-internal:fixes_from_renaming_terraform_job into ~maas-committers/maas-ci/+git/maas-ci-internal:main. Commit message: handle missing primary rack to enalbe DHCP fix paths from renaming job Requested reviews: MAAS

Re: [Sts-sponsors] [Merge] ~adam-collard/maas-images:jammy-hwe-edge into maas-images:master

2023-02-01 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~adam-collard/maas-images/+git/maas-images/+merge/436722 Your team maintainers of maas images is subscribed to branch maas-images:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net

[Sts-sponsors] [Merge] ~cgrabowski/maas:fix_dns_update_race_condition into maas:master

2023-01-30 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas:fix_dns_update_race_condition into maas:master. Commit message: store updates in a separate list while updating BIND no longer remove BIND jnl Requested reviews: MAAS Maintainers (maas-maintainers) For more details, see: https

[Sts-sponsors] [Merge] ~cgrabowski/maas:backport_ensure_reverse_dns_updates_are_always_included into maas:3.3

2023-01-27 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:backport_ensure_reverse_dns_updates_are_always_included into maas:3.3 has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/436479 -- Your team MAAS Committers is

[Sts-sponsors] [Merge] ~cgrabowski/maas:backport_ensure_reverse_dns_updates_are_always_included into maas:3.3

2023-01-27 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas:backport_ensure_reverse_dns_updates_are_always_included into maas:3.3. Commit message: better handle modified subnet values in update ownership comparison (cherry picked from commit 89184561b25cb6c05e5d466691a67e23ad3b6265) Requested

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:backport_ensure_reverse_dns_updates_are_always_included into maas:3.3

2023-01-27 Thread Christian Grabowski
Review: Approve self-approving backport -- https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/436479 Your team MAAS Committers is subscribed to branch maas:3.3. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

[Sts-sponsors] [Merge] ~cgrabowski/maas:ensure_reverse_dns_updates_are_always_included into maas:master

2023-01-27 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:ensure_reverse_dns_updates_are_always_included into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/436473 -- Your team MAAS Committers is subscribed

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:ensure_reverse_dns_updates_are_always_included into maas:master

2023-01-27 Thread Christian Grabowski
jenkins: !test -- https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/436473 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

[Sts-sponsors] [Merge] ~cgrabowski/maas:ensure_reverse_dns_updates_are_always_included into maas:master

2023-01-27 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas:ensure_reverse_dns_updates_are_always_included into maas:master. Commit message: better handle modified subnet values in update ownership comparison Requested reviews: MAAS Maintainers (maas-maintainers) For more details, see

Re: [Sts-sponsors] [Merge] ~alexsander-souza/maas:sync_submodules into maas:3.3

2023-01-27 Thread Christian Grabowski
Review: Approve +1 -- https://code.launchpad.net/~alexsander-souza/maas/+git/maas/+merge/436472 Your team MAAS Committers is subscribed to branch maas:3.3. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

[Sts-sponsors] [Merge] ~cgrabowski/maas:backport_deflake_dynamic_update_test_to_3.3 into maas:3.3

2023-01-27 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:backport_deflake_dynamic_update_test_to_3.3 into maas:3.3 has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/436466 -- Your team MAAS Committers is subscribed to

[Sts-sponsors] [Merge] ~cgrabowski/maas:backport_deflake_dynamic_update_test_to_3.3 into maas:3.3

2023-01-27 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas:backport_deflake_dynamic_update_test_to_3.3 into maas:3.3. Commit message: split out reverse update generation tests to glue zones and non-gluezones (cherry picked from commit b6241874577384ba4b0cb8c4c640ed4b36d9cbfb) Requested reviews

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:backport_deflake_dynamic_update_test_to_3.3 into maas:3.3

2023-01-27 Thread Christian Grabowski
Review: Approve self-approving backport -- https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/436466 Your team MAAS Committers is subscribed to branch maas:3.3. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

[Sts-sponsors] [Merge] ~cgrabowski/maas:deflake_dynamic_update_test into maas:master

2023-01-27 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:deflake_dynamic_update_test into maas:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/436443 -- Your team MAAS Committers is subscribed to branch

[Sts-sponsors] [Merge] ~cgrabowski/maas:deflake_dynamic_update_test into maas:master

2023-01-27 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas:deflake_dynamic_update_test into maas:master. Commit message: split out reverse update generation tests to glue zones and non-gluezones Requested reviews: MAAS Maintainers (maas-maintainers) For more details, see: https

[Sts-sponsors] [Merge] ~cgrabowski/maas:backport_properly_format_records_for_glue_zones_to_3.3 into maas:3.3

2023-01-26 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:backport_properly_format_records_for_glue_zones_to_3.3 into maas:3.3 has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/436418 -- Your team MAAS Committers is

[Sts-sponsors] [Merge] ~cgrabowski/maas:backport_properly_format_records_for_glue_zones_to_3.3 into maas:3.3

2023-01-26 Thread Christian Grabowski
The proposal to merge ~cgrabowski/maas:backport_properly_format_records_for_glue_zones_to_3.3 into maas:3.3 has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/436418 -- Your team MAAS Committers is

[Sts-sponsors] [Merge] ~cgrabowski/maas:backport_properly_format_records_for_glue_zones_to_3.3 into maas:3.3

2023-01-26 Thread Christian Grabowski
Christian Grabowski has proposed merging ~cgrabowski/maas:backport_properly_format_records_for_glue_zones_to_3.3 into maas:3.3. Commit message: format glue zone dynamic updates to specify shorter prefix len (cherry picked from commit c2b4038e602409028850b738afac7f32b03170d5) Requested

Re: [Sts-sponsors] [Merge] ~cgrabowski/maas:backport_properly_format_records_for_glue_zones_to_3.3 into maas:3.3

2023-01-26 Thread Christian Grabowski
Review: Approve self-approving backport -- https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/436418 Your team MAAS Committers is subscribed to branch maas:3.3. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : sts-sponsors@lists.launchpad.net Unsubscribe :

  1   2   >