Review: Approve
+1
--
https://code.launchpad.net/~adam-collard/maas-ci/+git/system-tests/+merge/435675
Your team MAAS Committers is subscribed to branch
~maas-committers/maas-ci/+git/system-tests:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Approve
UNIT TESTS
-b extract_o11y lp:~adam-collard/maas-ci/+git/system-tests into -b master
lp:~maas-committers/maas-ci/+git/system-tests
STATUS: SUCCESS
COMMIT: e7691c3fe13f2b63957a7ae8c22f84334c8dc8dc
--
Adam Collard has proposed merging
~adam-collard/maas-ci/+git/system-tests:extract_o11y into
~maas-committers/maas-ci/+git/system-tests:master.
Commit message:
Extract o11y configuration to o11y.py
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
The proposal to merge
~adam-collard/maas-ci/+git/system-tests:extract-install-deb into
~maas-committers/maas-ci/+git/system-tests:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~adam-collard/maas-ci/+git/system-tests/+merge/435672
--
The proposal to merge
~adam-collard/maas-ci/+git/system-tests:extract-install-deb into
~maas-committers/maas-ci/+git/system-tests:master has been updated.
Status: Needs review => Approved
For more details, see:
Review: Approve
+1
--
https://code.launchpad.net/~adam-collard/maas-ci/+git/system-tests/+merge/435672
Your team MAAS Committers is subscribed to branch
~maas-committers/maas-ci/+git/system-tests:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Approve
UNIT TESTS
-b extract-install-deb lp:~adam-collard/maas-ci/+git/system-tests into -b
master lp:~maas-committers/maas-ci/+git/system-tests
STATUS: SUCCESS
COMMIT: 3f1ead95b712a105039638dbe33a09d15eada4d6
--
The proposal to merge
~cgrabowski/maas:backport_fix_writing_zonefile_with_correct_permissions_to_3.3
into maas:3.3 has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/435670
--
Your team MAAS Committers is
Adam Collard has proposed merging
~adam-collard/maas-ci/+git/system-tests:extract-install-deb into
~maas-committers/maas-ci/+git/system-tests:master.
Commit message:
Extract steps to install deb from maas_region fixture
Use container_name always
Requested reviews:
MAAS Committers
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: s390x
* Pocket: UPDATES
* State: Failed to build
* Duration: 17 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: ppc64el
* Pocket: UPDATES
* State: Failed to build
* Duration: 12 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: arm64
* Pocket: UPDATES
* State: Failed to build
* Duration: 11 minutes
* Build Log:
Diff comments:
> diff --git a/src/maasserver/sessiontimeout.py
> b/src/maasserver/sessiontimeout.py
> new file mode 100644
> index 000..6564b4d
> --- /dev/null
> +++ b/src/maasserver/sessiontimeout.py
> @@ -0,0 +1,15 @@
> +""" Custom sessionstore for a user-configurable session timeout.
Christian Grabowski has proposed merging
~cgrabowski/maas:backport_fix_writing_zonefile_with_correct_permissions_to_3.3
into maas:3.3.
Commit message:
allow MAAS to overwrite zonefile ownership from BIND
(cherry picked from commit 46ea08c76a366732fd30062399173ee310709ff1)
Requested reviews:
The proposal to merge
~cgrabowski/maas:backport_fix_writing_zonefile_with_correct_permissions_to_3.3
into maas:3.3 has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/435670
--
Your team MAAS Committers is
Review: Approve
self-approving backport
--
https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/435670
Your team MAAS Committers is subscribed to branch maas:3.3.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
The proposal to merge
~cgrabowski/maas:fix_writing_zonefile_with_correct_permissions into maas:master
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/435611
--
Your team MAAS Committers is subscribed to
Review: Needs Fixing
Inline nit/questions, looks good elsewhere though.
Diff comments:
> diff --git a/src/provisioningserver/drivers/power/tests/test_cps.py
> b/src/provisioningserver/drivers/power/tests/test_cps.py
> new file mode 100644
> index 000..0663c80
> --- /dev/null
> +++
The proposal to merge
~cgrabowski/maas:fix_writing_zonefile_with_correct_permissions into maas:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/435611
--
Your team MAAS Committers is subscribed to
Review: Approve
UNIT TESTS
-b fix_writing_zonefile_with_correct_permissions lp:~cgrabowski/maas/+git/maas
into -b master lp:~maas-committers/maas
STATUS: SUCCESS
COMMIT: 5201a578aa693770ccbe9b22d94b720a1f7a0586
--
https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/435611
Your team
Diff comments:
> diff --git a/src/provisioningserver/dns/zoneconfig.py
> b/src/provisioningserver/dns/zoneconfig.py
> index 3c6e383..6ab01a8 100644
> --- a/src/provisioningserver/dns/zoneconfig.py
> +++ b/src/provisioningserver/dns/zoneconfig.py
> @@ -197,9 +197,16 @@ class DomainConfigBase:
Review: Approve
LGTM, minor question inline
Diff comments:
> diff --git a/src/provisioningserver/dns/zoneconfig.py
> b/src/provisioningserver/dns/zoneconfig.py
> index 3c6e383..6ab01a8 100644
> --- a/src/provisioningserver/dns/zoneconfig.py
> +++ b/src/provisioningserver/dns/zoneconfig.py
> @@
The proposal to merge ~ack/maas-kpi:maasspike-dashboard into
~maas-committers/maas-kpi/+git/maas-kpi:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~ack/maas-kpi/+git/maas-kpi/+merge/435665
--
Your team MAAS Committers is
The proposal to merge ~ack/maas-ci/+git/maas-ci-internal:grafana-dashboards-job
into ~maas-committers/maas-ci/+git/maas-ci-internal:main has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~ack/maas-ci/+git/maas-ci-internal/+merge/435668
--
Review: Approve
UNIT TESTS
-b grafana-dashboards-job lp:~ack/maas-ci/+git/maas-ci-internal into -b main
lp:~maas-committers/maas-ci/+git/maas-ci-internal
STATUS: SUCCESS
COMMIT: 0cd19ac596d7dd652b0050bf078982fb83f01251
--
Review: Approve
+1
--
https://code.launchpad.net/~ack/maas-ci/+git/maas-ci-internal/+merge/435668
Your team MAAS Committers is subscribed to branch
~maas-committers/maas-ci/+git/maas-ci-internal:main.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Alberto Donato has proposed merging
~ack/maas-ci/+git/maas-ci-internal:grafana-dashboards-job into
~maas-committers/maas-ci/+git/maas-ci-internal:main.
Commit message:
move grafana-dashboards job to JJB
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
Review: Needs Fixing
UNIT TESTS
-b undefined-controller-type lp:~lloydwaltersj/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/1758/consoleText
COMMIT: 92febeb3cf6f4d6b3087eb2dbacd462552f81d60
--
Review: Needs Fixing
UNIT TESTS
-b dns_performance lp:~cgrabowski/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/1757/consoleText
COMMIT: 667eaadd29b3238d269cd031a402403654c29ae6
--
Review: Approve
+1 with a nitpick inline.
Diff comments:
> diff --git a/grafana/machine-listing-spike.dashboard.py
> b/grafana/machine-listing-spike.dashboard.py
> new file mode 100644
> index 000..9707080
> --- /dev/null
> +++ b/grafana/machine-listing-spike.dashboard.py
> @@ -0,0 +1,193
Alberto Donato has proposed merging ~ack/maas-kpi:maasspike-dashboard into
~maas-committers/maas-kpi/+git/maas-kpi:master.
Commit message:
Add graphana dashboard for machine listing performance spike
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: s390x
* Pocket: UPDATES
* State: Failed to build
* Duration: 17 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: ppc64el
* Pocket: UPDATES
* State: Failed to build
* Duration: 12 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: arm64
* Pocket: UPDATES
* State: Failed to build
* Duration: 11 minutes
* Build Log:
Hi Chengen!
How are you?
I just found out this bug that needs SRU sponsorship for your ticket SF#341744.
Please excuse our lack of documentation; I'll be working on that,
but the reason our sponsor team (or at least me) was because
the 'SE SRU Sponsors' team was not _subscribed_ to the bug.
I
** Tags removed: sts-sponsor
--
You received this bug notification because you are a member of SE SRU
("STS") Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1999711
Title:
Snmptrapd cannot reconnect to MySQL server after hitting MySQL
wait_timeout
Status
You have been subscribed to a public bug by Mauricio Faria de Oliveira (mfo):
[Impact]
wait_timeout is the number of seconds the MySQL server waits for activity
before closing the connection.
MySQL v8.0.24 writes the reason for the connection before closing it, and the
client receives a more
Review: Needs Information
Why the explicit else: clause here and not adding to
controller.ControllerHandler.list_fields?
--
https://code.launchpad.net/~lloydwaltersj/maas/+git/maas/+merge/435593
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list:
Review: Approve
LGTM
--
https://code.launchpad.net/~emdw/maas/+git/maas/+merge/435525
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
39 matches
Mail list logo