[Sts-sponsors] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-04-19 Thread Launchpad Bug Tracker
This bug was fixed in the package systemd - 204-5ubuntu20.28 --- systemd (204-5ubuntu20.28) trusty; urgency=medium * logind: fix memleaks in session's free path and cgmanager glue code (LP: #1750013) -- gpicc...@canonical.com (Guilherme G. Piccoli) Tue, 03 Apr 2018 13:38:08

[Sts-sponsors] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-04-19 Thread Guilherme G. Piccoli
As mentioned by Dan in the above comments, some failures in autopkgtest like: autopkgtest [14:44:48]: test ubuntu-regression-suite: [--- Source Package Version: 4.4.0-1017.17 Running Kernel Version: 3.13.0-145.194 ERROR: running version does not match source package Are

[Sts-sponsors] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-04-13 Thread Dan Streetman
> caused by bug 1723272 sorry, i meant bug 1723223 -- You received this bug notification because you are a member of STS Sponsors, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1750013 Title: systemd-logind: memory leaks on session's connections (trusty-only) Status

[Sts-sponsors] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-04-13 Thread Dan Streetman
Note, the 'linux-*' autopkgtest failures in pending-sru for this pkg are caused by bug 1723272, a known bug that can be ignored as it's unrelated to this sru. -- You received this bug notification because you are a member of STS Sponsors, which is subscribed to the bug report.

[Sts-sponsors] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-04-03 Thread Guilherme G. Piccoli
Dan, this is the v3 of the patch. I bumped the version to 20.28 since my proposed 20.27 caused the regression aforementioned. For this version, I removed the dependency of cgmanager, along with the code that added closing sessions to garbage collector. Happens that a similar code is present on

[Sts-sponsors] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-04-01 Thread Mauro Franzoni
...and for systemd-login (cgmanager and systemd-login were using both around 49-50% of CPU) ** Attachment added: "trace-syslog.txt" https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1750013/+attachment/5098335/+files/trace-syslog.txt -- You received this bug notification because you

[Sts-sponsors] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-04-01 Thread Mauro Franzoni
my trace for cgmanager Linux www 3.13.0-144-generic #193-Ubuntu SMP Thu Mar 15 17:02:07 UTC 2018 i686 athlon i686 GNU/Linux ** Attachment added: "trace-cgman.txt" https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1750013/+attachment/5098334/+files/trace-cgman.txt -- You received this

[Sts-sponsors] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-03-12 Thread Guilherme G. Piccoli
We had a potential regression reported after some users installed this package from -proposed. The reports starts on comment #17 in LP: #1303649 . Summary: users are reporting high CPU loads from both systemd-logind and cgmanager processes, as well as delays in logins. I'm investigating to

[Sts-sponsors] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-03-09 Thread Guilherme G. Piccoli
Thanks Dan and Brian. Just tested: after 1h and more than 5500 SSH sessions, no leaks at all were observed. (As a comparison, testing the "old" version 20.26 I got 1.8 MB of leak in half an hour!) Cheers, Guilherme ** Tags removed: sts-sru-needed verification-needed

[Sts-sponsors] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-03-05 Thread Guilherme G. Piccoli
Thanks Dan. About cgmanager: if we don't have it installed, it does not affect memory of systemd-logind tool per se. What happens, IMHO, is even more severe: we don't free/de-allocate sysfs cgroup paths for sessions. So, in my tests _without_ cgmanager, after 8000 SSH sessions to my target

[Sts-sponsors] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-03-02 Thread Guilherme G. Piccoli
Dan, please let me know if the debdiff v2 above addresses your concern and if it's properly following your suggestion. I tested the modification and it's working fine. Thanks, Guilherme -- You received this bug notification because you are a member of STS Sponsors, which is subscribed to the

[Sts-sponsors] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-03-02 Thread Guilherme G. Piccoli
** Patch added: "debdiff v2" https://bugs.launchpad.net/ubuntu/artful/+source/systemd/+bug/1750013/+attachment/5067376/+files/lp1750013-trusty_v2.debdiff -- You received this bug notification because you are a member of STS Sponsors, which is subscribed to the bug report.

[Sts-sponsors] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-03-02 Thread Guilherme G. Piccoli
Dan, really well-observed! Thanks for the suggestion, it makes total sense. I'll update the approach: instead of using session_remove_fifo() to add the session on GC, I'll use the DBus handler itself. After testing, I'll submit a debdiff_v2 here. Thanks, Guilherme -- You received this bug

[Sts-sponsors] [Bug 1750013] Re: systemd-logind: memory leaks on session's connections (trusty-only)

2018-03-02 Thread Dan Streetman
> when SSH ends, for example, a Release event is sent > through dbus and systemd-logind captures it, in the function > manager_message_handler(). > > From there, the function session_remove_fifo() is called. That point is our > "bootstrap" > to add the closing session on gc ok i see that path,