On Mon, Dec 16, 2013 at 8:56 PM, Dirk Hohndel wrote:
> On Mon, 2013-12-16 at 18:36 -0700, Dazed_75 wrote:
> > Two additional issues now.
> >
> >
> > 1) There should probably be some mention on
> > http://subsurface.hohndel.org/building/ about why/why not to install
> > asciidoc and a warning abou
On Mon, 2013-12-16 at 18:36 -0700, Dazed_75 wrote:
> Two additional issues now.
>
>
> 1) There should probably be some mention on
> http://subsurface.hohndel.org/building/ about why/why not to install
> asciidoc and a warning about the messages from make install if you do
> not. I did notice th
Two additional issues now.
1) There should probably be some mention on
http://subsurface.hohndel.org/building/ about why/why not to install
asciidoc and a warning about the messages from make install if you do not.
I did notice the mac instructions DO include installing asciidoc.
2) The sudo make
On segunda-feira, 16 de dezembro de 2013 16:16:44, Dirk Hohndel wrote:
> $ git grep toLocal8Bit
> main.cpp: parse_argument(a.toLocal8Bit().data());
> qt-ui/divelistview.cpp: QByteArray bt = fileName.toLocal8Bit();
> qt-ui/mainwindow.cpp: fileNamePtr = fileNames.at(i)
COOL! That worked so those two additions need to be made to
subsurface.hohndel.org/building/
Thanks Jef and Dirk!
On Mon, Dec 16, 2013 at 5:07 PM, Dirk Hohndel wrote:
> On Tue, 2013-12-17 at 00:28 +0100, Jef Driesen wrote:
> > On 17-12-13 00:03, Dazed_75 wrote:
> > > Just a reminder that no o
On Mon, 2013-12-16 at 15:12 -0800, Thiago Macieira wrote:
> On segunda-feira, 16 de dezembro de 2013 23:50:42, Michael Andreen wrote:
> > Fixes #371
> >
> > Signed-off-by: Michael Andreen
> > ---
> >
> > On Monday, December 16, 2013 02:18:18 PM Thiago Macieira wrote:
> > > While the patch itself
On Mon, Dec 16, 2013 at 4:28 PM, Jef Driesen wrote:
> On 17-12-13 00:03, Dazed_75 wrote:
>
>> Just a reminder that no one has ever provided a fix for the problem
>> originally reported. That being that if one wishes to build
>> libdivecomputer in Linux, the directions provided on
>> http://subsur
On Tue, 2013-12-17 at 00:28 +0100, Jef Driesen wrote:
> On 17-12-13 00:03, Dazed_75 wrote:
> > Just a reminder that no one has ever provided a fix for the problem
> > originally reported. That being that if one wishes to build
> > libdivecomputer in Linux, the directions provided on
> > http://sub
On 17-12-13 00:03, Dazed_75 wrote:
Just a reminder that no one has ever provided a fix for the problem
originally reported. That being that if one wishes to build
libdivecomputer in Linux, the directions provided on
http://subsurface.hohndel.org/building/ do not work as the step "autoreconf
--in
On segunda-feira, 16 de dezembro de 2013 23:50:42, Michael Andreen wrote:
> Fixes #371
>
> Signed-off-by: Michael Andreen
> ---
>
> On Monday, December 16, 2013 02:18:18 PM Thiago Macieira wrote:
> > While the patch itself is fine, I'm not sure it's actually fixing
> > anything.
> > Michael, can
Just a reminder that no one has ever provided a fix for the problem
originally reported. That being that if one wishes to build
libdivecomputer in Linux, the directions provided on
http://subsurface.hohndel.org/building/ do not work as the step "autoreconf
--install" fails because LT_INIT is refer
Fixes #371
Signed-off-by: Michael Andreen
---
On Monday, December 16, 2013 02:18:18 PM Thiago Macieira wrote:
> While the patch itself is fine, I'm not sure it's actually fixing anything.
> Michael, can you confirm that it does fix the problem?
>
> The reason being that we set the "codec for C
On segunda-feira, 16 de dezembro de 2013 22:49:03, Michael Andreen wrote:
> Fixes #371
>
> Signed-off-by: Michael Andreen
While the patch itself is fine, I'm not sure it's actually fixing anything.
Michael, can you confirm that it does fix the problem?
The reason being that we set the "codec f
So why would we need those explicit conversions?
/D
---
>From my phone
Michael Andreen wrote:
>Fixes #371
>
>Signed-off-by: Michael Andreen
>---
>I haven't been able to test it on windows, hopefully I didn't miss any strings.
> qt-ui/maintab.cpp | 20 ++--
> 1 file changed, 10 i
On segunda-feira, 16 de dezembro de 2013 11:48:20, Dirk Hohndel wrote:
> > That's a good point. I don't mind having the variables declared at the top
> > provided they are *few* variables. If there are tens of variables and the
> > function is big enough I don't remember what this variable is or do
Fixes #371
Signed-off-by: Michael Andreen
---
I haven't been able to test it on windows, hopefully I didn't miss any strings.
qt-ui/maintab.cpp | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/qt-ui/maintab.cpp b/qt-ui/maintab.cpp
index 82e5d2e..3ae8d5b
On Mon, 2013-12-16 at 19:05 -0200, Tomaz Canabrava wrote:
> Most likely the document is in utf8 and we loaded with the latin1
> locale. Maybe we need to try to discover in which locale is the info
> written.
We should NEVER read or write anything in latin-1. Everything is
supposed to be in Utf8.
On Mon, 2013-12-16 at 11:39 -0800, Thiago Macieira wrote:
> On segunda-feira, 16 de dezembro de 2013 10:08:45, Linus Torvalds wrote:
> > I'm no a fan of the "declare variables where they are used" model,
> > because it tends to just encourage people to add crap to functions,
> > and I think it make
On segunda-feira, 16 de dezembro de 2013 10:08:45, Linus Torvalds wrote:
> I'm no a fan of the "declare variables where they are used" model,
> because it tends to just encourage people to add crap to functions,
> and I think it makes it hard to see what the variables in a function
> are. For the k
With the Europeans trying Subsurface 4 now, we are getting reports that
it doesn't deal well with accented characters:
I've dowloaded a dive, went to edit the notes to:
Plongée de Noël
Hit the save button and got that back in my notes:
Plong�e de No�l
That
On Mon, Dec 16, 2013 at 10:25 AM, Dirk Hohndel wrote:
> On Mon, 2013-12-16 at 10:08 -0800, Linus Torvalds wrote:
>
> The questions becomes one of "how can we be consistent"? I'm a big
> believer in consistency to make the code look the way you expect it to
> look. That includes things like variabl
On Mon, 2013-12-16 at 10:08 -0800, Linus Torvalds wrote:
> On Mon, Dec 16, 2013 at 9:54 AM, Dirk Hohndel wrote:
> >
> > Linus - if you have good reasons why we shouldn't do this, please speak
> > up.
>
> I'm a big fan of the "loop variable in loop" declaration style, one of
> the few actual good
On Mon, Dec 16, 2013 at 9:54 AM, Dirk Hohndel wrote:
>
> Linus - if you have good reasons why we shouldn't do this, please speak
> up.
I'm a big fan of the "loop variable in loop" declaration style, one of
the few actual good C++ syntax changes. And I think moving
declarations to the scope they a
On Mon, 2013-12-16 at 09:09 -0800, Thiago Macieira wrote:
> This patch series moves the .xslt files and the xslt/ subdir in the
> installation into a Qt resource. That means it's in a read-only
> section of memory instead of on disk. Benefits are that we don't need
> to install and manage the files
On Mon, 2013-12-16 at 09:06 -0800, Thiago Macieira wrote:
> Makes the code easier to read, IMHO.
Yeah, this is one of those things that are REALLY a matter of taste and
a matter of what you are used to.
I always have preferred this style, having the variables declared as
close to first use as rea
On Mon, 2013-12-16 at 09:14 +0100, Anton Lundin wrote:
> On 15 December, 2013 - Thiago Macieira wrote:
>
> > On domingo, 15 de dezembro de 2013 20:28:44, Henrik Brautaset Aronsen wrote:
> > > Dirk Hohndel wrote:
> > > > It's finding plugins from your local directories.
> > > > Move Marble out of /
On Mon, 2013-12-16 at 09:14 +0100, Robert Helling wrote:
> On 16.12.2013, at 00:40, Dirk Hohndel wrote:
>
> Dirk,
>
> > Something like: a 4 weeks window to merge new features after a release.
> > Then 8 weeks of bug fixing, documenting, translating, and finally a week
> > to do the release. Whic
Signed-off-by: Thiago Macieira
---
dive.h | 2 --
parse-xml.c | 3 +--
qt-gui.cpp | 1 -
3 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/dive.h b/dive.h
index 0ee3a1a..46c42fc 100644
--- a/dive.h
+++ b/dive.h
@@ -637,8 +637,6 @@ extern void shift_times(const timestamp_t amount
This patch series moves the .xslt files and the xslt/ subdir in the
installation into a Qt resource. That means it's in a read-only
section of memory instead of on disk. Benefits are that we don't need
to install and manage the files, nor play tricks to find them at
runtime. Drawbacks are that they
This avoids having to remember to free it at every point. This is C++,
we have destructors :-)
Signed-off-by: Thiago Macieira
---
qt-ui/subsurfacewebservices.cpp | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/qt-ui/subsurfacewebservices.cpp b/qt-ui/s
Signed-off-by: Thiago Macieira
---
qt-ui/subsurfacewebservices.cpp | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/qt-ui/subsurfacewebservices.cpp b/qt-ui/subsurfacewebservices.cpp
index 775c7b1..f9b6647 100644
--- a/qt-ui/subsurfacewebservices.cpp
Makes the code easier to read, IMHO.
Signed-off-by: Thiago Macieira
---
qt-ui/subsurfacewebservices.cpp | 39 +--
1 file changed, 17 insertions(+), 22 deletions(-)
diff --git a/qt-ui/subsurfacewebservices.cpp b/qt-ui/subsurfacewebservices.cpp
index f9b6647..2
This patch series continues the refactoring of the zip-creation code
that I started for 4.0. While for 4.0 they were just bugfixes, this is
now pure refactoring and makes the code more C++-like. Sorry, Lubomir...
An added benefit is that this now creates proper, translated error
messages about the
This is so we can mark the error messages for translation.
Signed-off-by: Thiago Macieira
---
qt-ui/subsurfacewebservices.cpp | 2 +-
qt-ui/subsurfacewebservices.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/qt-ui/subsurfacewebservices.cpp b/qt-ui/subsurfacewebservices
On 16/12/2013 17:54, Miika Turkia wrote:
Works for me now on Ubuntu as well. Asciidoc dependency was missing in
control file, thus the html was never created while building the
package. I should have checked the real build logs instead of trying
to manually figure out why it is missing. Sorry f
Works for me now on Ubuntu as well. Asciidoc dependency was missing in
control file, thus the html was never created while building the package. I
should have checked the real build logs instead of trying to manually
figure out why it is missing. Sorry for the unnecessary hassle regarding
this.
mi
We are very active on irc. =)
Em 16/12/2013 04:24, "Willem Ferguson"
escreveu:
> Dirk and his team,
>
> There is a place where the diving community should thank you for what you
> have put into this project and this is probably the place The energy that
> you put into this was just amazing. The p
Hi,
since the bug is still present in version 4.0, I created
a tracker ticket for it: https://trac.hohndel.org/ticket/368
Regards,
Lutz Vieweg
___
subsurface mailing list
subsurface@hohndel.org
http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurf
The info icon of the manual got mislaid somewhere. Here it is.
Kind regards,
willmf
>From 136b56eea2a2f7d86d81fb3bea48f7654f259669 Mon Sep 17 00:00:00 2001
From: Dirk Hohndel
Date: Sun, 15 Dec 2013 14:26:11 -0800
Subject: [PATCH 1/2] Final update to ReleaseNotes for 4.0
Signed-off-by: Dirk Hohn
On 15 December, 2013 - Thiago Macieira wrote:
> On domingo, 15 de dezembro de 2013 20:28:44, Henrik Brautaset Aronsen wrote:
> > Dirk Hohndel wrote:
> > > It's finding plugins from your local directories.
> > > Move Marble out of /usr/local/ and this will work
> > >
> > > I still have no handle o
On 16.12.2013, at 00:40, Dirk Hohndel wrote:
Dirk,
> Something like: a 4 weeks window to merge new features after a release.
> Then 8 weeks of bug fixing, documenting, translating, and finally a week
> to do the release. Which gives us quarterly releases.
I am a bit hesitant about this. For dy
41 matches
Mail list logo
