[PATCH] Ignore mouse wheel events on tags widget

2014-01-19 Thread Sergey Starosek
This prevents tags widgets (dive tags and buddy) from grabbing focus on mouse wheel events but allows entering dive edit mode on mouse click. It was attempted earlier by Dirk (commit d117beca), but edit mode did not work properly. Signed-off-by: Sergey Starosek sergey.staro...@gmail.com ---

Re: faster representation of pow on some áreas of subsurface?

2014-01-19 Thread Tomaz Canabrava
dunno about the patch, never got into my branch :) On Sun, Jan 19, 2014 at 6:00 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Sun, Jan 19, 2014 at 11:29 AM, Tomaz Canabrava tcanabr...@kde.org wrote: I'v replaced the pow() call with the fastPow() that I found on the

[PATCH] Use focus policy setting from widget constructor

2014-01-19 Thread Sergey Starosek
Since we use tags widget for several input fields (tags, buddy, divemaster), it makes sense to keep focus policy setting in one place. Signed-off-by: Sergey Starosek sergey.staro...@gmail.com --- qt-ui/maintab.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/qt-ui/maintab.cpp

Re: [PATCH] Stop doing the (very expensive) pow() calculation pointlessly

2014-01-19 Thread Tomaz Canabrava
The result of this patch is this: http://wstaw.org/m/2014/01/19/plasma-desktopujz493.png it still looks like it deserves some kind of special treatment, but it's way faster now. On Sun, Jan 19, 2014 at 6:37 PM, Tomaz Canabrava tcanabr...@kde.org wrote: Linus, it makes things instant. *NOW* we

Re: faster representation of pow on some áreas of subsurface?

2014-01-19 Thread Dirk Hohndel
On Jan 19, 2014, at 11:29 AM, Tomaz Canabrava tcanabr...@kde.org wrote: People, I noticed a little lag while switching dives on the new profile, thing that I tougth it shouldn't exist because the new code of the profile tries real hard to be very responsive, then I fired callgrind to

Re: faster representation of pow on some áreas of subsurface?

2014-01-19 Thread Dirk Hohndel
On Jan 19, 2014, at 12:14 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Sun, Jan 19, 2014 at 12:01 PM, Tomaz Canabrava tcanabr...@kde.org wrote: dunno about the patch, never got into my branch :) Ok, I just re-sent it. I didn't even realize that it never got committed

Re: [PATCH] Stop doing the (very expensive) pow() calculation pointlessly

2014-01-19 Thread Linus Torvalds
On Sun, Jan 19, 2014 at 1:03 PM, Linus Torvalds torva...@linux-foundation.org wrote: The second patch has that simplify calculate_deco_information part in it too (in *addition* to the 60s TTS interval change that is in the first one). Actually, that second patch is slightly buggy, although

Re: [PATCH] Stop doing the (very expensive) pow() calculation pointlessly

2014-01-19 Thread Dirk Hohndel
On Jan 19, 2014, at 1:03 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Sun, Jan 19, 2014 at 12:42 PM, Tomaz Canabrava tcanabr...@kde.org wrote: The result of this patch is this: http://wstaw.org/m/2014/01/19/plasma-desktopujz493.png it still looks like it deserves some kind of

Re: faster representation of pow on some áreas of subsurface?

2014-01-19 Thread Dirk Hohndel
On Jan 19, 2014, at 1:58 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Sun, Jan 19, 2014 at 1:41 PM, Dirk Hohndel d...@hohndel.org wrote: OK, I compared the results for a number of test dives and they are identical. They had better be. The Stop doing the (very expensive)

Re: faster representation of pow on some áreas of subsurface?

2014-01-19 Thread Linus Torvalds
On Sun, Jan 19, 2014 at 2:02 PM, Dirk Hohndel d...@hohndel.org wrote: Whether this difference matters enough to us is a different question, but at least what is reported to the user is quite significantly different. I think you're confusing two issues. The 10s vs 60s change in the TTS

Re: [PATCH] Stop doing the (very expensive) pow() calculation pointlessly

2014-01-19 Thread Linus Torvalds
On Sun, Jan 19, 2014 at 2:06 PM, Linus Torvalds torva...@linux-foundation.org wrote: But I actually think that's more correct! Without that, your TTS is calculated as you can go up 3 meters every ten seconds. Which is borderline fine, but is that really a good assumption? That's 18m/minute.

Re: sunday patches.

2014-01-19 Thread Tomaz Canabrava
xiu, don't forget my patches. :) On Sun, Jan 19, 2014 at 8:20 PM, Tomaz Canabrava tcanabr...@kde.org wrote: This set of patches improves greatly the uglyness of the new profile. now, fixing the size and placement of the time axis and depth axis should fix the rest. :)