Re: Infobox math broken in current master

2014-01-21 Thread Dirk Hohndel
On Mon, 2014-01-20 at 11:28 +0100, Robert Helling wrote: On 20.01.2014, at 10:29, Robert Helling hell...@lmu.de wrote: Hi, But probably more important: The freezing of the info box and the crash go away once I comment out line 178 of diveprofileitem.cpp as looked deeper into this.

Re: Infobox math broken in current master

2014-01-21 Thread Dirk Hohndel
On Tue, 2014-01-21 at 18:27 +0100, Robert C. Helling wrote: On 21 Jan 2014, at 18:13, Dirk Hohndel d...@hohndel.org wrote: Dirk, I don't like this patch. It's much better to test min == max. the problem is that this compares floats with the usual problems. Is it clear that min

Re: More profile goodness

2014-01-21 Thread Tomaz Canabrava
last forgotten one. On Tue, Jan 21, 2014 at 3:37 PM, Tomaz Canabrava tcanabr...@kde.org wrote: From b2432c22892e30a61bdf4ca17edd24e53c32910f Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava tcanabr...@kde.org Date: Tue, 21 Jan 2014 15:41:04 -0200 Subject: [PATCH 8/8] Remember to clean the

Re: Infobox math broken in current master

2014-01-21 Thread Robert C. Helling
On 21 Jan 2014, at 18:36, Dirk Hohndel d...@hohndel.org wrote: Dirk, But given where min and max come from, we know that they are either identical, or at least 0.1 apart. So a division will ONLY create a NaN if they are identical. this is in the abstract axis code, so it is used for all

Re: Infobox math broken in current master

2014-01-21 Thread Dirk Hohndel
On Tue, 2014-01-21 at 19:00 +0100, Robert C. Helling wrote: On 21 Jan 2014, at 18:36, Dirk Hohndel d...@hohndel.org wrote: Dirk, But given where min and max come from, we know that they are either identical, or at least 0.1 apart. So a division will ONLY create a NaN if they are

Re: More profile goodness

2014-01-21 Thread Tomaz Canabrava
and now, with ceilings. 3 ( works with the preferences too. ) On Tue, Jan 21, 2014 at 3:42 PM, Tomaz Canabrava tcanabr...@kde.org wrote: last forgotten one. On Tue, Jan 21, 2014 at 3:37 PM, Tomaz Canabrava tcanabr...@kde.orgwrote: From 831690f9e4c051a2414c2b1217db6f9cc8b1f420 Mon Sep

Re: Infobox math broken in current master

2014-01-21 Thread Robert C. Helling
On 21 Jan 2014, at 20:27, Dirk Hohndel d...@hohndel.org wrote: Yes, it might be 0.01 - or maybe even 0.001. But we don't do anything in graphs that has a resolution anywhere close where 1 / size is going to be NaN unless min and max are identical. As requested, this version with macro.

Don't compare floats for equality

2014-01-21 Thread Robert C. Helling
Now that we have a macro to replace float equality testing, we should use it in places where floating point jitter might bite use otherwise. 0001-Having-a-better-floating-point-equality-test-we-shou.patch Description: Binary data --

Re: More profile goodness

2014-01-21 Thread Dirk Hohndel
As to your suggestion in one of the comments... there's a debate between the people who are wrong (Linus, others) that prefer the ceiling to be just a 'hole' in the graph and those of us who want the ceiling to stand out and therefore want it RED. Being a kind and understanding maintainer I

[PATCH] Fix creating the list of Qt translation files under Qt5

2014-01-21 Thread Thiago Macieira
We were apparently exploiting a bug in qmake for Qt 4. The $$join function in Qt 5 is fixed: it returns a single string, not a list with multiple elements. Instead, we just iterate over the element list. Signed-off-by: Thiago Macieira thi...@macieira.org --- subsurface-install.pri | 8 ++--

Re: [PATCH] Stop doing the (very expensive) pow() calculation pointlessly

2014-01-21 Thread Linus Torvalds
On Tue, Jan 21, 2014 at 7:49 AM, Dirk Hohndel d...@hohndel.org wrote: On Sun, 2014-01-19 at 14:21 -0800, Linus Torvalds wrote: So the TTS code is actually being overly conservative. So what's the conclusion here (I know you are knee deep in the merge window, but I want to close on this)? I

[PATCH] Add info to the CodingStyle for C++ constructors

2014-01-21 Thread Thiago Macieira
Signed-off-by: Thiago Macieira thi...@macieira.org --- CodingStyle | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/CodingStyle b/CodingStyle index 82c86e5..52f00fa 100644 --- a/CodingStyle +++ b/CodingStyle @@ -50,6 +50,16 @@ b = a + (c + d +