Re: Subsurface on Android and desktop

2014-03-03 Thread Dirk Hohndel
Quick response from my phone. Linus and I discussed this in detail. He is working on a new storage backbend for subsurface that will allow keeping desktop and mobile (or other multiple instance configurations) consistent and in sync. He is distracted by his other little open source project, but w

Subsurface on Android and desktop

2014-03-03 Thread Willem Ferguson
The new developments about getting Subsurface running on Android is exciting. However, this brings the need to, at this stage already, have a vision for how the portable (=Android) and desktop-based versions will interact. The most important issue is how a diver will share his/her dive informat

Re: [PATCH] Make Marble optional

2014-03-03 Thread Alberto Corona
Here's the link again as I forgot to include the list https://github.com/0x1A/subsurface/commit/eb215101097120f8c62339fd767b71574cdd0bbd Like Anton said, this is a bit hacky, though I don't think there's a very easy way to do so without reworking quite a bit of the mainwindow (for which I'm too in

Re: [PATCH] Make Marble optional

2014-03-03 Thread Dirk Hohndel
On Mon, 2014-03-03 at 18:17 -0600, Alberto Corona wrote: > Ok so I've got things working now, though I'd like to see if Anton is > ok with the changes. Unfortunately, I'm not familiar enough with Qt to > change the way the splitters work in order to get rid of the blank > dummy widget. > And wher

Re: [PATCH] Make Marble optional

2014-03-03 Thread Alberto Corona
Ok so I've got things working now, though I'd like to see if Anton is ok with the changes. Unfortunately, I'm not familiar enough with Qt to change the way the splitters work in order to get rid of the blank dummy widget. On Sat, Mar 1, 2014 at 10:01 AM, Alberto Corona wrote: > Again, I apologi

[PATCH 1/1] Update the README file part about commit messages

2014-03-03 Thread Thiago Macieira
Link to the official home of the developer certificate of origin and clarify some details about commit messages, as discussed on the mailing list. Signed-off-by: Thiago Macieira --- README | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/README b/README index 84

Re: CodingStyle

2014-03-03 Thread Dirk Hohndel
On Mon, 2014-03-03 at 07:37 -0800, Dirk Hohndel wrote: > > > At this point, the C/C++/h files have been reformatted using my clang > > > tool. Some things are not as I would love them to be (e.g. what was done > > > to the enums), but as I said when I announced that commit - this is > > > better th

[PATCH 2/2] Depth widget minor UX improvement

2014-03-03 Thread Andrey Zhdanov
Decrease depth by tapping left part of widget. Icon is showing "up" (i.e. closer to surface). Increase depth by tapping right part of widget. Icon is showing "down" (i.e. deeper). Fixes #354 Signed-off-by: Andrey Zhdanov --- qt-ui/diveplanner.cpp | 10 -- 1 file changed, 4 insertions(

Re: [PATCH] Correct typo in partial pressure abbreviations (e.g. pn2 -> pN2)

2014-03-03 Thread Thiago Macieira
Em seg 03 mar 2014, às 17:35:58, Giuseppe 'ferdy' Miceli escreveu: > +Enable the pN2 Graph You could also write pN₂. We have that Unicode character... -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Cen

Re: [PATCH] Added .DS_Store file to .gitignore

2014-03-03 Thread Dirk Hohndel
On Mon, 2014-03-03 at 12:25 -0800, Thiago Macieira wrote: > Em seg 03 mar 2014, às 09:37:13, Dirk Hohndel escreveu: > > On Mon, 2014-03-03 at 17:05 +0100, Giuseppe 'ferdy' Miceli wrote: > > > Shall we have git ignore annoying MacOSX's .DS_Store file as well? > > > > Good idea. > > > > minor style

Re: Translate missing phrases

2014-03-03 Thread Dirk Hohndel
On Mon, 2014-03-03 at 13:50 +0200, Andrejs Zdanovs wrote: > As from today's IRC chat and after my yesterday's discover while > localizing into Latvian language -- there are missing phrases that > don't appear neither in the Transifex or in .ts files that are in > current branch. > For example, main

Re: [PATCH] Added .DS_Store file to .gitignore

2014-03-03 Thread Thiago Macieira
Em seg 03 mar 2014, às 09:37:13, Dirk Hohndel escreveu: > On Mon, 2014-03-03 at 17:05 +0100, Giuseppe 'ferdy' Miceli wrote: > > Shall we have git ignore annoying MacOSX's .DS_Store file as well? > > Good idea. > > minor style suggestion - I prefer commit messages in present tense. The > message d

Re: PATCH for ticket #418

2014-03-03 Thread Dirk Hohndel
On Mon, 2014-03-03 at 22:42 +0530, Gopichand Paturi wrote: > Hello All, > I am attaching the patch for ticket #418. My logic was that I thought > the argument numbers given there for example %6%7 are %5%6...the > interchanging of East and West is probably happening here. The fix looks correct, bu

Re: [PATCH 2/2] Correct typo in NDL abbr (NTL -> BDL)

2014-03-03 Thread Dirk Hohndel
On Mon, 2014-03-03 at 17:55 +0100, Giuseppe 'ferdy' Miceli wrote: > more nitpicking... > Subject: [PATCH 2/2] Correct typo in NDL abbr (NTL -> BDL) Awesome - a typo in the title of a patch correcting a typo. Priceless :-) /D ___ subsurface mailing lis

Re: [PATCH] Added .DS_Store file to .gitignore

2014-03-03 Thread Dirk Hohndel
On Mon, 2014-03-03 at 17:05 +0100, Giuseppe 'ferdy' Miceli wrote: > Shall we have git ignore annoying MacOSX's .DS_Store file as well? Good idea. minor style suggestion - I prefer commit messages in present tense. The message describes what the patch DOES, not what it DID :-) /D ___

PATCH for ticket #418

2014-03-03 Thread Gopichand Paturi
Hello All, I am attaching the patch for ticket #418. My logic was that I thought the argument numbers given there for example %6%7 are %5%6...the interchanging of East and West is probably happening here. So, I changed it. Though I could not reproduce the problem, since the saving activity was act

[PATCH 2/2] Correct typo in NDL abbr (NTL -> BDL)

2014-03-03 Thread Giuseppe 'ferdy' Miceli
more nitpicking... >From 5940d75258cd7c40d0694ddb9d1754b398e57700 Mon Sep 17 00:00:00 2001 From: Giuseppe 'ferdy' Miceli Date: Mon, 3 Mar 2014 17:42:59 +0100 Subject: [PATCH 2/2] Correct typo in NDL abbr (NTL -> BDL) More nitpicking... Signed-off-by: Giuseppe 'ferdy' Miceli --- qt-ui/mainwind

[PATCH] Correct typo in partial pressure abbreviations (e.g. pn2 -> pN2)

2014-03-03 Thread Giuseppe 'ferdy' Miceli
>From b2d4cd741cbe1c7c5a63c37478b4ea94e5348823 Mon Sep 17 00:00:00 2001 From: Giuseppe 'ferdy' Miceli Date: Mon, 3 Mar 2014 17:27:03 +0100 Subject: [PATCH] Correct typo in partial pressure abbreviations (e.g. pn2 -> pN2) Partial pressures abbreviations should have capitalized chemical element sy

[PATCH] Added .DS_Store file to .gitignore

2014-03-03 Thread Giuseppe 'ferdy' Miceli
Shall we have git ignore annoying MacOSX's .DS_Store file as well? >From 6d98613012b48eeb7e2360dcc956ee2c9105125a Mon Sep 17 00:00:00 2001 From: Giuseppe 'ferdy' Miceli Date: Mon, 3 Mar 2014 16:57:41 +0100 Subject: [PATCH] Added .DS_Store file to .gitignore Signed-off-by: Giuseppe 'ferdy' Micel

Re: CodingStyle

2014-03-03 Thread Dirk Hohndel
On Mon, 2014-03-03 at 16:17 +0100, Cristian Ionescu-Idbohrn wrote: > On Mon, 3 Mar 2014, Dirk Hohndel wrote: > > On Mon, 2014-03-03 at 15:41 +0100, Cristian Ionescu-Idbohrn wrote: > > > Emacs has the ability to learn coding styles. > > > > Cool, I had never used that before. > > > > > Dirk, > > > >

Re: CodingStyle

2014-03-03 Thread Cristian Ionescu-Idbohrn
On Mon, 3 Mar 2014, Dirk Hohndel wrote: > On Mon, 2014-03-03 at 15:41 +0100, Cristian Ionescu-Idbohrn wrote: > > Emacs has the ability to learn coding styles. > > Cool, I had never used that before. > > > Dirk, > > > > Could you please point out a few files that could be used as > > templates? > >

Re: CodingStyle

2014-03-03 Thread Dirk Hohndel
On Mon, 2014-03-03 at 15:41 +0100, Cristian Ionescu-Idbohrn wrote: > Emacs has the ability to learn coding styles. Cool, I had never used that before. > Dirk, > > Could you please point out a few files that could be used as > templates? At this point, the C/C++/h files have been reformatted usi

Re: Gsoc idea: Android downloader

2014-03-03 Thread Dirk Hohndel
On Mon, 2014-03-03 at 15:24 +0100, Anton Lundin wrote: > > The serial api may not be exposed to the java world, but it is certainly > > usable from native code. As far as I know, you only needed a few minor > > tweaks to compile libdivecomputer for Android [1]. Once we have that, an > > Android app

CodingStyle

2014-03-03 Thread Cristian Ionescu-Idbohrn
Emacs has the ability to learn coding styles. Given a properly formated file, one can issue the command: M-x c-set-style Which C/l indentation style? linux Than command: M-x c-guess-buffer-no-install To find out what the guessed style is, use the command: M-x c-

Re: GSOC 2014

2014-03-03 Thread Dirk Hohndel
On Mon, 2014-03-03 at 19:08 +0530, abhijeet mohan wrote: > Hello everyone! > > > My name is Abhijeet Mohan, b-tech undergrad from India. > > > I am taking part in GSOC this year and want to contribute to > subsurface. > > > I have read the ideas page and found one topic which suits my interes

GSOC 2014

2014-03-03 Thread abhijeet mohan
Hello everyone! My name is Abhijeet Mohan, b-tech undergrad from India. I am taking part in GSOC this year and want to contribute to subsurface. I have read the ideas page and found one topic which suits my interest and i.e "Aadding integration with more online divelogs". I have good experience

Re: Gsoc idea: Android downloader

2014-03-03 Thread Anton Lundin
On 03 March, 2014 - Jef Driesen wrote: > On 2014-02-26 09:45, Anton Lundin wrote: > >One idea i bin playing with is how to make the Android port capable of > >downloading data from divecomputers. > > A port of libdivecomputer to Android is also something I'm interested in. > Bringing your smartph

Re: Gsoc idea: Android downloader

2014-03-03 Thread Jef Driesen
On 2014-02-26 09:45, Anton Lundin wrote: One idea i bin playing with is how to make the Android port capable of downloading data from divecomputers. A port of libdivecomputer to Android is also something I'm interested in. Bringing your smartphone or tablet near the dive site is far more conv

[Patch] Bug #138 - Add a map picker in Subsurface companion android application

2014-03-03 Thread Venkatesh Shukla B.Tech., Electrical, IIT-BHU, Varanasi (INDIA)
Hello I have attached the Patch for Bug #138 - Add a map picker for subsurface companion android application. In order to save locations, a map picker is included in the add option. This feature is very handy for people with android devices. One could chose th

Translate missing phrases

2014-03-03 Thread Andrejs Zdanovs
As from today's IRC chat and after my yesterday's discover while localizing into Latvian language -- there are missing phrases that don't appear neither in the Transifex or in .ts files that are in current branch. For example, mainwindow.ui don't have translated tooltips messages at all (for left v