Re: [PATCH] Make Marble optional

2014-03-06 Thread Alberto Corona
I'll make sure to console the rest and see how they think this should be implemented. I haven't yet attempted a cross compile using this method (without using marble), I'll also make sure to try to test that as best I could both for the cross compiliing scripts and native. In the sense of complilin

Re: [PATCH] Make Marble optional

2014-03-06 Thread Anton Lundin
On 06 March, 2014 - Alberto Corona wrote: > Compiling on other systems should not be affected as long as the name for > the marble library is the same on those systems. There are support for a different library name. Have you tried to investigate why its there? If its not needed anymore, remove

Re: Update Checking

2014-03-06 Thread Joshua Joseph
On Fri, Mar 7, 2014 at 4:37 AM, Thiago Macieira wrote: > Em qui 06 mar 2014, às 11:08:00, Thiago Macieira escreveu: >> Em qui 06 mar 2014, às 11:03:17, Dirk Hohndel escreveu: >> > BTW: is there a QT function that gives us a nice "OS Version"? >> > I looked at QSysInfo and that's not all that usefu

[PATCH 2/2] Move 'planner' qmake option to subsurface-configure

2014-03-06 Thread Alberto Corona
Move the planner enabling option with the rest of subsurface configuration options Signed-off-by: Alberto Corona --- subsurface-configure.pri | 5 + subsurface.pro | 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/subsurface-configure.pri b/subsurface-config

Re: [PATCH] Make Marble optional

2014-03-06 Thread Alberto Corona
Compiling on other systems should not be affected as long as the name for the marble library is the same on those systems. Again, like I said before, I'm far too unfamiliar with Qt to be able to make the changes to the main window to hide the dummy widget. Compiling on Windows natively is already a

Re: RFC: Initial git save format

2014-03-06 Thread Linus Torvalds
On Thu, Mar 6, 2014 at 4:29 PM, Dirk Hohndel wrote: > > So what about 'trip membership' - is the location in the tree relevant > for that? Yes, it would nest like the XML thing nests (ie one level only), but would be the only actual nesting. And from an implementation standpoint, that would be a

Re: RFC: Initial git save format

2014-03-06 Thread Dirk Hohndel
On Thu, 2014-03-06 at 16:20 -0800, Linus Torvalds wrote: > On Thu, Mar 6, 2014 at 3:20 PM, Dirk Hohndel wrote: > > > > The problem with that is that it exposes terminology to Joe and Jane > > Diver that I'd prefer to hide from them. > > Actually, with the git save-file, my *preference* would be t

Re: RFC: Initial git save format

2014-03-06 Thread Linus Torvalds
On Thu, Mar 6, 2014 at 3:20 PM, Dirk Hohndel wrote: > > The problem with that is that it exposes terminology to Joe and Jane > Diver that I'd prefer to hide from them. Actually, with the git save-file, my *preference* would be that the default filename configuration would basically become a non-i

Re: Update Checking

2014-03-06 Thread Thiago Macieira
Em qui 06 mar 2014, às 11:08:00, Thiago Macieira escreveu: > Em qui 06 mar 2014, às 11:03:17, Dirk Hohndel escreveu: > > BTW: is there a QT function that gives us a nice "OS Version"? > > I looked at QSysInfo and that's not all that useful. > > > > I was thinking of something like a little more ve

Re: RFC: Initial git save format

2014-03-06 Thread Dirk Hohndel
On Thu, 2014-03-06 at 15:03 -0800, Linus Torvalds wrote: > On Thu, Mar 6, 2014 at 1:54 PM, Dirk Hohndel wrote: > > > > how do you intend the actual UI to work? > > Ideally this would be a "no user interaction UI" in most cases. I don't > > want divers to have to wonder what we might mean by "branc

Re: RFC: Initial git save format

2014-03-06 Thread Linus Torvalds
On Thu, Mar 6, 2014 at 2:51 PM, Dirk Hohndel wrote: > > If you don't mind I'd add this to your previous commit - this way I have > one fewer possible "doesn't compile" point when doing a git bisect in > the future. > > You also forgot a commit message and SOB... I actually intended for you to jus

Re: RFC: Initial git save format

2014-03-06 Thread Linus Torvalds
On Thu, Mar 6, 2014 at 1:54 PM, Dirk Hohndel wrote: > > how do you intend the actual UI to work? > Ideally this would be a "no user interaction UI" in most cases. I don't > want divers to have to wonder what we might mean by "branch" and other > strange terminology... So my expectation is that we

Re: RFC: Initial git save format

2014-03-06 Thread Dirk Hohndel
If you don't mind I'd add this to your previous commit - this way I have one fewer possible "doesn't compile" point when doing a git bisect in the future. You also forgot a commit message and SOB... /D On Thu, 2014-03-06 at 14:40 -0800, Linus Torvalds wrote: > On Thu, Mar 6, 2014 at 2:29 PM, Li

Re: RFC: Initial git save format

2014-03-06 Thread Dirk Hohndel
On Thu, 2014-03-06 at 14:29 -0800, Linus Torvalds wrote: > On Thu, Mar 6, 2014 at 2:03 PM, Dirk Hohndel wrote: > > > > compiling save-git.c > > save-git.c: In function ‘create_new_commit’: > > save-git.c:569:3: error: too many arguments to function ‘git_branch_create’ > > save-git.c:572:2: error:

Re: RFC: Initial git save format

2014-03-06 Thread Linus Torvalds
On Thu, Mar 6, 2014 at 2:29 PM, Linus Torvalds wrote: > > I'll have to figure out the versioning, it is not obvious where that happens. > > Damn library authors that don't get the whole "you need to get versioning > right" This patch on top of the earlier one seems to make it compile both with c

Re: RFC: Initial git save format

2014-03-06 Thread Linus Torvalds
On Thu, Mar 6, 2014 at 2:03 PM, Dirk Hohndel wrote: > > compiling save-git.c > save-git.c: In function ‘create_new_commit’: > save-git.c:569:3: error: too many arguments to function ‘git_branch_create’ > save-git.c:572:2: error: too many arguments to function > ‘git_reference_set_target’ Ok, it

Re: RFC: Initial git save format

2014-03-06 Thread Dirk Hohndel
On Thu, 2014-03-06 at 13:28 -0800, Linus Torvalds wrote: > So Dirk knows about this effort, and it's been rattling around in my > head for a long while, but it took some time for me to digest how to > actually do it. When I saw your G+ post I was trying to remember when we first started talking ab

Re: RFC: Initial git save format

2014-03-06 Thread Tomaz Canabrava
Linus, I can probably do the Qt UI in about 2h ( learning what need to be done on the UI, of course, never played with libgit. ) So, if this enters on subsurface master, I'll do the UI this weekend. Tomaz On Thu, Mar 6, 2014 at 6:28 PM, Linus Torvalds < torva...@linux-foundation.org> wrote: >

RFC: Initial git save format

2014-03-06 Thread Linus Torvalds
So Dirk knows about this effort, and it's been rattling around in my head for a long while, but it took some time for me to digest how to actually do it. The attached patch is a *rough* initial implementation. I say rough, because: (a) I didn't do the git configuration part, particularly not the

Re: Import from webservice

2014-03-06 Thread Dirk Hohndel
On Thu, 2014-03-06 at 20:02 +0100, Jan Birk wrote: > Den 06-03-2014 19:41, Dirk Hohndel skrev: > > The idea is that you download the dive from your dive computer (or > > manually add it to the dive log). Then downloading the location data > > from the web service will match the location to the dive

Re: Update Checking

2014-03-06 Thread Dirk Hohndel
On Thu, 2014-03-06 at 10:57 -0800, Thiago Macieira wrote: > Em qua 05 mar 2014, às 16:50:20, Joshua Joseph escreveu: > > Hi, > > > > The attached patch implements the check for updates feature for windows and > > mac. > > Why are you translating the URL? Do you expect it to be localised? Missed

Re: Update Checking

2014-03-06 Thread Joshua Joseph
On 3/6/14, Thiago Macieira wrote: > This is what I meant in the other email: why are you requesting that the URL > > be translated? > I overlooked this. I will change it. ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bi

Re: Update Checking

2014-03-06 Thread Joshua Joseph
On 3/6/14, Dirk Hohndel wrote: > On Wed, 2014-03-05 at 16:50 +0300, Joshua Joseph wrote: > when presenting the link with the latest version - can this be made > clickable so that it open that link in a browser (and therefore starts > the download)? I will check on this. The link is clickable on m

Re: Update Checking

2014-03-06 Thread Thiago Macieira
Em qui 06 mar 2014, às 11:03:17, Dirk Hohndel escreveu: > BTW: is there a QT function that gives us a nice "OS Version"? > I looked at QSysInfo and that's not all that useful. > > I was thinking of something like a little more versatile There is QSysInfo::macVersion() and QSysInfo::windowsVersion

Re: Update Checking

2014-03-06 Thread Thiago Macieira
Em qua 05 mar 2014, às 16:50:20, Joshua Joseph escreveu: > +UpdateManager::UpdateManager(QObject *parent) : > + QObject(parent) > +{ > + manager = new QNetworkAccessManager(this); We have a global QNetworkAccessManager singleton already (see WebServices::manager()). Please use it inst

Re: [PATCH] Make Marble optional

2014-03-06 Thread Anton Lundin
On 05 March, 2014 - Alberto Corona wrote: > I hate gmail, still need to configure my mutt. For the list: > > Sure, the reason I didn't send the patch initially was to see if you were > alright with the changes. Would a warning or verbose message that > subsurface was build without marble really b

Re: Update Checking

2014-03-06 Thread Thiago Macieira
Em qua 05 mar 2014, às 16:50:20, Joshua Joseph escreveu: > Hi, > > The attached patch implements the check for updates feature for windows and > mac. Why are you translating the URL? Do you expect it to be localised? -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Softwa

Re: Import from webservice

2014-03-06 Thread Jan Birk
Den 06-03-2014 19:41, Dirk Hohndel skrev: The idea is that you download the dive from your dive computer (or manually add it to the dive log). Then downloading the location data from the web service will match the location to the dive(s) that are already in the dive list. Makes sense? Sure, bu

Re: Update Checking

2014-03-06 Thread Dirk Hohndel
On Wed, 2014-03-05 at 16:50 +0300, Joshua Joseph wrote: > Hi, > > The attached patch implements the check for updates feature for windows and > mac. A few comments... I would much rather like the app to figure out the OS it's running on at runtime. It would be useful for us to know if people ru

Re: Import from webservice

2014-03-06 Thread Dirk Hohndel
On Thu, 2014-03-06 at 19:33 +0100, Jan Birk wrote: > Hi, > > I am a bit confused about how webservice download works : > > 1) I add a dive in the Android Companion App, name and position. > 2) In Subsurface; > > a) Import->Import GPS ... from webservice > b) Clik 'Download' and Subsurface says

Import from webservice

2014-03-06 Thread Jan Birk
Hi, I am a bit confused about how webservice download works : 1) I add a dive in the Android Companion App, name and position. 2) In Subsurface; a) Import->Import GPS ... from webservice b) Clik 'Download' and Subsurface says "Download succes" I see in the manual that the time-spand has to be

Re: [PATCH] Fixed layout of yearly statistics model

2014-03-06 Thread Dirk Hohndel
On Thu, 2014-03-06 at 18:59 +0530, Heena Mahour wrote: > > From aacfca96716bbb82f6bb9b14e32e590c0c11ec7c Mon Sep 17 00:00:00 2001 > From: heena mahour > Date: Thu, 6 Mar 2014 18:52:36 +0530 > Subject: [PATCH 4/4] Signed-off-by: heena mahour > > > Yearly Statistics model > #This is my first pat

[PATCH] Fixed layout of yearly statistics model

2014-03-06 Thread Heena Mahour
>From aacfca96716bbb82f6bb9b14e32e590c0c11ec7c Mon Sep 17 00:00:00 2001 From: heena mahour Date: Thu, 6 Mar 2014 18:52:36 +0530 Subject: [PATCH 4/4] Signed-off-by: heena mahour Yearly Statistics model #This is my first patch Changes in the layout of the tree view ,set the pixel size, stretch, bo

[PATCH] Make it executable and remove magic whitespace on shebang line.

2014-03-06 Thread Cristian Ionescu-Idbohrn
Signed-off-by: Cristian Ionescu-Idbohrn --- scripts/whitespace.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) mode change 100644 => 100755 scripts/whitespace.pl diff --git a/scripts/whitespace.pl b/scripts/whitespace.pl old mode 100644 new mode 100755 index 0340d25..cc7c651 --- a/scr