On Mon, Mar 10, 2014 at 2:43 PM, Dirk Hohndel wrote:
>
> On Mon, 2014-03-10 at 14:02 -0500, Lakshman wrote:
> > > I'm still mulling over your other patch. I don't like it in the normal
> > > 'view' of Subsurface because it's redundant information (if there is a
> > > temperature, it's shown with a
On Mon, Mar 10, 2014 at 4:33 AM, Miika Turkia wrote:
> Features:
> - Show original time and new time when adjusting dive time on the dialog
>
> Bugs:
> - I have one DC recording near surface time properly another is not
> recording these times. This results in the second DC recording shorter dive
On 10 March 2014 21:51, Thiago Macieira wrote:
> Em seg 10 mar 2014, às 09:24:08, Dirk Hohndel escreveu:
>> I'll ask our resident compiler and language standards guru (Thiago) to
>> chime in here. I thought that the ISO standard requires the initializer
>> to be non-empty and that the '{}' initial
Em seg 10 mar 2014, às 09:24:08, Dirk Hohndel escreveu:
> I'll ask our resident compiler and language standards guru (Thiago) to
> chime in here. I thought that the ISO standard requires the initializer
> to be non-empty and that the '{}' initializer was a gcc-ism.
I've just taken a quick look at
On Mon, 2014-03-10 at 14:02 -0500, Lakshman wrote:
> > I'm still mulling over your other patch. I don't like it in the normal
> > 'view' of Subsurface because it's redundant information (if there is a
> > temperature, it's shown with a unit). But in edit and add mode I think
> > it's a great improv
On Mon, Mar 10, 2014 at 1:53 PM, Dirk Hohndel wrote:
> On Mon, 2014-03-10 at 13:49 -0500, Lakshman wrote:
>> On Mon, Mar 10, 2014 at 1:34 PM, Dirk Hohndel wrote:
>> > On Mon, 2014-03-10 at 12:19 -0500, Lakshman wrote:
>> >> Hello Dirk,
>> >>
>> >> May I know whether the patch attached is a valid
Em seg 10 mar 2014, às 11:21:11, Lakshman escreveu:
> Can you please clarify the following doubt regarding patch formatting. I
> made changes to the code by following all rules in `CodingStyle` file, and
> the code has 8 space chars for tab, etc, however in the patch, these are
> not reflected, is
On Mon, 2014-03-10 at 13:49 -0500, Lakshman wrote:
> On Mon, Mar 10, 2014 at 1:34 PM, Dirk Hohndel wrote:
> > On Mon, 2014-03-10 at 12:19 -0500, Lakshman wrote:
> >> Hello Dirk,
> >>
> >> May I know whether the patch attached is a valid attempt or not. I was
> >> doubtful whether this has been ign
On Mon, Mar 10, 2014 at 1:34 PM, Dirk Hohndel wrote:
> On Mon, 2014-03-10 at 12:19 -0500, Lakshman wrote:
>> Hello Dirk,
>>
>> May I know whether the patch attached is a valid attempt or not. I was
>> doubtful whether this has been ignored, so I double checked to make
>> sure I did include signed-
On Mon, 2014-03-10 at 10:18 -0700, Linus Torvalds wrote:
> On Mon, Mar 10, 2014 at 10:00 AM, Lubomir I. Ivanov
> wrote:
> >
> > hmm, isn't taglist_init_global() still supposed to be called in main()
> > so that the default tags are added?
>
> You're right. I removed taglist_init() because now it
On Mon, 2014-03-10 at 12:19 -0500, Lakshman wrote:
> Hello Dirk,
>
> May I know whether the patch attached is a valid attempt or not. I was
> doubtful whether this has been ignored, so I double checked to make
> sure I did include signed-off text. Can you please let me know in case
> I need to sub
On Mon, Mar 10, 2014 at 11:28 AM, Dirk Hohndel wrote:
>
> Would you mind adding a commit message and SOB?
The first patch had it already, the second patch is identical except
for just the trivial fixes. But here does.
Linus
---
Subject: Get rid of crazy empty tag_list element at the s
Hello Dirk,
May I know whether the patch attached is a valid attempt or not. I was
doubtful whether this has been ignored, so I double checked to make
sure I did include signed-off text. Can you please let me know in case
I need to submit something more meaningful, i.e. towards the code?
Also I am
On Mon, Mar 10, 2014 at 10:00 AM, Lubomir I. Ivanov wrote:
>
> hmm, isn't taglist_init_global() still supposed to be called in main()
> so that the default tags are added?
You're right. I removed taglist_init() because now it's just a regular
NULL pointer, but I think I went a bit overboard and r
On 10 March 2014 19:00, Lubomir I. Ivanov wrote:
> On 10 March 2014 18:42, Linus Torvalds wrote:
>> So this is totally unrelated to the git repository format, except for
>> the fact that I noticed it while writing the git saving code.
>>
>> The subsurface divetag list handling is being stupid, an
On 10 March 2014 18:42, Linus Torvalds wrote:
> So this is totally unrelated to the git repository format, except for
> the fact that I noticed it while writing the git saving code.
>
> The subsurface divetag list handling is being stupid, and has a
> initial dummy entry at the head of the list fo
So this is totally unrelated to the git repository format, except for
the fact that I noticed it while writing the git saving code.
The subsurface divetag list handling is being stupid, and has a
initial dummy entry at the head of the list for no good reason.
I say "no good reason", because there
On 10 March 2014 18:24, Dirk Hohndel wrote:
>> @@ -229,7 +229,7 @@ void DiveHeartrateItem::modelDataChanged(const
>> QModelIndex &topLeft, const QMode
>> struct {
>> int sec;
>> int hr;
>> - } hist[3] = { 0 };
>> + } hist[3] = {};
>
> I'll ask our residen
On Mon, 2014-03-10 at 13:43 +0200, Lubomir I. Ivanov wrote:
> From: "Lubomir I. Ivanov"
>
> Signed-off-by: Lubomir I. Ivanov
> ---
>
> last warning from -Wall with 4.4.0.
> ---
> qt-ui/profile/diveprofileitem.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qt-ui/p
On 10 March 2014 18:15, Dirk Hohndel wrote:
>
> Interesting issue here... with the changed .qrc file the dependency for
> the generated cpp file change - but the Makefile is not remade after
> applying this patch. So you have to manually run qmake or make will fail
> with missing dependencies.
>
>
On Mon, Mar 10, 2014 at 1:16 PM, Lubomir I. Ivanov wrote:
> On 10 March 2014 17:59, Lubomir I. Ivanov wrote:
> > From: "Lubomir I. Ivanov"
> >
> > This patch adds a new image resource named poster.png which,
> > is shown instead of the 3 posters. The main reason for that
> > is due to the poster
On 10 March 2014 17:59, Lubomir I. Ivanov wrote:
> From: "Lubomir I. Ivanov"
>
> This patch adds a new image resource named poster.png which,
> is shown instead of the 3 posters. The main reason for that
> is due to the poster text not being visible. This new image
> is pretty much the Subsurface
On Mon, 2014-03-10 at 17:59 +0200, Lubomir I. Ivanov wrote:
> From: "Lubomir I. Ivanov"
>
> This patch adds a new image resource named poster.png which,
> is shown instead of the 3 posters. The main reason for that
> is due to the poster text not being visible. This new image
> is pretty much the
From: "Lubomir I. Ivanov"
If the user has zoomed in but then changes to a new dive,
we may want to reset the scale back to the original value (1.0)
based on the current zoomLevel, so that the profile is not stuck
in zoomed mode.
This patch adds a snippet that resets the QGraphicsView scale,
zoom
Em seg 10 mar 2014, às 10:13:45, Lakshman escreveu:
> On Mon, Mar 10, 2014 at 10:07 AM, Thiago Macieira
wrote:
> > [%1]").arg(get_temp_unit().at(1)));
> >
> > Why do you have the at(1) there?
>
> Hi Thiago, I used 'at' to access the unit of the variable by ignoring
> degree symbol, which you sug
On Mon, Mar 10, 2014 at 10:07 AM, Thiago Macieira wrote:
> Em dom 09 mar 2014, às 20:52:11, Lakshman escreveu:
> > Thank you Thiago for helpful suggestions.
>
> Hello Lashman.
>
> Thanks for the update. The patch looks much better now. I just have one
> question:
>
> + ui.air
Em dom 09 mar 2014, às 20:52:11, Lakshman escreveu:
> Thank you Thiago for helpful suggestions.
Hello Lashman.
Thanks for the update. The patch looks much better now. I just have one
question:
+ ui.airTempLabel-
>setText(QApplication::translate("MainTab", "Air temp
[%1]")
From: "Lubomir I. Ivanov"
Such can be disabled with -Wno-reorder and are clearly
more of a nuisance, but C++98 12.6.2.5 says the order should be
the same as in the class declaration.
On theory this would only speed the compile times a tiny amount.
Signed-off-by: Lubomir I. Ivanov
---
one thing
From: "Lubomir I. Ivanov"
Signed-off-by: Lubomir I. Ivanov
---
last warning from -Wall with 4.4.0.
---
qt-ui/profile/diveprofileitem.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qt-ui/profile/diveprofileitem.cpp
b/qt-ui/profile/diveprofileitem.cpp
index 454fab0..b84
Features:
- Show original time and new time when adjusting dive time on the dialog
Bugs:
- I have one DC recording near surface time properly another is not
recording these times. This results in the second DC recording shorter dive
duration. And Subsurface seems to trust more the latter DC when r
On 2014-03-09 02:14, Harshit Gupta B.Tech., Electrical, IT-BHU, Varanasi
(INDIA) wrote:
I need some guidance from where I can study about how the desktop
application works or atleast give me the links , so that I can
understand
the code and try to implement it on Android. I asked this question o
Hi Robert,
With lots of effort and understanding that was needed, I am writing this.
It might look to you that I'm rushing, yes , because I have exams starting
from wednesday. But I'm not compromising on my efforts for understanding
VPM.
*This is my brief understanding of the VPM*
*About bubble
32 matches
Mail list logo
