[PATCH] Updates to sections 4 and 5 of the user manual

2014-03-15 Thread Willem Ferguson
A new figure is included to reflect the actions of the new profile buttons on the calculated ceilings. A number of small edits on sections 4 and 5 of the user manual are done. These sections are now finalised for the new release. Kind regards, willemf >From c72e40760da0bd7794bc7787c1799468eff813

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Dirk Hohndel
On Sat, 2014-03-15 at 17:54 -0700, Dirk Hohndel wrote: > > And right now I don't think we have any way to remove gas events... > > Details, details. I'll fix that. I just pushed a commit that fixes this. I have several doubts about the commit. a) I don't know why the selection with ->items() d

Re: facing problem in code compiling

2014-03-15 Thread Farzana Raisa
i am using ubuntu 12.04. I have solved the problem of libgit2. Here is how i solved it 1.Added experimental repository to ubuntu 2. Installed the libgit2 package Thank you all for your response On Sun, Mar 16, 2014 at 9:40 AM, Venkatesh Shukla IT BHU < venkatesh.shukla.ee...@itbhu.ac.in> wrote:

Error during compilation of Libdivecomputer for android

2014-03-15 Thread Venkatesh Shukla IIT BHU
Glance I have been trying to compile the libdivecomputer for android. I underwent the following steps. 1. I cloned your repo https://github.com/glance-/subsurface-android 2. I editted the build.sh script for proper path to android_sdk , android_ndk and Qt5.2.1 3. I ran the bash script using bash

Re: facing problem in code compiling

2014-03-15 Thread Venkatesh Shukla IT BHU
On Sun, Mar 16, 2014 at 12:53 AM, Lakshman wrote: > On Sat, Mar 15, 2014 at 2:14 PM, Dirk Hohndel wrote: > > On Sun, 2014-03-16 at 02:09 +0800, Farzana Raisa wrote: > >> I am facing problem in compiling your source code in ubuntu. Though i > >> have compiled livedivecomputer it is saying unable

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Dirk Hohndel
On Sat, 2014-03-15 at 17:19 -0700, Linus Torvalds wrote: > On Sat, Mar 15, 2014 at 1:57 PM, Dirk Hohndel wrote: > > > > Based on our logic you SHOULD NOT be able to delete either of the > > cylinders as they are both IN USE. You have to FIRST delete the gas > > change event (making the cylinder no

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Linus Torvalds
On Sat, Mar 15, 2014 at 1:57 PM, Dirk Hohndel wrote: > > Based on our logic you SHOULD NOT be able to delete either of the > cylinders as they are both IN USE. You have to FIRST delete the gas > change event (making the cylinder no longer in use) and THEN delete the > cylinder. Otherwise we end up

[PATCH] Test dive added

2014-03-15 Thread Jan Mulder
Simple test dive added to show the pp graph (in this case O2 only) being drawn incorrectly due to multiple gas switches to a hyperoxic gas (thus triggering the pO2 threshold setting). Bug already fixed in commit aa0cd792bbe3e5c2dbff77688f4ee96c694c. Patch file attached. best, --jan >

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Dirk Hohndel
On Sat, 2014-03-15 at 13:45 -0700, Dirk Hohndel wrote: > Brain fart. You are of course correct. Thanks for catching this. Speaking of Brain Farts. Yesterday was Pie Day. Today is humble pie day - at least for me. Trying to track down the bug you described when deleting a single cylinder I stepp

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Dirk Hohndel
On Sat, 2014-03-15 at 13:38 -0700, Linus Torvalds wrote: > On Sat, Mar 15, 2014 at 1:23 PM, Dirk Hohndel wrote: > > > > OK, I just pushed out two commits that make these two changes. > > Actually, I think the second one is buggy. > > You did this: > > if (i == 0 && !get_tanksize(devdata, da

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Linus Torvalds
On Sat, Mar 15, 2014 at 1:23 PM, Dirk Hohndel wrote: > > OK, I just pushed out two commits that make these two changes. Actually, I think the second one is buggy. You did this: if (i == 0 && !get_tanksize(devdata, data, dive->cylinder, i)) fill_default_cylinder(&dive->cylinder[i]);

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Dirk Hohndel
On Sat, 2014-03-15 at 21:07 +0100, Robert C. Helling wrote: > I think what Linus points out is quite important: It is quite > unfortunate that we treat “gas change” to be equivalent to “cylinder > index change”. We already had complaints from people who wanted to have > several cylinders containin

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Dirk Hohndel
On Sat, 2014-03-15 at 12:41 -0700, Linus Torvalds wrote: > On Sat, Mar 15, 2014 at 12:26 PM, Dirk Hohndel wrote: > > > > So here's what I'm proposing to fix the current implementation > > > > a) if no default cylinder is set, don't just use AL80. Disable the > > default cylinder logic > > > > b) i

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Robert C. Helling
On 15 Mar 2014, at 20:26, Dirk Hohndel wrote: Good evening gentlemen, >> In other words, "gas change" is a bit of a misnomer. It's a "cylinder >> index change". It's just that we call it gas change, because that's >> what it means in normal situations. >> >> Anyway, what we probably *should* d

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Linus Torvalds
On Sat, Mar 15, 2014 at 12:26 PM, Dirk Hohndel wrote: > > So here's what I'm proposing to fix the current implementation > > a) if no default cylinder is set, don't just use AL80. Disable the > default cylinder logic > > b) if a default cylinder is set, ONLY use it for the first cylinder of a > DC

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Dirk Hohndel
On Sat, 2014-03-15 at 10:46 -0700, Linus Torvalds wrote: > There are two bugs that shows in subsurface: > > - the "default cylinder" behavior is broken, broken, broken. You have > set your default cylinder to AL80 (which is actually the default if > nothing has been set manually), and at least on

Re: facing problem in code compiling

2014-03-15 Thread Lakshman
On Sat, Mar 15, 2014 at 2:14 PM, Dirk Hohndel wrote: > On Sun, 2014-03-16 at 02:09 +0800, Farzana Raisa wrote: >> I am facing problem in compiling your source code in ubuntu. Though i >> have compiled livedivecomputer it is saying unable to locate package >> libgit2-dev. What to do? > If you are u

Re: [PATCH] Improved handling of git syntax names with no git repository

2014-03-15 Thread Dirk Hohndel
On Sat, 2014-03-15 at 10:51 -0700, Linus Torvalds wrote: > On Fri, Mar 14, 2014 at 6:22 PM, Thiago Macieira wrote: > > > > So why didn't you start with 1 or -1? Did you use 8 for alignment on > > purpose? > > No, it's really just a random value that I wanted to be *somewhat* > unique while being

Re: facing problem in code compiling

2014-03-15 Thread Dirk Hohndel
On Sun, 2014-03-16 at 02:09 +0800, Farzana Raisa wrote: > I am facing problem in compiling your source code in ubuntu. Though i > have compiled livedivecomputer it is saying unable to locate package > libgit2-dev. What to do? First, sending email just to me is rarely a great idea, unless you have

Re: [PATCH] Improve partial pressure graphs

2014-03-15 Thread Dirk Hohndel
On Sat, 2014-03-15 at 19:00 +0100, Jan Mulder wrote: > This being my first submission to this list, first a very short > introduction. > > I'm an active technical diver, both in long range cave diving context > and a little (deep) wreck diving. Obviously, this involves a lot of > gear, differen

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Tomaz Canabrava
Em 15/03/2014 14:46, "Linus Torvalds" escreveu: > > On Thu, Mar 13, 2014 at 2:06 PM, Miika Turkia wrote: > > On Mon, Mar 10, 2014 at 11:34 PM, Linus Torvalds < torva...@linux-foundation.org> wrote: > >> > >> Yes. We currently have no really good way of *fixing* dive computer > >> event associatio

Re: [PATCH] Improved handling of git syntax names with no git repository

2014-03-15 Thread Linus Torvalds
On Fri, Mar 14, 2014 at 6:22 PM, Thiago Macieira wrote: > > So why didn't you start with 1 or -1? Did you use 8 for alignment on purpose? No, it's really just a random value that I wanted to be *somewhat* unique while being a "small" integer. There's literally nothing else about it. Maybe I shoul

Re: Few bugs and a feature req from testing Subsurface

2014-03-15 Thread Linus Torvalds
On Thu, Mar 13, 2014 at 2:06 PM, Miika Turkia wrote: > On Mon, Mar 10, 2014 at 11:34 PM, Linus Torvalds > wrote: >> >> Yes. We currently have no really good way of *fixing* dive computer >> event association with cylinders. > > So here is log of the two dives. Seems that Vyper, that was download

Re: [PATCH] Ticket #423 - Import GPX file from SD card

2014-03-15 Thread Venkatesh Shukla IIT BHU
On Thu, Mar 13, 2014 at 3:51 AM, Aurélien PRALONG < aurelien.pral...@gmail.com> wrote: > Venkatesh, > > > Firstly, the enhancement is added. That was really necessary. > Great. > > > It might be a good idea to combine both and have something like "sym + > name" shown as the dive name. > Indeed. Ev

[PATCH] Fixed bug in Gpx Import

2014-03-15 Thread Venkatesh Shukla IIT BHU
A mistake in code caused the app to force close in the GPX parser. It works now Signed-off-by: Venkatesh Shukla --- src/org/subsurface/PickGpx.java |6 +++--- src/org/subsurface/PickLocationGpx.java |4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/org/s

Re: [PATCH] Improved handling of git syntax names with no git repository

2014-03-15 Thread Lubomir I. Ivanov
On 15 March 2014 03:22, Thiago Macieira wrote: > Em sex 14 mar 2014, às 18:15:13, Linus Torvalds escreveu: >> And no, no sane OS will have anything in the NULL pointer page. People >> used to do it. They don't do it any more. People who used to do it are >> morons, since they won't get SIGSEGV on

[PATCH] Added date time picker to Mappicker

2014-03-15 Thread Venkatesh Shukla IIT BHU
Added datepicker and time picker (Which looks ugly) to the mappicker dialog. Changes made: 1. Added the date time pickers to mappicker 2. Shifted the divename dialog to PickLocationMap activity to fix change of context, as pointed out by Aurélien 3. Added default dive name for current dive add.