Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

2014-03-21 Thread Gehad Elrobey
The return key auto completes the word while the space key is used to enter another tag not to auto complete. In this case it is impossible to know if you are going to insert a new tag or you just want to move to another field. Regards, Gehad elrobey On Mar 22, 2014 3:41 AM, "Linus Torvalds" wro

Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

2014-03-21 Thread Linus Torvalds
Well, without even testing, I'm assuming this makes the key do what I want for the empty case. But when you *are* actually editing a buddy name, at *that* point you want tab to complete the name, not switch focus. And at that point completing the name with is nonintuitive and possibly even wrong

Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

2014-03-21 Thread Gehad
>From 2af00c8a19628b964b14038bef34d1652790a93e Mon Sep 17 00:00:00 2001 From: Gehad elrobey Date: Sat, 22 Mar 2014 03:18:46 +0200 Subject: [PATCH] Changing the tags separator to space instead of tab the Tab key that is used to separate between the tags and add a comma is replaced by space key s

Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

2014-03-21 Thread Long Wu
Sorry, the three fields are Custom tab widget, not QLineEdit. Sorry for the mistake.. Hugle ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

2014-03-21 Thread Long Wu
> I think it should just go to the next field, so that you can tab > between different fields when filling in a dive. Yes, that is possible by enabling the tabChangesFocus field for tagWidget QLineEdit, buddy QLineEditt and divemaster QLineEdit. [image: Inline image 1] Set it to true will work,

Re: build errors with save-git.c and upstream libgit2

2014-03-21 Thread Lubomir I. Ivanov
On 21 March 2014 19:41, Linus Torvalds wrote: > On Fri, Mar 21, 2014 at 6:19 AM, Lubomir I. Ivanov > wrote: >> >> today today i've tried pulling the latest libgit2 and got the >> following set of errors. >> i don't find 'git_checkout_opts opts' or ' GIT_CHECKOUT_OPTS_INIT' >> declared in the lib

Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

2014-03-21 Thread Linus Torvalds
On Fri, Mar 21, 2014 at 5:31 AM, Anton Lundin wrote: > > Yepp, it looks like it works for the tags field, but not for the Buddy's > field. Btw, what is broken for all those fields (divemaster, buddy, tags) is "tab" when the field is empty (or after you already successfully completed an entry). It

[PATCH] Fix system default font handling

2014-03-21 Thread Anton Lundin
We didn't care about system default fonts and sizes, we just used the Qt default font. Due to how QFont is constructed, there was need to split font and font size. Signed-off-by: Anton Lundin --- linux.c | 3 ++- macos.c | 3 ++- pref.h | 1 + qt-ui/mainw

[PATCH] Make pp graphs visible at startup according to settings

2014-03-21 Thread Jan Mulder
Make pp graphs visible at startup according to settings Changeset a90818671 introduces a small inconvenience. The pp graphs at startup are not shown according to the visibility settings. Requiring to toggle the icons to show the desired pp graph. Trivial fix. best, --jan >From 58f2ff70b4a67

Re: build errors with save-git.c and upstream libgit2

2014-03-21 Thread Alberto Corona
On Fri, Mar 21, 2014 at 12:41 PM, Linus Torvalds wrote: > On Fri, Mar 21, 2014 at 6:19 AM, Lubomir I. Ivanov > wrote: >> >> today today i've tried pulling the latest libgit2 and got the >> following set of errors. >> i don't find 'git_checkout_opts opts' or ' GIT_CHECKOUT_OPTS_INIT' >> declared

Re: [PATCH] Improved logic in cylinder management and gas change events

2014-03-21 Thread Linus Torvalds
On Fri, Mar 21, 2014 at 8:51 AM, Jan Mulder wrote: > > First, I ran in to an obvious bug. Manually add a 2nd cylinder to a dive, > and try to delete it right away. Patch looks sane to me. An alternative (and one I would prefer, actually) is to get rid of that damn "used" flag entirely, and just

Re: build errors with save-git.c and upstream libgit2

2014-03-21 Thread Linus Torvalds
On Fri, Mar 21, 2014 at 6:19 AM, Lubomir I. Ivanov wrote: > > today today i've tried pulling the latest libgit2 and got the > following set of errors. > i don't find 'git_checkout_opts opts' or ' GIT_CHECKOUT_OPTS_INIT' > declared in the libgit2 tree or in our sources. Christ. Looks like they re

Re: Patch and task

2014-03-21 Thread Lakshman
On Fri, Mar 21, 2014 at 6:18 AM, Robert Helling wrote: > > On 21.03.2014, at 12:00, Lakshman wrote: > > Lakshman, > >> Hello Robert, this is an attempt to show computed waypoints along with >> some display graphics. Any feedback will be helpful. >> >> The attached patch includes the patch you pro

[PATCH] Added dependencies and steps to build in README

2014-03-21 Thread Venkatesh Shukla IIT BHU
Minor patch improving documentation of subsurface-android. It includes dependencies and steps to build. >From 41a2b897001fc009b43e53f6fed576954d7ea955 Mon Sep 17 00:00:00 2001 From: Venkatesh Shukla Date: Fri, 21 Mar 2014 22:00:13 +0530 Subject: [PATCH] Added dependencies and steps to build in RE

Re: Patch and task

2014-03-21 Thread Lakshman
On Fri, Mar 21, 2014 at 7:48 AM, Robert Helling wrote: > > Lakshman, > > regarding your proposal: I think you can make it stronger by first focussing > on making the planner with Buehlmann/GF usable and then adding VPM to it. > Further hint: Don’t call Buehlmann mathematical as compared to the p

[PATCH] Improved logic in cylinder management and gas change events

2014-03-21 Thread Jan Mulder
Attached a patch that may result in some discussion. I started looking at some code due to a question from Tomaz about a "ghost cylinder bug". Indeed, the code that is referenced by Tomaz seems straightforward, so where can a ghost-like bug come from? First, I ran in to an obvious bug. Manuall

Re: proposed solution for "#436 Output should be directed to the windows console"

2014-03-21 Thread Thiago Macieira
Em sex 21 mar 2014, às 14:43:17, Lubomir I. Ivanov escreveu: > no idea how to do the piping all stderr/stdout to a QWidget, but it > may be more LOC than the windows.c / WINAPI / console implementation. The idea of doing a widget was so we wouldn't have to figure out the Win32 calls to make it pr

Re: build errors with save-git.c and upstream libgit2

2014-03-21 Thread Lubomir I. Ivanov
On 21 March 2014 15:23, Lubomir I. Ivanov wrote: > On 21 March 2014 15:19, Lubomir I. Ivanov wrote: >> today today i've tried pulling the latest libgit2 and got the >> following set of errors. >> i don't find 'git_checkout_opts opts' or ' GIT_CHECKOUT_OPTS_INIT' >> declared in the libgit2 tree or

Re: build errors with save-git.c and upstream libgit2

2014-03-21 Thread Tomaz Canabrava
On Fri, Mar 21, 2014 at 10:23 AM, Lubomir I. Ivanov wrote: > On 21 March 2014 15:19, Lubomir I. Ivanov wrote: > > today today i've tried pulling the latest libgit2 and got the > > following set of errors. > > i don't find 'git_checkout_opts opts' or ' GIT_CHECKOUT_OPTS_INIT' > > declared in the l

Re: build errors with save-git.c and upstream libgit2

2014-03-21 Thread Lubomir I. Ivanov
On 21 March 2014 15:19, Lubomir I. Ivanov wrote: > today today i've tried pulling the latest libgit2 and got the > following set of errors. > i don't find 'git_checkout_opts opts' or ' GIT_CHECKOUT_OPTS_INIT' > declared in the libgit2 tree or in our sources. by "upsteam", i'm assuming this is an

build errors with save-git.c and upstream libgit2

2014-03-21 Thread Lubomir I. Ivanov
last night i've tried building post the latest additions from linus in save-git.c, but got some errors related to 'git_checkout_opts opts = GIT_CHECKOUT_OPTS_INIT'; today today i've tried pulling the latest libgit2 and got the following set of errors. i don't find 'git_checkout_opts opts' or ' GIT

Re: Patch and task

2014-03-21 Thread Robert Helling
On 21.03.2014, at 12:00, Lakshman wrote: > On Wed, Mar 12, 2014 at 10:55 AM, Robert Helling wrote: >> Hi, >> >> here is a a patch that enables the use of the “entered” field in >> divedatapoint. (It also reenables the planner, so Dirk before applying you >> may want to remove the change to m

Re: Error while building subsurface-android in fedora

2014-03-21 Thread Anton Lundin
On 21 March, 2014 - Venkatesh Shukla IIT BHU wrote: > Hello Anton > > I have been wanting to work on the divecomputer android downloader project > for subsurface during the summer. > You are listed as its mentor. Could you please have a look at my proposal > and give some suggestions or feedback

Re: proposed solution for "#436 Output should be directed to the windows console"

2014-03-21 Thread Lubomir I. Ivanov
On 20 March 2014 20:07, Thiago Macieira wrote: > Em qui 20 mar 2014, às 19:17:19, Lubomir I. Ivanov escreveu: >> but wouldn't that defeat the original idea of showing the --help >> commands in the console? >> c:\subsurface\subsurface.exe --help >> >> >> for --help, --version, exit(1) is called, a

Re: Doubt in deco.c code

2014-03-21 Thread Robert Helling
On 21.03.2014, at 11:05, Gopichand Paturi wrote: > Hi Robert (atdotde), > > I am currently trying to familiarize with the decompression code i.e deco.c. > I have a small doubt. I see this array > > const double buehlmann_He_factor_expositon_one_second[] > > in the code. I didn't understand

Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

2014-03-21 Thread Anton Lundin
On 21 March, 2014 - Gehad wrote: > > On 03/21/2014 12:43 PM, Anton Lundin wrote: > >On 19 March, 2014 - Gehad wrote: > > > >>>From 07f1ac411771627cfba9eae98511d82bbbcdc17b Mon Sep 17 00:00:00 2001 > >>From: Gehad elrobey > >>Date: Wed, 19 Mar 2014 18:07:41 +0200 > >>Subject: [PATCH] Up/Down arro

Error while building subsurface-android in fedora

2014-03-21 Thread Venkatesh Shukla IIT BHU
Hello Anton I have been wanting to work on the divecomputer android downloader project for subsurface during the summer. You are listed as its mentor. Could you please have a look at my proposal and give some suggestions or feedback on how may I improve it. I will be grateful. Also, after the "OS

Re: Patch and task

2014-03-21 Thread Robert Helling
On 21.03.2014, at 12:00, Lakshman wrote: Lakshman, > Hello Robert, this is an attempt to show computed waypoints along with > some display graphics. Any feedback will be helpful. > > The attached patch includes the patch you provided to the community. maybe I misunderstand what this is suppos

Re: [PATCH 2/2] esc-key would discard the new tag selection

2014-03-21 Thread Anton Lundin
On 20 March, 2014 - Gehad wrote: > here is a patch that fixes the esc-key functionality. > > Regards, > > Gehad elrobey This has some "interesting" artifacts. If i Click on the buddy field, When there is already a "Buddy 1" in it, it opens the dropdown with other "tags" to choose from, but the

Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

2014-03-21 Thread Anton Lundin
On 19 March, 2014 - Gehad wrote: > > >From 07f1ac411771627cfba9eae98511d82bbbcdc17b Mon Sep 17 00:00:00 2001 > From: Gehad elrobey > Date: Wed, 19 Mar 2014 18:07:41 +0200 > Subject: [PATCH] Up/Down arrows to scroll the tags completer dont work > > When using Up/Down arrows to scroll the tag li

Re: Doubt in deco.c code

2014-03-21 Thread Anton Lundin
On 21 March, 2014 - Gopichand Paturi wrote: > Also, another small help sir... > This variable, period_in_seconds is a bit misleading my understanding. > Please, let me know it's significance. > > Regards, > Gopichand. > > > On Fri, Mar 21, 2014 at 3:35 PM, Gopichand Paturi > wrote: > > > Hi R

Re: Doubt in deco.c code

2014-03-21 Thread Gopichand Paturi
Also, another small help sir... This variable, period_in_seconds is a bit misleading my understanding. Please, let me know it's significance. Regards, Gopichand. On Fri, Mar 21, 2014 at 3:35 PM, Gopichand Paturi wrote: > Hi Robert (atdotde), > > I am currently trying to familiarize with the de

Doubt in deco.c code

2014-03-21 Thread Gopichand Paturi
Hi Robert (atdotde), I am currently trying to familiarize with the decompression code i.e deco.c. I have a small doubt. I see this array const double buehlmann_He_factor_expositon_one_second[] in the code. I didn't understand what these constants exactly do. I see its usage in computation of fa