Re: Problems while using divecomputer-simulator for linux

2014-03-31 Thread Jef Driesen
On 2014-03-30 21:52, Linus Torvalds wrote: On Sun, Mar 30, 2014 at 12:14 PM, Venkatesh Shukla IIT BHU venkatesh.shukla.ee...@iitbhu.ac.in wrote: I have done as you asked. The output is here : http://pastebin.com/E50ayiSs I have recently shifted to Fedora 20. It worked in Ubuntu earlier.

Re: Problems while using divecomputer-simulator for linux

2014-03-31 Thread Jef Driesen
On 2014-03-30 22:14, Linus Torvalds wrote: On Sun, Mar 30, 2014 at 12:56 PM, Dirk Hohndel d...@hohndel.org wrote: Should libdivecomputer ignore the error when on a PTY? Yeah, I don't see any better approach. In fact, I'd suggest that libdivecomputer get rid of all those checks entirely, and

Crash after saving to a git repo

2014-03-31 Thread Anton Lundin
Hi. I just tried to play around with the save-git-code and had a quite wierd crash after saving, that makes no sens and someone has probably stomped on someone elses memory. *** Error in `/home/anton/Downloads/subsurface-qt5/subsurface': munmap_chunk(): invalid pointer: 0x007efa80 ***

[PATCH] Edit bookmarks name

2014-03-31 Thread Yosef Hamza
here's the patch file to enable the user to edit names of the bookmark to what he sees most informative to him/her. 0001-Edit-Bookmark-name.patch Description: Binary data ___ subsurface mailing list subsurface@hohndel.org

Re: Problems while using divecomputer-simulator for linux

2014-03-31 Thread Linus Torvalds
On Mon, Mar 31, 2014 at 7:38 AM, Dirk Hohndel d...@hohndel.org wrote: BTW, the reason why we have the --enable-pty option, and not some autodetection at runtime, is that I couldn't find an easy way to tell the difference between a pty and a real serial port. No doubt it can be done some way

Re: Crash after saving to a git repo

2014-03-31 Thread Linus Torvalds
On Mon, Mar 31, 2014 at 5:50 AM, Anton Lundin gla...@acc.umu.se wrote: I managed to run the save step via valgrind and noticed: Invalid free() / delete / delete[] / realloc() at 0x4C2B68C: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x5E0030D: set_error (in

Re: Crash after saving to a git repo

2014-03-31 Thread Lubomir I. Ivanov
On 31 March 2014 15:50, Anton Lundin gla...@acc.umu.se wrote: I managed to run the save step via valgrind and noticed: Invalid free() / delete / delete[] / realloc() at 0x4C2B68C: free (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x5E0030D: set_error (in

Re: [PATCH] Don't calculate with NaN when on 100% o2

2014-03-31 Thread Dirk Hohndel
On Mon, 2014-03-31 at 13:04 +0200, Robert Helling wrote: here are two patches. The first I kindof announced on IRC: The depth value taking into account both O2 and N2 is to rate how narced you are and only makes sense for trimix dives (as for nitrox dives it always equals the real depth). The

Re: Patch and task

2014-03-31 Thread Lakshman
On Mon, Mar 31, 2014 at 7:34 AM, Robert Helling hell...@lmu.de wrote: Hello Robert, I think attached patch does what we need. Snapshot is also attached. Commit message has few TODO things that I am working on currently. thanks a lot. Indeed, this seems to work even though that UI has several

Re: [PATCH] Don't calculate with NaN when on 100% o2

2014-03-31 Thread Dirk Hohndel
Willem, I wonder if we want to spend a sentence each in the manual on explaining what we really mean by EAD and END... /D On Mon, 2014-03-31 at 09:01 -0700, Dirk Hohndel wrote: On Mon, 2014-03-31 at 13:04 +0200, Robert Helling wrote: here are two patches. The first I kindof announced on

Fwd: Patch and task

2014-03-31 Thread Lakshman
Hello Dirk, Attached is the patch Robert sent. Thank you, Lakshman -- Forwarded message -- From: Robert Helling hell...@lmu.de Date: Wed, Mar 12, 2014 at 10:55 AM Subject: Patch and task To: Subsurface Mailing List subsurface@hohndel.org Hi, here is a a patch that

Re: Crash after saving to a git repo

2014-03-31 Thread Anton Lundin
On 31 March, 2014 - Linus Torvalds wrote: This very much *looks* like a libgit2 bug. Now, it's obviously possible that somebody else did the real invalid free(), then re-allocated something, and then libgit2 did what *should* have been the real free, but quite frankly, with valgrind claiming

Re: Crash after saving to a git repo

2014-03-31 Thread Dirk Hohndel
On Mon, 2014-03-31 at 19:57 +0200, Anton Lundin wrote: I trigger this after loading my xml file and then trying to save it to a new branch in a fresh git-repo. I'm kinda confused that I'm seem to be the only one hitting this one, because i can reproduce it to 100%. So which version of

Re: [PATCH] Don't calculate with NaN when on 100% o2

2014-03-31 Thread Dirk Hohndel
On Mon, 2014-03-31 at 20:46 +0200, Robert C. Helling wrote: On 31 Mar 2014, at 18:54, Dirk Hohndel d...@hohndel.org wrote: I wonder if we want to spend a sentence each in the manual on explaining what we really mean by EAD and END... Here is my attempt at doing that. Excellent,

Re: [PATCH] Don't calculate with NaN when on 100% o2

2014-03-31 Thread Robert C. Helling
On 31 Mar 2014, at 18:54, Dirk Hohndel d...@hohndel.org wrote: I wonder if we want to spend a sentence each in the manual on explaining what we really mean by EAD and END... 0001-EAD-END-explanation-in-user-manual.-E-is-for-equival.patch Description: Binary data Here is my attempt at

Re: Crash after saving to a git repo

2014-03-31 Thread Anton Lundin
On 31 March, 2014 - Dirk Hohndel wrote: On Mon, 2014-03-31 at 19:57 +0200, Anton Lundin wrote: I trigger this after loading my xml file and then trying to save it to a new branch in a fresh git-repo. I'm kinda confused that I'm seem to be the only one hitting this one, because i can

Re: Crash after saving to a git repo

2014-03-31 Thread Linus Torvalds
On Mon, Mar 31, 2014 at 1:21 PM, Anton Lundin gla...@acc.umu.se wrote: I managed to figure out that the Ubuntu version is built with -DTHREADSAFE=ON, but the packages both in f19 and f20 is built without threadsafe. Ahh. I think we need to call git_threads_init() somewhere. The docs say:

Re: Crash after saving to a git repo

2014-03-31 Thread Anton Lundin
On 31 March, 2014 - Linus Torvalds wrote: On Mon, Mar 31, 2014 at 1:21 PM, Anton Lundin gla...@acc.umu.se wrote: I managed to figure out that the Ubuntu version is built with -DTHREADSAFE=ON, but the packages both in f19 and f20 is built without threadsafe. Ahh. I think we need to

Re: Crash after saving to a git repo

2014-03-31 Thread Linus Torvalds
On Mon, Mar 31, 2014 at 1:51 PM, Anton Lundin gla...@acc.umu.se wrote: Yepp, it fixes things both for current head built threadsafe and the Ubuntu packaged one. Goodie. Dirk, mind applying it with some obvious commit message and my sign-off? I think there should be a git_threads_shutdown()

Re: Crash after saving to a git repo

2014-03-31 Thread Dirk Hohndel
On Mon, 2014-03-31 at 13:52 -0700, Linus Torvalds wrote: On Mon, Mar 31, 2014 at 1:51 PM, Anton Lundin gla...@acc.umu.se wrote: Yepp, it fixes things both for current head built threadsafe and the Ubuntu packaged one. Goodie. Dirk, mind applying it with some obvious commit message and my

[PATCH] Fixing dive notes escape characters in World map exporter

2014-03-31 Thread Gehad
-- Regards, Gehad Elrobey From 7fe2e050df5170a88ada31ec6b876ee1cd0b3640 Mon Sep 17 00:00:00 2001 From: Gehad elrobey gehadelro...@gmail.com Date: Tue, 1 Apr 2014 00:50:58 +0200 Subject: [PATCH] Fixing dive notes escape characters in worldmap exporter Replacing the newlines in the string with

patch built relative to commit 7902af2

2014-03-31 Thread Lakshman
Hello Dirk, Attached are the two patches, one from Robert Helling 0001-Distinguish-between-entered-and-calculated-waypoints.patch and the other by me built relative to Robert' patch. Since, I could not apply patch from Robert onto current master, I went back to the commit 7902af2 and applied his

Re: [PATCH] Fixing dive notes escape characters in World map exporter

2014-03-31 Thread Dirk Hohndel
Stupidly I can't include your patch in my response... oh well. Quick questions: a) I don't think we support any architecture where sizeof(char) isn't just 1 - and we don't do those calculations anywhere else. So I think you might as well drop them. I forgot to ask about that in the first patch

Re: patch built relative to commit 7902af2

2014-03-31 Thread Dirk Hohndel
On Mon, 2014-03-31 at 23:50 -0500, Lakshman wrote: Hello Dirk, Attached are the two patches, one from Robert Helling 0001-Distinguish-between-entered-and-calculated-waypoints.patch and the other by me built relative to Robert' patch. Since, I could not apply patch from Robert onto current

Re: patch built relative to commit 7902af2

2014-03-31 Thread Lakshman
On Tue, Apr 1, 2014 at 12:25 AM, Dirk Hohndel d...@hohndel.org wrote: On Mon, 2014-03-31 at 23:50 -0500, Lakshman wrote: Hello Dirk, Attached are the two patches, one from Robert Helling 0001-Distinguish-between-entered-and-calculated-waypoints.patch and the other by me built relative to