Re: [RFC] Operating system name/version detection

2014-04-10 Thread Dirk Hohndel
Thiago, I believe this is largely borrowed from your code - can you work with Joshua on good / correct attribution of the code origin. Also, would you do a quick review of the code? I asked Joshua to send it here so I could test it and everyone could provide input. Robert (or any of the other

Re: unable to complete cross-building on fedora 20

2014-04-10 Thread Alberto Corona
On 2014-04-09 22:52, Lakshman wrote: 2) I tried building marble following lines 204-211 of INSTALL file. When I ran mingw32-cmake -DCMAKE_BUILD_TYPE=Debug -DQTONLY=TRUE ../sources I got the following error: /usr/bin/mingw32-cmake: line 70: fg: no job control I have no idea about this error and

Re: [PATCH] Ticket #473: Add option of saving User ID in xml

2014-04-10 Thread Dirk Hohndel
Hi Venkatesh, sorry this took longer than usual - things have been crazy busy for me. Sadly none of the other developers provided review, either (cough, cough)... Added feature of saving subsurface userid in local files (xml as well as the git repo) as per ticket #473 For git repo,

Re: [PATCH] Changing some references of QSettings to the pref struct.

2014-04-10 Thread Dirk Hohndel
On Tue, 2014-04-08 at 14:11 +0200, Gehad wrote: This patch changes some references of QSettings to the preference struct. Thanks. BTW, you don't need the explicit path in this: @@ -1,7 +1,8 @@ #include animationfunctions.h +#include ../../dive.h +#include ../../pref.h #include

Re: [PATCH] Unexpected Behaviour in preference window.

2014-04-10 Thread Tomaz Canabrava
On Thu, Apr 10, 2014 at 2:19 PM, Dirk Hohndel d...@hohndel.org wrote: On Tue, 2014-04-08 at 14:11 +0200, Gehad wrote: On 04/07/2014 10:22 PM, Dirk Hohndel wrote: I'd really like to have a prefs variable that tracks the currently active prefs and only reference that anywhere in the

Re: [RFC] Operating system name/version detection

2014-04-10 Thread Lubomir I. Ivanov
On 10 April 2014 19:20, Dirk Hohndel d...@hohndel.org wrote: Thiago, I believe this is largely borrowed from your code - can you work with Joshua on good / correct attribution of the code origin. Also, would you do a quick review of the code? I asked Joshua to send it here so I could test

a couple of libgit2 0.18 errors

2014-04-10 Thread Lubomir I. Ivanov
tried compiling on linux (old ubuntu) with a libgit2 0.18 from unofficial repo, and i don't think we support it. save-git.c:(.text+0x17c): undefined reference to `git_oid_nfmt' .obj/save-git.o: In function `git_save_dives': save-git.c:(.text+0x1d52): undefined reference to `git_oid_strcmp' these

Re: unable to complete cross-building on fedora 20

2014-04-10 Thread Lakshman
On Thu, Apr 10, 2014 at 11:51 AM, Alberto Corona albe...@0x1a.us wrote: On 2014-04-09 22:52, Lakshman wrote: 2) I tried building marble following lines 204-211 of INSTALL file. When I ran mingw32-cmake -DCMAKE_BUILD_TYPE=Debug -DQTONLY=TRUE ../sources I got the following error:

Re: unable to complete cross-building on fedora 20

2014-04-10 Thread Dirk Hohndel
On Thu, 2014-04-10 at 14:05 -0500, Lakshman wrote: I've never had a no job control error, where were you trying to build marble and libgit2? I think the INSTALL suggests creating a build directory, which I would suggest. You might hit a couple more bumps trying to cross- compile, I

Re: [RFC] Operating system name/version detection

2014-04-10 Thread Thiago Macieira
Em qui 10 abr 2014, às 20:57:02, Lubomir I. Ivanov escreveu: errors: -- 3) 'WV_WINDOWS8_1' is not part of Qt 4.8. i think it should be wrapped in: #if QT_VERSION = QT_VERSION_CHECK(5, 0, 0) ... #endif Make that QT_VERSION_CHECK(5,2,0). It was added only last year. 1) i

Re: [RFC] Operating system name/version detection

2014-04-10 Thread Thiago Macieira
Em qui 10 abr 2014, às 22:31:34, Lubomir I. Ivanov escreveu: for debian based this should be done: int fd = QT_OPEN(/etc/lsb-release, O_RDONLY); I've just checked with a Debian maintainer: /etc/os-release exists on stable, but not on older versions. I will probably have to write a fallback to

Re: [PATCH] Ticket #473: Add option of saving User ID in xml

2014-04-10 Thread Venkatesh Shukla
On Thu, Apr 10, 2014 at 10:35 PM, Dirk Hohndel d...@hohndel.org wrote: Hi Venkatesh, sorry this took longer than usual - things have been crazy busy for me. Sadly none of the other developers provided review, either (cough, cough)... Added feature of saving subsurface userid in local

Re: [PATCH] Ticket #473: Add option of saving User ID in xml

2014-04-10 Thread Dirk Hohndel
On Fri, 2014-04-11 at 08:34 +0530, Venkatesh Shukla wrote: +static void parse_settings_userid(char *line, struct membuffer *str, void *_unused) +{ + char *uid = line; + if (uid) + { +

Re: [RFC] Operating system name/version detection

2014-04-10 Thread Thiago Macieira
Em qui 10 abr 2014, às 15:07:10, Dirk Hohndel escreveu: For example, the need to read /etc/lsb-release so we can detect Ubuntu… mumble, grumble, whatever Ditto, but Qt 5.4 will need to work with it. I won't have a choice. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT)