Re: [PATCH] git-save: improve commit authorship data

2014-04-14 Thread Linus Torvalds
On Mon, Apr 14, 2014 at 3:53 PM, Dirk Hohndel wrote: > On Mon, 2014-04-14 at 14:41 -0700, Linus Torvalds wrote: >> + const char hostname[64]; Ugh, yes, that "const" is bogus. It was "const char *" with a helper function in an earlier incantation, and then I made it a direct array and

Re: [PATCH] git-save: improve commit authorship data

2014-04-14 Thread Dirk Hohndel
On Mon, 2014-04-14 at 14:41 -0700, Linus Torvalds wrote: > diff --git a/linux.c b/linux.c > index ea0170dc89f8..03d0bfbf9670 100644 > --- a/linux.c > +++ b/linux.c > + if (username && *username) { > + const char hostname[64]; > + struct membuffer mb = { 0 }; > +

[PATCH] git-save: improve commit authorship data

2014-04-14 Thread Linus Torvalds
From: Linus Torvalds Date: Mon, 14 Apr 2014 14:33:46 -0700 Subject: [PATCH] git-save: improve commit authorship data We used to always just commit as "subsurface@hohndel.org" because libgit-19 doesn't have the interfaces to do user name lookup. This does better if you have libgit-20, using "git_

Re: first try to use a unit test based framework

2014-04-14 Thread Tomaz Canabrava
two patches that goes on top of the last three ones: 1 - list of files insteaf of grepping to *.c 2 - specify the libdcdevel path On Mon, Apr 14, 2014 at 2:35 PM, Tomaz Canabrava wrote: > Second try, with dirk's input on IRC. > > > On Mon, Apr 14, 2014 at 1:46 PM, Tomaz Canabrava wrote: > >> >

Re: first try to use a unit test based framework

2014-04-14 Thread Tomaz Canabrava
Second try, with dirk's input on IRC. On Mon, Apr 14, 2014 at 1:46 PM, Tomaz Canabrava wrote: > > So - > CMake has a testing framework called CTest that can generate html reports > and it's easy to integrate a new test on it. I created this in cmake *only* > because it was what I had used befor

first try to use a unit test based framework

2014-04-14 Thread Tomaz Canabrava
So - CMake has a testing framework called CTest that can generate html reports and it's easy to integrate a new test on it. I created this in cmake *only* because it was what I had used before, tried to learn the docs for qmake + tests and it was a bit frustrating / hard to do. what this does rig

Re: [PATCH] Unexpected Behaviour in preference window.

2014-04-14 Thread Dirk Hohndel
On Sat, 2014-04-12 at 14:02 +0200, Gehad wrote: > On 04/11/2014 04:19 PM, Dirk Hohndel wrote: > > > > I think I had something slightly different in mind: > > > > The prefs variable should contain a member for each setting. And we need That was too simplistic :-) > > to redo those members so they

Re: [PATCH] Mark Air/Water temp field red for wrong input.

2014-04-14 Thread Dirk Hohndel
On Mon, 2014-04-14 at 09:23 -0500, Lakshman wrote: > On Mon, Apr 14, 2014 at 7:30 AM, Dirk Hohndel wrote: > > > > This works well - but when playing with it I noticed that currently > > edits are broken - they don't modify the data in the dive. > > > > This is not something that your patch broke,

Re: [PATCH] Mark Air/Water temp field red for wrong input.

2014-04-14 Thread Lakshman
On Mon, Apr 14, 2014 at 7:30 AM, Dirk Hohndel wrote: > > This works well - but when playing with it I noticed that currently > edits are broken - they don't modify the data in the dive. > > This is not something that your patch broke, though. I'll need to figure > out when that happened. > Dirk, t

Re: [PATCH] Mark Air/Water temp field red for wrong input.

2014-04-14 Thread Dirk Hohndel
On Mon, 2014-04-14 at 15:30 +0200, Yosef Hamza wrote: > Actually I tried to fix this one "#457" I guess week ago, I ended up > with the exact same fix on the bug page, and I submitted it here on > the mailing list questioning why it's not accepted before yet it was > ack by Linus too. > > But got

Re: [PATCH] Mark Air/Water temp field red for wrong input.

2014-04-14 Thread Yosef Hamza
On Mon, Apr 14, 2014 at 3:00 PM, Miika Turkia wrote: > On Mon, Apr 14, 2014 at 3:30 PM, Dirk Hohndel wrote: > >> >> This works well - but when playing with it I noticed that currently >> edits are broken - they don't modify the data in the dive. >> >> This is not something that your patch broke,

Re: [PATCH] Mark Air/Water temp field red for wrong input.

2014-04-14 Thread Miika Turkia
On Mon, Apr 14, 2014 at 3:30 PM, Dirk Hohndel wrote: > > This works well - but when playing with it I noticed that currently > edits are broken - they don't modify the data in the dive. > > This is not something that your patch broke, though. I'll need to figure > out when that happened. > bug #

Re: [PATCH] Mark Air/Water temp field red for wrong input.

2014-04-14 Thread Dirk Hohndel
This works well - but when playing with it I noticed that currently edits are broken - they don't modify the data in the dive. This is not something that your patch broke, though. I'll need to figure out when that happened. /D ___ subsurface mailing l

Re: Ceiling Icons

2014-04-14 Thread Dirk Hohndel
On Sun, 2014-04-13 at 20:59 +0200, Willem Ferguson wrote: > On 11/04/2014 20:49, Luisa Pires wrote: > > > Willem, > > > > > > I agree, if the graph is red, the graph in the button should be red > > as well. I'm attaching the new version. > > > > > > Regarding the last three..if they work kin