Re: error while building unittests

On Thu, May 8, 2014 at 9:52 PM, Tomaz Canabrava wrote: > that`s because the unittests are broken because they depend on the > mainwindow and shouldn`t. > since 4.1 opened, you can help me to remove the calls to > MainWindow::instance from the code > also, MainWindow::information > Tomaz, I am sorr

Re: error while building unittests

that`s because the unittests are broken because they depend on the mainwindow and shouldn`t. since 4.1 opened, you can help me to remove the calls to MainWindow::instance from the code also, MainWindow::information On Thu, May 8, 2014 at 11:48 PM, Lakshman wrote: > Can anyone help me fix this er

error while building unittests

Can anyone help me fix this error. Faced it while compiling unittests on ubuntu 14.04. [ 28%] Built target TestProfile_automoc Linking CXX executable TestProfile libsubsurface_corelib.a(qthelper.cpp.o): In function `parseGpsText(QString const&, double*, double*)': qthelper.cpp:(.text+0xda8): undef

Populate planner dive list by copying cylinders from selected dive

0001-When-starting-the-planner-copy-cylinders-from-curren.patch Description: Binary data Instead of starting from an empty gas list in the planner, the gases of a currently selected dive is copied. Good night Robert --

[PATCH] Use the used flag on cylinders in get_dive_gas

Now when we have a used flag on every cylinder that are set in mark_used_tanks we can use it here. Signed-off-by: Anton Lundin --- divelist.c | 39 +++ 1 file changed, 3 insertions(+), 36 deletions(-) diff --git a/divelist.c b/divelist.c index f0a66b4..f8d3d7

[PATCH] Use enum name instead of its int value.

SAMPLE_EVENT_GASCHANGE2 is the libdivecomputer name of the event. Compare with that instead of its int value. Signed-off-by: Anton Lundin --- profile.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/profile.c b/profile.c index 373ac8e..8289f68 100644 --- a/profile.c ++

[PATCH] Remove unnecessary include from dive.c

Signed-off-by: Anton Lundin --- dive.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dive.c b/dive.c index 4bae245..dbd811a 100644 --- a/dive.c +++ b/dive.c @@ -6,7 +6,6 @@ #include #include "gettext.h" #include "dive.h" -#include "planner.h" struct tag_entry *g_tag_list = NULL; --

[PATCH] Fix building with NO_MARBLE after prototype change

4243fcb915 ("Dont set coordinates when two or more dives are selected") Changed how the prototypes in GlobeGPS looks. This aligns NO_MARBLE version of GlobeGPS with that. Signed-off-by: Anton Lundin --- qt-ui/globe.cpp | 2 +- qt-ui/globe.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions

Re: heads up 4.1 and personal down time

On 08 May 2014, at 21:28, Dirk Hohndel wrote: > These have all been added Here are two more for the planner: planner0003.diff Description: Binary data planner0004.diff Description: Binary data 0003 makes the the table for waypoints show the gas for the _next_ segment rather than the pre

Re: heads up 4.1 and personal down time

On Mon, 2014-05-05 at 13:55 +0200, Robert Helling wrote: > On 04.05.2014, at 19:13, Dirk Hohndel wrote: > > Hi, > > > I know that Tomaz will be preparing a rather intrusive set of commits in > > the meantime that tries to clean up some of the mess we created over > > time. Bad separation of UI a

Re: [PATCH] Rewrite show_location to use membuffer primitives

While I didn't take this for 4.1 (I guess I should), I just applied it to master. Thanks Anton /D On Wed, 2014-05-07 at 00:30 +0200, Anton Lundin wrote: > This simplifies the logic and doesn't rely on show_utf8 to print empty > blocks. > > Signed-off-by: Anton Lundin > --- > save-xml.c | 58

Anyone heading to TekDive USA this month?

I will be down in Miami for the inaugural TekDive USA conference and then to watch a friend get his butt kicked in his normoxic trimix class. Is anyone else going? Interested in a subsurface get-together? We will also be doing 5 or 6 days of diving in the 200’ range (up to 20% He) and I belie

Subsurface 4.1 has been released

Hi everyone! Binaries are on the server, tag was pushed, the announcements are about to go out. Which reminds me that I still have no list of default outlets that we send the release announcement to via email. Oops. Need to do that. Thanks to everyone for the hard work. A few of you really helped

Re: [PATCH] Fix crash on dereferencing dangling pointers

Em qui 08 maio 2014, às 07:32:59, Tomaz Canabrava escreveu: > Em 08/05/2014 01:52, "Thiago Macieira" escreveu: > > QList::first() returns a reference to an item, but that list was a > > temporary. The list gets destroyed at the end of the statement (the > > semi-colon), so we ended up keeping a re

Re: User manual for version 4.1

On Thu, 2014-05-08 at 14:08 +0200, Willem Ferguson wrote: > 1) There is a user manual on the Subsurface web site > > http://subsurface.hohndel.org/documentation/subsurface-4-0-user-manual-2/ > > One should see that the manual for version 4.1 is posted there > as well. Yes, that's alwa

User manual for version 4.1

1) There is a user manual on the Subsurface web site http://subsurface.hohndel.org/documentation/subsurface-4-0-user-manual-2/ One should see that the manual for version 4.1 is posted there as well. 2) Latest update to the user manual not reflected in git master yet. Hope it was rec

Re: [PATCH] Fix crash on dereferencing dangling pointers

Em 08/05/2014 01:52, "Thiago Macieira" escreveu: > > QList::first() returns a reference to an item, but that list was a > temporary. The list gets destroyed at the end of the statement (the > semi-colon), so we ended up keeping a reference to freed data (i.e., a > dangling pointer0 I thought a co