Re: [PATCH] Rework slot to quiet down Qt5 warning

On 25 May, 2014 - Tomaz Canabrava wrote: > doesn't. > > On Sun, May 25, 2014 at 7:44 PM, Dirk Hohndel wrote: > > Did you really want to just simply remove the connect? Maybe there's some > > implicit magic that I'm missing, but to me this looks wrong. > > > > /D > > > > On Mon, May 26, 2014 at 1

Re: [PATCH] Rework slot to quiet down Qt5 warning

doesn't. On Sun, May 25, 2014 at 7:44 PM, Dirk Hohndel wrote: > Did you really want to just simply remove the connect? Maybe there's some > implicit magic that I'm missing, but to me this looks wrong. > > /D > > On Mon, May 26, 2014 at 12:06:56AM +0200, Anton Lundin wrote: >> diff --git a/qt-ui/d

Re: [PATCH] Rework slot to quiet down Qt5 warning

Did you really want to just simply remove the connect? Maybe there's some implicit magic that I'm missing, but to me this looks wrong. /D On Mon, May 26, 2014 at 12:06:56AM +0200, Anton Lundin wrote: > diff --git a/qt-ui/downloadfromdivecomputer.cpp > b/qt-ui/downloadfromdivecomputer.cpp > index

Re: [PATCH] Make ISO-6709 coordinate regex less restrictive

On Mon, May 26, 2014 at 12:02:33AM +0200, José Carlos Andreu Galán wrote: > I found myself trying to copy/paste coordinates for my dives from diving > websites / forums and Subsurface did not accept them because it was > applying strictly the suggestions from ISO6709 Annex D. > Now it parses them c

[PATCH] Make ISO-6709 coordinate regex less restrictive

I found myself trying to copy/paste coordinates for my dives from diving websites / forums and Subsurface did not accept them because it was applying strictly the suggestions from ISO6709 Annex D. Now it parses them correctly with messy whitespace and use of '' (double simple quotes) instead of " (

[PATCH] Use gas_mod and fix fpe

When removing o2 from a gas, eg setting it to "", air, this code would raise a nice fpe. Fix that by using gas_mod instead. Signed-off-by: Anton Lundin --- qt-ui/models.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qt-ui/models.cpp b/qt-ui/models.cpp index dc9a718..2

[PATCH] Rework slot to quiet down Qt5 warning

Qt5 got confused about this slot. This does the same as previously but gets Qt5 happy. Signed-off-by: Anton Lundin --- qt-ui/downloadfromdivecomputer.cpp | 5 ++--- qt-ui/downloadfromdivecomputer.h | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/qt-ui/downloadfromdivecom

Re: [PATCH] Use gas_mod and fix fpe

This is crap. Managed to get some other things included in this commit. I'm going to clean this up and re-send. //Anton On 25 May, 2014 - Anton Lundin wrote: > When removing o2 from a gas, eg setting it to "", air, this code would > raise a nice fpe. Fix that by using gas_mod instead. > > Sig

[PATCH] Use gas_mod and fix fpe

When removing o2 from a gas, eg setting it to "", air, this code would raise a nice fpe. Fix that by using gas_mod instead. Signed-off-by: Anton Lundin --- qt-ui/downloadfromdivecomputer.cpp | 5 ++--- qt-ui/downloadfromdivecomputer.h | 2 +- qt-ui/models.cpp | 4 +++- 3 file

some, barely working, patches.

I need help to figure out what's happening here, spend a whole day without a clear approach. when the plannerModel->setState(ADD) things works, when the planer->setState(PLAN), things don't. ( calling this from the MainWindow::on_actionDivePlanner_triggered ) Patches: From 65a432e7ac815bace6eb33

Do not access gas permilles directly

Hi, 0001-use-get_o2-and-get_he-instead-of-accessing-permilles.patch Description: Binary data this patch removes all unnecessary occurrences of gasmix.o2.permille in favour of get_o2(). This gets around the problem that air is (o2=he=0) in relation with comparing gases. Best Robert --

Re: last patches for today

On Sun, May 25, 2014 at 11:06:22AM -0300, Tomaz Canabrava wrote: > Being away from 4 timezones and waking up at the same time: irony. You must be confused. I woke up 3 hours ago and have been working on Subsurface since 5:30... > gonna do breakfast and will be subsurfing again. :) By then my gue

Aktuelle Version 4.x

Hallo Hohndel Ich wollte fragen ob die Aktuelle Version auf für Deb / Ubuntu geben wird? Leider schaff ich es nicht selber zu Kompilieren ausser unschönen Error Meldungen kommt nichts zu Stande, aber kenne mich natürlich auch nicht wirklich aus, würde mich freuen wenn es die neue Version auch für

Re: Aktuelle Version 4.x

Hallo Dirk Vielen Dank mit dem PPA von Miika hats funktioniert. wie gesagt coole tolles Programm macht weiter so!!! grüsse Dewet Mit freundlichen Grüsse D.Widmer *BITTE BESTÄTIGEN SIE DEN ERHALT DIESER EMAIL. PLEASE CONFIRM THE RECEIPT OF THIS EMAIL.S'IL VOUS PLAÎT confirmer la récep

Re: last patches for today

Being away from 4 timezones and waking up at the same time: irony. gonna do breakfast and will be subsurfing again. :) On Sun, May 25, 2014 at 10:49 AM, Dirk Hohndel wrote: > On Sun, May 25, 2014 at 12:57:04AM -0300, Tomaz Canabrava wrote: >> three - the last one I commented three lines so the co

Re: last patches for today

On Sun, May 25, 2014 at 12:57:04AM -0300, Tomaz Canabrava wrote: > three - the last one I commented three lines so the code compiles, but > I most probably broke something with that. there's a huge TODO on it > so I remember to unbreak things tomorrow when I wake. All this (including the TODOs) as

Re: Aktuelle Version 4.x

On Sun, May 25, 2014 at 12:08:29PM +0200, ch4123allsch...@gmail.com wrote: > Hallo Hohndel > > Ich wollte fragen ob die Aktuelle Version auf für Deb / Ubuntu geben wird? Die Frage sollte man doch eher dem Debian oder Ubuntu Maintainer stellen, oder? > Leider schaff ich es nicht selber zu Kompili

[PATCH v2] Move mod calculations to a separate helper

We use mod calculations on multiple places, so make a separate helper from it with proper types. The "clumsiness" of defining a local variable to pass into the function and out from it comes from the discrepancies in how c and c++ handles initializations of variables in a struct. Thanks goes to T