Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

2014-03-21 Thread Gehad Elrobey
The return key auto completes the word while the space key is used to enter another tag not to auto complete. In this case it is impossible to know if you are going to insert a new tag or you just want to move to another field. Regards, Gehad elrobey On Mar 22, 2014 3:41 AM, "Linus Torvalds" wro

Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

2014-03-21 Thread Linus Torvalds
Well, without even testing, I'm assuming this makes the key do what I want for the empty case. But when you *are* actually editing a buddy name, at *that* point you want tab to complete the name, not switch focus. And at that point completing the name with is nonintuitive and possibly even wrong

Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

2014-03-21 Thread Gehad
>From 2af00c8a19628b964b14038bef34d1652790a93e Mon Sep 17 00:00:00 2001 From: Gehad elrobey Date: Sat, 22 Mar 2014 03:18:46 +0200 Subject: [PATCH] Changing the tags separator to space instead of tab the Tab key that is used to separate between the tags and add a comma is replaced by space key s

Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

2014-03-21 Thread Long Wu
Sorry, the three fields are Custom tab widget, not QLineEdit. Sorry for the mistake.. Hugle ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

2014-03-21 Thread Long Wu
> I think it should just go to the next field, so that you can tab > between different fields when filling in a dive. Yes, that is possible by enabling the tabChangesFocus field for tagWidget QLineEdit, buddy QLineEditt and divemaster QLineEdit. [image: Inline image 1] Set it to true will work,

Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

2014-03-21 Thread Linus Torvalds
On Fri, Mar 21, 2014 at 5:31 AM, Anton Lundin wrote: > > Yepp, it looks like it works for the tags field, but not for the Buddy's > field. Btw, what is broken for all those fields (divemaster, buddy, tags) is "tab" when the field is empty (or after you already successfully completed an entry). It

Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

2014-03-21 Thread Anton Lundin
On 21 March, 2014 - Gehad wrote: > > On 03/21/2014 12:43 PM, Anton Lundin wrote: > >On 19 March, 2014 - Gehad wrote: > > > >>>From 07f1ac411771627cfba9eae98511d82bbbcdc17b Mon Sep 17 00:00:00 2001 > >>From: Gehad elrobey > >>Date: Wed, 19 Mar 2014 18:07:41 +0200 > >>Subject: [PATCH] Up/Down arro

Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

2014-03-21 Thread Anton Lundin
On 19 March, 2014 - Gehad wrote: > > >From 07f1ac411771627cfba9eae98511d82bbbcdc17b Mon Sep 17 00:00:00 2001 > From: Gehad elrobey > Date: Wed, 19 Mar 2014 18:07:41 +0200 > Subject: [PATCH] Up/Down arrows to scroll the tags completer dont work > > When using Up/Down arrows to scroll the tag li

Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

2014-03-19 Thread Miika Turkia
Excellent, this fixes the dive buddy and DM fields as well! If only esc-key would discard the new tag/buddy selection, not accept it. Care to add that feature as well? miika ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi

Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

2014-03-19 Thread Lubomir I. Ivanov
On 19 March 2014 18:24, Gehad wrote: > > Acked-by: Lubomir I. Ivanov lubomir -- ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface