gt;
> > > > >> > > Its also a really god idea to include a changelog
> addressing the
> > > > >> review
> > > > >> > > comments from the last submission.
> > > > >> &g
hink
> > > there's
> > > > >> a very
> > > > >> > > > easy way to do so without reworking quite a bit of the
> > > mainwindow
> > > > >> (for
> > > > >> > > > which I'm too inexperienced with Qt for to change).
> > > >
>> > > way as you submitted your first patch.
> > > >> > >
> > > >> > > Its also a really god idea to include a changelog addressing the
> > > >> review
> > > >> > > comments from the last submission.
> > >
> >
> > >> > >
> > >> > > So, pleas go back and look at the comments from the last
> submission
> > >> and
> > >> > > tell us how you have addressed those.
> > >> > >
> > >> > >
> > >> > > //Anton
> >
t; >
> >> > > > >
> >> > > > > The changes are here
> >> > > > >
> >> https://github.com/0x1A/subsurface/commit/eb215101097120f8c62339fd767b71574cdd0bbd
> >> > > > >
> >> > > >
M, Dirk Hohndel
>> wrote:
>> > > > >
>> > > > >> On Mon, 2014-03-03 at 18:17 -0600, Alberto Corona wrote:
>> > > > >> > Ok so I've got things working now, though I'd like to see if
>> Anton is
>> > > >
e blank
> > > >> > dummy widget.
> > > >> >
> > > >>
> > > >> And where would we find those changes?
> > > >>
> > > >> /D
> > > >>
> > > >>
> > > >>
>
> >>
> > >>
> > >
>
> > ___
> > subsurface mailing list
> > subsurface@hohndel.org
> > http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
>
>
> --
> Anton Lundin +46
On 03 March, 2014 - Alberto Corona wrote:
> Here's the link again as I forgot to include the list
> https://github.com/0x1A/subsurface/commit/eb215101097120f8c62339fd767b71574cdd0bbd
>
> Like Anton said, this is a bit hacky, though I don't think there's a very
> easy way to do so without reworkin
Here's the link again as I forgot to include the list
https://github.com/0x1A/subsurface/commit/eb215101097120f8c62339fd767b71574cdd0bbd
Like Anton said, this is a bit hacky, though I don't think there's a very
easy way to do so without reworking quite a bit of the mainwindow (for
which I'm too in
On Mon, 2014-03-03 at 18:17 -0600, Alberto Corona wrote:
> Ok so I've got things working now, though I'd like to see if Anton is
> ok with the changes. Unfortunately, I'm not familiar enough with Qt to
> change the way the splitters work in order to get rid of the blank
> dummy widget.
>
And wher
Ok so I've got things working now, though I'd like to see if Anton is ok
with the changes. Unfortunately, I'm not familiar enough with Qt to change
the way the splitters work in order to get rid of the blank dummy widget.
On Sat, Mar 1, 2014 at 10:01 AM, Alberto Corona wrote:
> Again, I apologi
Again, I apologize, my intentions were not to pass them solely as my own.
I'll get things fixed with the qmake configurations, the panel and Anton's
authorship if he sees the changes are optimal.
On Mar 1, 2014 9:16 AM, "Dirk Hohndel" wrote:
> On Sat, 2014-03-01 at 08:08 -0600, Alberto Corona wro
Hey Lubomir,
thanks for the great review and feedback. Much appreciated.
my other email focused on the origin of the patch - so Alberto, as you
continue to work on this, please take Lubomir's comments into account as
well.
/D
On Sat, 2014-03-01 at 12:15 +0200, Lubomir I. Ivanov wrote:
> On 1 M
On Sat, 2014-03-01 at 08:08 -0600, Alberto Corona wrote:
> My intentions weren't to pass someone else's code as mine, hence
> "Implemented some changes suggested by glance", though you're right, I
> should have asked them first.
No. "some changes suggested by glance" means you talked to him and t
My intentions weren't to pass someone else's code as mine, hence
"Implemented some changes suggested by glance", though you're right, I
should have asked them first. Some of changes in the .pro and .pri files do
not work, I sent this in a bit premature (that's what I get for trying to
write a patch
On 01 March, 2014 - Alberto wrote:
> From: Alberto Corona
>
> Implemented some changes suggested by glance
> Building could now be done without having to have Marble installed
> Fixes #394
>
> Signed-off-by: Alberto Corona
I would suggest not taking this patch. The reason why i never submitte
On 1 March 2014 08:15, Alberto wrote:
> From: Alberto Corona
>
> Implemented some changes suggested by glance
> Building could now be done without having to have Marble installed
> Fixes #394
>
hello,
this is a fix in the correct direction. i've added some notes bellow.
> Signed-off-by: Alberto
From: Alberto Corona
Implemented some changes suggested by glance
Building could now be done without having to have Marble installed
Fixes #394
Signed-off-by: Alberto Corona
---
qt-ui/globe.cpp | 11 +++
qt-ui/globe.h| 21 +
qt-ui/mainwindow.h
19 matches
Mail list logo
