Re: [PATCH] Rework slot to quiet down Qt5 warning

2014-05-26 Thread Anton Lundin
On 25 May, 2014 - Tomaz Canabrava wrote: doesn't. On Sun, May 25, 2014 at 7:44 PM, Dirk Hohndel d...@hohndel.org wrote: Did you really want to just simply remove the connect? Maybe there's some implicit magic that I'm missing, but to me this looks wrong. /D On Mon, May 26, 2014 at

Re: [PATCH] Rework slot to quiet down Qt5 warning

2014-05-25 Thread Dirk Hohndel
Did you really want to just simply remove the connect? Maybe there's some implicit magic that I'm missing, but to me this looks wrong. /D On Mon, May 26, 2014 at 12:06:56AM +0200, Anton Lundin wrote: diff --git a/qt-ui/downloadfromdivecomputer.cpp b/qt-ui/downloadfromdivecomputer.cpp index

Re: [PATCH] Rework slot to quiet down Qt5 warning

2014-05-25 Thread Tomaz Canabrava
doesn't. On Sun, May 25, 2014 at 7:44 PM, Dirk Hohndel d...@hohndel.org wrote: Did you really want to just simply remove the connect? Maybe there's some implicit magic that I'm missing, but to me this looks wrong. /D On Mon, May 26, 2014 at 12:06:56AM +0200, Anton Lundin wrote: diff --git