Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-12 Thread Dirk Hohndel
On Wed, 2014-03-12 at 19:01 +0200, Lubomir I. Ivanov wrote: so perhaps the patch can be modified to exclude the preferences dialog change? I would accept a patch modified like that. I just think there are a few scenarios in which it is nice if the preferences dialog is not modal.

Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-12 Thread Lubomir I. Ivanov
On 12 March 2014 19:12, Dirk Hohndel d...@hohndel.org wrote: On Wed, 2014-03-12 at 19:01 +0200, Lubomir I. Ivanov wrote: so perhaps the patch can be modified to exclude the preferences dialog change? I would accept a patch modified like that. I just think there are a few scenarios in

Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-11 Thread Dirk Hohndel
On Tue, 2014-03-11 at 18:30 +0200, Lubomir I. Ivanov wrote: From: Lubomir I. Ivanov neolit...@gmail.com For some dialogs like Preferences and Renumber it would be much safer to make them Qt::WindowModal to the parent (MainWindow). Initially the Preferences was non-modal on purpose. So the

Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-11 Thread Lubomir I. Ivanov
On 11 March 2014 20:23, Dirk Hohndel d...@hohndel.org wrote: On Tue, 2014-03-11 at 18:30 +0200, Lubomir I. Ivanov wrote: From: Lubomir I. Ivanov neolit...@gmail.com For some dialogs like Preferences and Renumber it would be much safer to make them Qt::WindowModal to the parent (MainWindow).

Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-11 Thread Linus Torvalds
On Tue, Mar 11, 2014 at 11:35 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: most software that i've used make any preferences dialog modal. one potential user interaction issue here is if the main window is maximized [..] I've had the opposite problem. The damn modal window isn't a real

Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-11 Thread Tomaz Canabrava
On Tue, Mar 11, 2014 at 3:52 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Tue, Mar 11, 2014 at 11:35 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: most software that i've used make any preferences dialog modal. one potential user interaction issue here is if the main

Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-11 Thread Linus Torvalds
On Tue, Mar 11, 2014 at 11:57 AM, Tomaz Canabrava tcanabr...@kde.org wrote: A 'Toggle Units' button on the toolbar can simplify this, what you think? Yes, I'd probably use that instead. Linus ___ subsurface mailing list

Re: [PATCH 2/4] Make some dialogs modal to MainWindow

2014-03-11 Thread Lubomir I. Ivanov
On 11 March 2014 20:23, Dirk Hohndel d...@hohndel.org wrote: On Tue, 2014-03-11 at 18:30 +0200, Lubomir I. Ivanov wrote: From: Lubomir I. Ivanov neolit...@gmail.com For some dialogs like Preferences and Renumber it would be much safer to make them Qt::WindowModal to the parent (MainWindow).